Commit graph

685 commits

Author SHA1 Message Date
Ferdinand Thiessen
f02bcf3471
test(files): Add tests for path handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 11:09:17 +02:00
Ferdinand Thiessen
020b3ee25e
fix(files): Ensure children are removed from folder and not duplicated
* Resolves https://github.com/nextcloud/server/issues/47904

We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 11:09:17 +02:00
Louis Chemineau
699ce26e42
fix: Restore missing dot in FilesListVirtual.vue
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-15 11:09:37 +02:00
Louis Chemineau
2da1c5717e
feat: Reset route if neither the Viewer of the Sidebar is open
When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-14 21:50:23 +02:00
Ferdinand Thiessen
7a345f68dc fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 13:44:12 +02:00
Ferdinand Thiessen
49c2d1819e
fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 13:19:25 +02:00
Christopher Ng
060783c4f4 fix(files): Render folders in natural sort order
- Nodes are returned from the endpoint in an undefined order

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-09 16:11:43 -07:00
Christopher Ng
6b079e67a2 fix(files): Sort tree views correctly by natural order
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-09 16:11:43 -07:00
Ferdinand Thiessen
b7e2d5032f
fix(files): Fallback icons should fill the container
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 14:08:51 +02:00
Ferdinand Thiessen
4a90d5328c
test: Add end-to-end tests for new public share Vue UI
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
be884eeaec
fix(files): "Edit locally" action should not be shown on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
018af2a2fe
fix(files): Do not add click listener if there is no default action on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
c9dc0afcb1
fix(files): "New folder" menu entry requires read permission
This will disable "New folder" menu entry for file-drop shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
80033bde88
fix(files): Disable internal views on public shares
This is needed because some views have side effects, like `favorites` doing requests on registration time.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
e93ceea804
fix(files): Do not allow copy action on public shares without create permission
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
a84de3c755
feat(files): Allow to download files on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
ada6a61688
fix(files): Do not allow rename action on single-file-shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
f0a765ee46
fix(files): Disable copy-move-action of single file shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
f109c1a044
refactor(files): Make RouterService provide a protected getter for the router to allow injecting the files_sharing router
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
82a7a3971d
fix(files): Adjust files list for sharing permissions on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
819f5cea9b
fix(files): Fix file previews for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
767e87a466
fix(files): Do not use favorite, sidebar and view-in-folder action for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
96c8275586
feat(files_sharing): Migrate public share to use Vue files list
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:42 +02:00
skjnldsv
1ece5b975d fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 18:12:34 +00:00
skjnldsv
62878c5ece fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 14:10:37 +02:00
Christopher Ng
930a5141ea fix(files): Fix navigating with breadcrumbs not highlighting navigation entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-03 10:34:03 -07:00
Ferdinand Thiessen
f01c8efa38 fix(files): Node loading information should be accessible
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 18:39:16 +02:00
Ferdinand Thiessen
75a684a8d3
chore(files): Fix remaining TypeScript errors in FileEntryPreview
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 23:08:13 +02:00
Louis Chemineau
56e4859201
feat: Use the blurhash in Files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-29 23:08:11 +02:00
Louis Chemineau
c42f010167 fix(files): Remove margin and width to not break layout
In grid view, this was messing with the reported available list width which was breaking the computed layout.

Fix https://github.com/nextcloud/server/issues/47599

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-29 11:50:25 +00:00
Ferdinand Thiessen
aea0e8df6a fix: Adjust more places for logical position
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Mostafa Ahangarha
723780d184 feat: Add bidi support in core directory
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
Ferdinand Thiessen
030c209d22 fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +02:00
Christopher Ng
a1f43964dc test(files): Adapt favorite views spec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-27 15:37:27 -07:00
Christopher Ng
9cc1a020a2 feat(files): Allow more than 50 favorite views
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-27 14:33:39 -07:00
Elizabeth Danzberger
79d005e11f
feat(templates): add support for checkboxes in template filler
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-27 14:41:58 -04:00
Ferdinand Thiessen
988ea85f48 fix(files): Correctly check for already used names when creating new folder
Also add Cypress tests for the "new"-menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 19:40:38 +02:00
Elizabeth Danzberger
99221f2a42 fix(files): fix list gap at bottom
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-27 08:53:57 +00:00
Ferdinand Thiessen
21b997f845
Merge pull request #47490 from nextcloud/chore/adjust-translations
chore(files): Adjust wording for file type filter
2024-08-26 21:40:27 +02:00
Ferdinand Thiessen
3ffdf56c8f
chore(files): Adjust wording for file type filter
* Resolves: https://github.com/nextcloud/server/issues/47440

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 20:42:41 +02:00
Ferdinand Thiessen
f7b7474cd3
fix(files): Reset drop notice on firefox
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 20:31:31 +02:00
Ferdinand Thiessen
4fcf4dba02
Merge pull request #47466 from nextcloud/chore/migrate-vitest
test: Migrate from Jest to vitest
2024-08-26 20:30:26 +02:00
Ferdinand Thiessen
a5e58dc45e
test: Migrated all Jest tests to vitest
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 17:27:22 +02:00
Ferdinand Thiessen
b1eecde452
fix(files): Remove huge margin on bottom
Instead make it relative to screen size.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 16:31:25 +02:00
Christopher Ng
fc1edaf4c1 refactor(files): Consolidate node registration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Christopher Ng
3b185b1156 refactor(files): Organize event subscriptions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Christopher Ng
4062883459 fix(files): Respect "Show hidden files" setting in tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-22 16:09:10 -07:00
Elizabeth Danzberger
e53684e1d9
fix: use empty template by default when pressing enter
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-21 15:00:26 -04:00
Ferdinand Thiessen
1331ce7e7c
fix(files): Move loading icon before grid toggle
This prevents jumping of that toggle button when the view is loading.
Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 12:47:21 +02:00