Commit graph

96 commits

Author SHA1 Message Date
grnd-alt
cdad92d2bb feat: improve occ file:transfer-ownership logging
Signed-off-by: grnd-alt <github@belakkaf.net>
2025-03-20 00:56:11 +01:00
Ferdinand Thiessen
3ac9a316bb
feat(files): allow to ignore warning to change file type
* Missing pieces of https://github.com/nextcloud/server/issues/46528
  * Add checkbox to not show this dialog again
  * Add user config as suggested by designers in files settings to
    reenable or diable this behavior.
  * Fix behavior of dialog: It says "keep .ext" but it does not keep the
    extension but cancels the operation. From the button label the user
    expects that the operation is continued but with the old extension.
  * Added more test coverage by adding component tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-04 21:12:42 +01:00
Daniel
f9354dab23
Merge pull request #49761 from nextcloud/transfer-share-skip-notfound
fix: skip transfering shares that we can't find
2025-01-16 17:58:06 +01:00
Robin Appelman
757076af29
fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-06 14:45:35 +01:00
Robin Appelman
c00724bac8 fix: skip transfering shares that we can't find
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:21:17 +01:00
grnd-alt
8d953aeb8d refactor(tags): move favorite event dispatching to tags.php
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +01:00
grnd-alt
2d02d83597 fix(dav): add activity logging for favorites in dav
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +01:00
provokateurin
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
Côme Chilliet
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +01:00
Kate
070adc1131
Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion 2024-10-22 12:47:45 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00
provokateurin
ba3d67d2a0
feat(files): Expose chunked upload config via capabilities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:03:33 +02:00
Christopher Ng
7ba52eae35 refactor: Inject IRootFolder
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 15:28:12 -07:00
Christopher Ng
53f0b3789e fix: Fix "Unknown path" error when source user files folder has not been initialized
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 15:26:33 -07:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +02:00
Côme Chilliet
7a48f8d929 fix: Transfer incomming shares first, do not delete non-migratable ones
Canceling the previous add of deletion of invalid shares in
 transferownership because in some cases it deletes valid reshares, if
 incoming shares are not transfered on purpose.
Inverting the order of transfer between incoming and outgoing so that
 reshare can be migrated when incoming shares are transfered.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Luka Trovic
42181c2f49 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +02:00
Côme Chilliet
bcf670e6b5
feat(transfer-ownership): Improve verbose output of command
Makes debbuging way easier

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-07 15:35:47 +02:00
Côme Chilliet
0555900134 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +02:00
Côme Chilliet
d92bf388b1 feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Christopher Ng
0def7fa71c feat(files): Allow toggling folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Ferdinand Thiessen
0936af9960
feat(files): Allow to configure Windows filename compatibility in the settings
This adds an admin setting to toggle Windows filename compatibility.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-17 16:17:14 +02:00
Ferdinand Thiessen
4bd9bc7b06
feat(files): Use receiving users language for the ownership transfer target folder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 20:19:58 +02:00
Andy Scherzinger
5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +02:00
Côme Chilliet
4c27e88b40
fix(files): Fix ownership transfer encrypted files detection
Discovered by psalm update

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +02:00
Ferdinand Thiessen
38f4451a23
fix(files): Also restore shares after ownership transfer for object storage
When a file is moved between different storages then the file id is not (always) preserved.
This means the file id has to be adjusted for all shares.

So in case the file id does not exist anymore we try to find the new file id based on the
target path of the transfer and the path suffix of the share.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-18 13:51:47 +02:00
Louis Chemineau
2de9880d79
fix(files): Do not require files_trashbin in live photo sync listener
Fix https://github.com/nextcloud/server/issues/43299

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-14 10:55:44 +01:00
John Molakvoæ
816ddaf8b3
Merge pull request #39215 from shdehnavi/replace_substr_calls_in_files_app 2024-02-23 19:45:56 +01:00
Ferdinand Thiessen
2cea4d7b8d
fix(files): Consistent sorting for folders before files (user configurable)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 14:23:47 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Hamid Dehnavi
344d99ae94
Merge branch 'master' into replace_substr_calls_in_files_app
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-10-30 11:43:32 +03:30
John Molakvoæ
116c396f0e
feat(files): add grid toggle button
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-17 11:19:02 +02:00
Hamid Dehnavi
df0a396b4c Refactor "substr" calls to improve code readability
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-27 20:36:23 +03:30
Joas Schilling
9bf812ac6c
feat!: Migrate TagService events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:18 +02:00
John Molakvoæ
a0597da460
feat(files): sort favorites first
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-05 16:20:33 +02:00
Joas Schilling
8b31d8204f
fix(files): Don't throw an error when guests access the controller
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-19 16:39:57 +02:00
John Molakvoæ
d7ab8da1ef
feat(files): add view config service to store user-config per view
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-18 09:02:01 +02:00
Julius Härtl
b62e29051e
fix: Always create user directory when transfering files to new users
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-06 20:51:56 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +01:00
Joas Schilling
c02080fccb
fix(files): Fix controller setup for guests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 15:34:11 +01:00
John Molakvoæ
7339355dde
Fix favourite opening
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:16 +01:00
John Molakvoæ
0a3ef8b74b
Fixing tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:16 +01:00
John Molakvoæ
5b9a8f0407
Add component testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:14 +01:00
John Molakvoæ
5c987a0ff4
Port settings to Modal
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:45:52 +01:00
Vincent Petry
62d47100ec
Merge pull request #30953 from nextcloud/feat/init-storage-when-transferring-ownership
Init user's file system if not existing on ownership transfer
2022-02-10 18:13:43 +01:00
Vincent Petry
7858fee5b5
Fix path handling when transferring incoming shares
When transferring incoming shares from a guest user without specifying a
path, the $path is empty.
The fix properly handles that situation to avoid looking for shares in a
path with doubled slashes which failed to find shares to transfer.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-02-10 09:50:21 +01:00
Carl Schwan
02da4ce1b0 Init user's file system if not existing on ownership transfer
This makes it a bit easier to transfer ownership when the new user
hasn't already logged in. This still doesn't support encrypted
storages because the keys are not generated yet.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-01 13:26:41 +01:00
Vincent Petry
fa23a9f720
Do not transfer shares for deleted users
Whenever a user was deleted but is still recipient of share entries,
delete these entries upon transfer.

Usually such entries would disappear after running cleanup background
jobs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-04 11:04:04 +02:00
Immanuel Pasanec
1f42657bb9
Added support for transfering incoming file shares.
- new option --transfer-incoming-shares=1 | 0
- new config.php option 'transfer-incoming-shares' => true | false

The command line option overrules the config.php option.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-27 17:55:58 +02:00