Commit graph

148 commits

Author SHA1 Message Date
Josh
a4acb88b12 fix(SetupChecks): Pass webfinger if a handler is there
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 14:38:48 +00:00
Git'Fellow
23e8b2d757 fix(setupchecks): Binary data can have problems with serialize
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-10 08:01:39 +00:00
Joas Schilling
e3c1eb6935
fix(setupcheck): Make the Memcache setupcheck use the cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-19 15:36:24 +01:00
Git'Fellow
60d1ab252c fix(SetupChecks): Make sure array key is set
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 12:10:20 +00:00
skjnldsv
e3f5b721c6 fix(settings): psalm PhpMaxFileSize setup check warning
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 19:08:19 +01:00
skjnldsv
2cb56e2f1a feat(settings): add big file upload setup checks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 16:23:47 +00:00
Ferdinand Thiessen
d126fc3ad0
refactor(settings): CheckServerResponseTrait always expect absolute path
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-11 13:27:41 +02:00
Ferdinand Thiessen
39d66ed5f6
fix(setup-checks): Ensure URL with webroot works
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-11 13:09:20 +02:00
Joas Schilling
f7748b7e64
fix(a11y): Add OTF font loading check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 10:05:51 +02:00
Côme Chilliet
48c807e667 fix(setupchecks): Test overwrite.cli url first, then generated one, and
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 15:53:45 +00:00
Daniel Kesselberg
e004fb7042 fix: add option to remove the webroot for setup checks and don't check trusted_domains.
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 15:53:45 +00:00
Git'Fellow
9d062fb7cc fix: typo
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Git'Fellow
6c39e9d074 fix: check both CLI and value
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Git'Fellow
dde693cdf6 fix(setupchecks): Skip checking for OPcache if running from CLI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Anna Larch
620d58fdf1 fix(caldav): lower scheduling table size warning
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-25 20:16:26 +02:00
Ferdinand Thiessen
2071f4d713
Merge pull request #46298 from nextcloud/backport/46174/stable29
[stable29] fix(IntegrityCheck): Ensure the check is run if no results are available
2024-07-10 19:01:43 +02:00
MichaIng
79bcb9d3de fix(settings): make trailing slash for caldav/carddav redirects optional
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.

Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.

This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).

While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.

This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.

Signed-off-by: MichaIng <micha@dietpi.com>
2024-07-10 00:24:39 +02:00
Ferdinand Thiessen
57c889f773
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-05 12:32:39 +02:00
Daniel Kesselberg
c0d4d376cb fix(setupchecks): skip check when disk_free_space is disabled
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-29 14:00:33 +00:00
Robin Appelman
d3d2488fbb feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 11:22:49 +02:00
John Molakvoæ
39adc5f019
Merge pull request #44675 from nextcloud/backport/44306/stable29 2024-06-07 12:17:37 +02:00
Anna Larch
ec94f5499c fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 11:10:03 +00:00
Josh
cb63ff82c1
Merge pull request #45284 from nextcloud/backport/45262/stable29
[stable29] fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-14 07:47:25 -04:00
Josh Richards
a4ef527e75 fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-13 10:07:35 +00:00
Josh Richards
00b22f6c11 fix(setupCheck): Only warn when memcache present w/o memcached
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-13 09:55:37 +00:00
Côme Chilliet
5f8157f693
fix(setupchecks): Fix opcache buffer check
This was broken by last codestyle update, maybe even before because of
 operator precedence. Now using vars to make it readable and correct at
 the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 10:51:51 +02:00
Johannes Merkel
8b614a9dc1 fix(settings): show warning for indexToReplace as part of missing indices
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-04-05 11:17:30 +00:00
Joas Schilling
69a3038086
Merge pull request #44622 from nextcloud/backport/44534/stable29
[stable29] build(deps): bump nextcloud/coding-standard from 1.1.1 to 1.2.1 in /vendor-bin/cs-fixer
2024-04-04 13:07:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Josh
c0debe27d6 fix(SetupChecks): Add hint about dns/firewall if mjs check can't run
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 16:53:30 +00:00
Ferdinand Thiessen
14addf3fdb
fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +01:00
Côme Chilliet
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +01:00
Côme Chilliet
9f819f311f feat: Migrate HSTS check to Security headers SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
d7193ef65e fix: Migrate security headers check tests and fix the SetupCheck implementation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
310377e496 fix: Fix Security headers setup check behavior
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
1fffdf4763 fix: Fix ocm-provider setup check failure detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
a47a1e6249 feat: Migrate header check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Maxence Lange
519e434573 fix(updatenotification): spread the use of new appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 -01:00
Ferdinand Thiessen
58f57fd13f
fix(settings): Adjust order of parameters for runRequest
Fixing invalid request to host `HEAD`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 11:21:51 +01:00
Côme Chilliet
1ea88a73f6 feat(settings): Migrate .well-known URL setup check to new API
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +01:00
John Molakvoæ
a6a962d5a2
fix(settings): adjust source maps setup check wording and log level
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-06 15:11:32 +01:00
John Molakvoæ (skjnldsv)
f0494e2b5a
feat(settings): add JavaScript Source Maps support .js.map setup check
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-06 11:16:10 +01:00
Côme Chilliet
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +01:00
Ferdinand Thiessen
ef2c312b18
feat(settings): Migrate data directory protection check to SetupCheck
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +01:00
Côme Chilliet
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +01:00
Ferdinand Thiessen
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +01:00
Ferdinand Thiessen
398b042af7
enh(settings): Migrate WOFF2 loading check to a SetupCheck
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:20 +01:00
Ferdinand Thiessen
096d66edc8
enh(settings): Add trait for setup checks that need to access the webserver using HTTP requests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:16 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
rakekniven
8663da1e50
fix(i18n): Adapted spelling of Unicode
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-30 16:54:21 +01:00