Commit graph

6686 commits

Author SHA1 Message Date
provokateurin
73705d080c
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:54:34 +01:00
Ferdinand Thiessen
5535a7932c
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 22:18:03 +01:00
Robin Appelman
10b6d92319 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 07:49:18 +00:00
Christoph Wurst
c82505366d fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:32:29 +00:00
Côme Chilliet
6283731413 fix: Remove call to non-existing method in 28 and add missing use in test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-27 11:17:38 +00:00
Côme Chilliet
0d8c3d1f3f fix(tests): Fix PHP 8.0 compatibility
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-27 11:17:38 +00:00
Côme Chilliet
4f929b2635 fix(tests): Adapt tests to change of DefaultShareProvider constructor
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-27 11:17:38 +00:00
Arthur Schiwon
72feb5abcc
Merge pull request #45812 from nextcloud/backport/43942/stable26
[stable26] fix(Session): avoid password confirmation on SSO
2024-06-18 19:10:29 +02:00
Daniel Kesselberg
38a4771f31 test: add tests for ProfilePageController
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-14 19:09:08 +02:00
Arthur Schiwon
527bc5d984
test(unit): adjust testSSO scenario and test class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-13 20:05:34 +02:00
Arthur Schiwon
0f5c8f9111
fix(Token): make new scope future compatible
- "password-unconfirmable" is the effective name for 30, but a draft
  name was backported.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-12 19:35:37 +02:00
Arthur Schiwon
eea5e1cca2
fix(Session): avoid password confirmation on SSO
SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-12 19:35:37 +02:00
Joas Schilling
350300e584 fix: Extend SVG reference check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-05-22 15:26:16 +00:00
Christopher Ng
e9ff1216ad test: Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-08 17:10:55 -07:00
Christoph Wurst
fb37922169 fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-19 17:34:43 +00:00
Benjamin Gaussorgues
5d1ca3193b feat(share): save date and time for expiration
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-26 09:09:01 +00:00
Git'Fellow
d29b239d72 fix(session): Avoid two useless authtoken DB queries for every anonymous request
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:39:53 +00:00
Joas Schilling
5d8dfe81fd
fix(appstore): Only send subscription keys to valid appstores
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-16 11:58:05 +01:00
Julius Härtl
67bf2ca956
perf: Use more performant way to obtain and check the email as a login name with token login
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-09 11:58:21 +01:00
John Molakvoæ
468538a4d4
Merge pull request #42548 from nextcloud/lock-restore-ttl-26 2024-01-02 16:57:54 +01:00
Robin Appelman
a59df23fd5
adjust redis compareSetTTL to use a lua script
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-02 15:41:06 +01:00
Robin Appelman
33918821f1
restore shared lock ttl when releasing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-02 15:41:04 +01:00
Joas Schilling
75d4798865
fix(security): Handle idn_to_utf8 returning false
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-07 06:38:25 +01:00
Arthur Schiwon
636c94016a
Merge pull request #41627 from nextcloud/backport/41616/stable26
[stable26] fix: Fix linkToOCSRouteAbsolute() without index.php and with subfolder
2023-12-04 21:35:32 +01:00
Arthur Schiwon
04396e9a26
ci(acceptance): fix dev branch
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-23 14:06:14 +01:00
Joas Schilling
187c956c12 fix: Fix linkToOCSRouteAbsolute() without index.php and subfolder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-20 16:25:51 +00:00
Joas Schilling
71d0b4ab42
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:50:12 +01:00
Côme Chilliet
90a14dbdb3 Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-18 10:38:22 +00:00
Arthur Schiwon
d5f6249b76
Merge pull request #40167 from nextcloud/backport/40108/stable26
[stable26] feat: add switch to disable dns pinning
2023-09-06 10:34:48 +02:00
Robin Appelman
065f636cb7
cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-04 14:21:19 +02:00
Daniel Kesselberg
652a8a8f7a
feat: add switch to disable dns pinning
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-30 22:21:55 +02:00
Ferdinand Thiessen
b6b0c7e47a tests: Add test for CacheEntry getters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-17 10:03:53 +00:00
Benjamin Gaussorgues
25ba08b1d3
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-21 12:06:49 +02:00
John Molakvoæ
346bdd4cd6 fix: also run phpunit on apps/theming/css modified files
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-13 16:16:24 +00:00
Arthur Schiwon
1c59a7a5db
Merge pull request #39031 from nextcloud/backport/38917/stable26
[stable26] fix(l10n): Fix plural issue with different locale and language
2023-07-10 18:05:48 +02:00
Joas Schilling
ddff2e692d
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 06:32:01 +02:00
Arthur Schiwon
3fd03faf58
Merge pull request #38977 from nextcloud/backport/38625/stable26
[stable26] fix: expect interface, not a specific implementation
2023-07-04 22:08:09 +02:00
Joas Schilling
756e119162
fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 14:15:46 +02:00
Simon L
4e004789d6 try to fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-26 11:08:06 +02:00
Arthur Schiwon
3813b955ee chore: ugly type juggling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-23 23:04:40 +00:00
Arthur Schiwon
00afe495bc
Merge pull request #37230 from nextcloud/backport/36033/stable26
[stable26] invalidate existing tokens when deleting an oauth client
2023-06-15 11:54:38 +02:00
Varun Patil
119e52f8b6
redis: move lua scripts to class and add type hints
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-31 12:00:34 +02:00
Robin Appelman
76013b9287 add test to verify redis lua script hashes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-31 07:13:23 +00:00
Artur Neumann
774cdf5e90
unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-05-19 12:02:06 +05:45
jld3103
9ae9f03d83 Clear generated avatar caches
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-16 09:52:00 +00:00
Joas Schilling
7cc7984ab7
Merge pull request #38275 from nextcloud/backport/38274/stable26
[stable26] fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:31:10 +02:00
Joas Schilling
94211721a6
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:24:12 +02:00
Joas Schilling
156cc8d16b
fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:14:15 +02:00
Joas Schilling
9260ef5c29
Merge pull request #37549 from nextcloud/backport/37520/stable26
[stable26] fix DBAL exception handling in setValues
2023-05-09 14:29:03 +02:00
Julius Härtl
6520fa1ac9 tests: Adapt node related unit tests mocks to required root view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-08 15:21:52 +00:00