invario
ba51caf5f4
Fix(previews): prevent infinite loop in case of bad video file
...
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-09-05 09:32:37 -04:00
invario
97a0dde160
feat(previews): previews and tests for large remote videos w/o full download
...
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-09-05 10:08:19 +02:00
provokateurin
4b2a93cf0a
chore(Preview): Remove avconv support
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-27 20:51:08 +02:00
Arthur Schiwon
bdc68989d5
fix: unbloc ffmpeg on some broken videos
...
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-05-20 22:12:13 +02:00
Misha M.-Kupriyanov
4a924bf400
fix(previews): avoid large file downloads for remote movie storage
...
Prevent downloading entire movie files from remote storage (e.g., S3)
when the 'moov atom' is located at the end of the file.
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-04-23 10:04:27 +02:00
Côme Chilliet
3ca690a9f3
fix(previews): Cleanup Movie provider code and remove deprecated static vars
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-08 09:53:02 +02:00
Côme Chilliet
85934d4d79
fix(preview): Fix constructor parameter name and default value
...
This should fix tests for movie preview provider
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-08 09:24:04 +02:00
invario
eb3ca406f8
feat(previews): fix casing and comments
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-04-06 20:28:12 -04:00
invario
91e2f05ee6
feat(previews): Clean up code for HDR video previews
...
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-04-03 11:08:04 -04:00
invario
e3008d08be
feat(previews): Use proper colorspace and apply tonemap for HDR videos
...
Signed-off-by: KT <invario@gmail.com>
2025-04-03 00:36:33 -04:00
Josh
37a9460b06
chore(Previews): make thumbnail generation more robust
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-02 18:32:44 +01:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Andy Scherzinger
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +02:00
Git'Fellow
6f4d0fe79c
Lower failed movie preview to info
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-03 18:52:05 +01:00
Glandos
3bea7af7b7
fix indent 2
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-16 10:10:12 +01:00
Glandos
59e7ed1fad
fix indent
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-15 23:40:16 +01:00
Glandos
528e66859b
Use proc_open to avoid spawning a shell
...
The use of `exec` will spawn a shell, using `/bin/sh` on POSIX platforms. But in restricted environment, such as AppArmor, this means giving execution to `/bin/sh`, which renders the execution restriction quite useless.
Using an array with `proc_open` reduces this, and paved the way for file streaming instead of temporary file.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-15 23:37:13 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Christopher Ng
57c66bf7cb
Use Image class from public API
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-02 00:37:36 +00:00
Côme Chilliet
d43dbfa0f2
Fix typing in OC\Preview\Movie
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 14:55:48 +01:00
Côme Chilliet
ebe731f014
Fix typing in OC\Preview
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 14:42:55 +01:00
UmbrellaCodr
a0d7e27789
reduce 'Movie preview generation failed Output' log errors
...
for movies under 5 seconds
Signed-off-by: UmbrellaCodr <umbrella@biohazard.cc>
Update lib/private/Preview/Movie.php
Co-authored-by: Simon L. <szaimen@e.mail.de>
2022-02-03 17:52:37 -08:00
J0WI
047cab8dd2
Use findBinaryPath for previews
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-10-23 23:15:42 +02:00
Vincent Petry
24e0255378
Fall back to full file for video previews
...
If the first 5 MB are not enough to grab a useful frame for the
thumbnail preview, fall back to reading the full file.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-09-18 10:53:00 +02:00
John Molakvoæ (skjnldsv)
40c10ab145
Properly log errors in Movie previews generation
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-19 09:47:12 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Christoph Wurst
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +01:00
Alexander A. Klimov
7cc2143bb3
Movie#getThumbnail(): compare Movie#generateThumbNail() to null, not false
...
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
2019-12-21 08:55:51 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
Daniel Schneider
3c323d2cbb
#17661
2019-10-30 20:00:21 +01:00
Robin Appelman
6150614374
Add new Provider interface for preview providers
...
the main difference is passing the `File` object to the provider
instead of a `View` + path
Old providers will still continue to work as before
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-17 14:09:09 +02:00
Morris Jobke
31c5c2a592
Change @georgehrke's email
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 20:38:59 +01:00
Joas Schilling
ba87db3fcc
Fix others
2016-07-21 18:13:57 +02:00
Roeland Jago Douma
702046d4aa
Move \OC\Preview to PSR-4
2016-04-20 15:02:44 +02:00