Commit graph

225 commits

Author SHA1 Message Date
jld3103
02f9c3a06f
Use implementations instead of interfaces for accessing private methods
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-03-30 12:33:46 +02:00
Joas Schilling
1a31ddb56d
Do not reuse query builder objects in DAV account deletion
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-01 21:49:34 +01:00
Christopher Ng
e6f4705920 Revert "Fix sync errors for duplicate cards with the same UID for different backends"
This reverts commit ddcee3dbab.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 02:11:09 +00:00
Anna Larch
ddcee3dbab Fix sync errors for duplicate cards with the same UID for different backends
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-01-05 12:19:51 +00:00
Côme Chilliet
cbbb0712db
Merge pull request #34807 from nextcloud/fix/compute-notification-parsed-subject
Compute notification parsed subject from rich subject when possible
2022-12-19 10:46:39 +01:00
Côme Chilliet
d9151ff35c Get rid of all useless calls to setParsedSubject now that setRichSubject is able to do it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-29 14:36:29 +00:00
Carl Schwan
6828a3b28d Cleanup contactsinteraction
- Add more typing and use PHP 7.4 typed properties

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-25 11:46:18 +01:00
Anna Larch
9dd51601c6 Switch to DisplayNameCache for CardDAV
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-03 10:26:34 +01:00
Thomas Citharel
6f15873321 Add a background job to prune outdated sync tokens
We remove all outdated sync tokens, based on their auto-incremented ID.

By default we only keep the last 10 000, but this can be configurable.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-10-27 20:12:13 +00:00
Christoph Wurst
19b7dad3dc Wrap address book creation write-read in a transaction
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-03 17:48:52 +02:00
blizzz
e714524267
Merge pull request #33104 from nextcloud/enhancement/add-logging-federation
Federation - add logging, update the server status if sync fails
2022-10-01 21:53:55 +02:00
blizzz
132f842f80
Merge pull request #33450 from sazanof/bug/base64-card-dav-search
Fix photo url generation (add URI type to VCard2Array)
2022-10-01 21:50:14 +02:00
Joas Schilling
d41841b4a7
Check address book URI length before creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-26 13:58:18 +02:00
Joas Schilling
71065f5fd5
Merge pull request #33615 from nextcloud/perf/noid/user-displayname-cache-for-activity-providers
Use user name cache in activity providers
2022-08-19 12:28:44 +02:00
Joas Schilling
eab5189abb
Fix carddav activities
The settings where combined last minute but at the same time the activities
where not adjusted to map an existing setting so the filter was not possible
to even limit it to the types that the activities had.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:50:45 +02:00
Joas Schilling
7e11778190
Use user name cache in activity providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +02:00
Anna Larch
61b55c88da performance optimisation for carddav backend blob data read
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-08-15 20:47:58 +02:00
Mikhail Sazanov
458f1b0c03 Add URI type to VCard
Signed-off-by: Mikhail Sazanov <m@sazanof.ru>
2022-08-03 13:07:26 +03:00
Anna Larch
2988efeb7f Add logging to federation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-07-27 15:00:38 +00:00
luz paz
d4637ef4d8 Fix typos in apps/dav subdirectory
Found via `codespell -q 3 -S l10n -L jus ./apps/dav`

Signed-off-by: luz paz <luzpaz@github.com>
2022-07-26 17:40:10 -04:00
blizzz
4ced3a4518
Merge pull request #32869 from nextcloud/dav-no-deleted-user-activities
Avoid calendar & addressbook activities being created on user being deleted
2022-07-23 00:01:30 +02:00
Carl Schwan
6114176b71 Cleanup CardDav SyncService
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-24 20:25:38 +02:00
Carl Schwan
a9cfa72d1c Summer cleanup of the federation app
- Use IEventDispatcher instead of deprecated symfony dispatcher
- Use LoggerInterface where possible
- Use php 7.4 properties
- Add type hinting where possible
- Move federation hooks to a seperate listener

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-24 15:39:52 +02:00
Carl Schwan
3598ec4028 Add typing to Sharing Backend
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 10:25:17 +02:00
Thomas Citharel
4129089f87
Avoid calendar & addressbook activities being created on user being deleted
Addressbooks and Calendar data are destroyed through hook OC_User::pre_deleteUser, which when it reaches the backends sends AddressBookDeletedEvent/CalendarDeletedEvent typed events, which in turns generates activities that aren't deleted until they expire.

This can probably lead to old activities being visible for a new user created with the same uid.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-14 11:54:42 +02:00
Vincent Petry
8e61671b82
Merge pull request #32364 from nextcloud/dav-listeners
🧹 Remove all legacy event dispatchers from CalDAV & CardDAV backends
2022-06-10 15:57:35 +02:00
Thomas Citharel
c6c3fd9aa9
Avoid creating carddav activities for the system user
Because of the system addressbook synchronisation.

Closes #32803

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 09:07:53 +02:00
Christopher Ng
57c66bf7cb Use Image class from public API
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-02 00:37:36 +00:00
Thomas Citharel
28b0da59ce
Fix a doctype in OCP for IAddressBook
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-17 15:09:49 +02:00
Thomas Citharel
060c8d7c4b
Add some typed properties
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-17 15:09:49 +02:00
Thomas Citharel
4bb31c021e
Remove all legacy event dispatchers from CalDAV & CardDAV backends
Move them to proper EventListeners and test them

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-17 15:09:46 +02:00
Carl Schwan
07c9bf1adf
Merge pull request #31943 from nextcloud/dav-cleanup
Cleanup dav
2022-05-17 14:59:59 +02:00
Carl Schwan
f7be76125f Fix more psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 11:05:54 +02:00
Carl Schwan
e71db40492 Wrap multiple inserts inside a transation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 21:02:53 +02:00
Carl Schwan
eef973e85b Minor optimizations for saving user personal information
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition

* Make createCard not check if an card exists if we already checked
  previously. We also don't try to get the card if the user is disabled
  as we don't use the card in this case

We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
2022-05-12 21:02:52 +02:00
Carl Schwan
829490ab7a Cleanup dav
- Remove unused class AppEnabledPlugin
- Add more type hinting when possible

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-05 22:03:59 +02:00
Côme Chilliet
e2531f8503
Migrate dav application from ILogger to LoggerInterface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-02 10:52:43 +02:00
Carl Schwan
2cdaa28acc Don't recreate sql query each time
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-10 15:10:08 +01:00
Carl Schwan
cb7485e764 Fix more than 1000 entries in queries exception in CardDavBackend
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-21 14:30:00 +01:00
Joas Schilling
d5cb5a33dc
Convert strict_search to wildcard property and add psalm docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 19:24:16 +01:00
Joas Schilling
84d37143b0
Only wildcard search if enumeration is allowed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:54:42 +01:00
Valdnet
52e0c65036 l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-06-21 22:45:54 +00:00
Valdnet
64ad2eb83d l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-06-21 22:44:56 +00:00
Valdnet
898e87ac64 l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-06-21 22:44:56 +00:00
Joas Schilling
b1031f3985
Allow apps to get photos of VObjects
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-09 11:57:49 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Joas Schilling
2a2ca4dba5
Remove since from implementations and fix some more style
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-25 09:28:18 +02:00
Joas Schilling
9626138873
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 15:34:37 +02:00
Joas Schilling
6fff0b81fe
Add activities for creating, updating and deleting contacts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 15:08:35 +02:00
Joas Schilling
2496f83463
Add activities for addressbook management
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 15:08:35 +02:00