Arthur Schiwon
3304b0371b
fix(autoloader): no apcu no side effects
...
apcu lead to side effects especially with app management and (soft)
inter-dependencies, and lead also to 500 server errors. While we could
add management to clear apcu cache in many cases (may stil leave edge
cases) the performance benefit is marginally as also class maps are
already cached in opcache. Hence, the simple and effective way to go is
to not use apcu for autoloading.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-09-08 18:30:40 +00:00
Robin Appelman
a23447c050
better caching in storage stats calculations
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-07 16:25:10 +02:00
Benjamin Gaussorgues
8c7017679d
Detect aborted connection in OC\Files\View and stop writing data to the output buffer
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-09-06 09:22:06 +02:00
Ferdinand Thiessen
ad2727aef8
fix: Correctly add module content type to script tags when scripts with versions are used
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-23 00:38:53 +02:00
Git'Fellow
ecbeacbdf5
Silent imagecreatefromstring() errors
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-07-01 14:38:30 +00:00
jld3103
04d840211f
Remove version check for ancient libxml version
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-05 19:07:55 +02:00
Carl Schwan
b1ec7ff51f
Add missing taint analysis docblock comments, and improve escaping in some methods
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-24 17:17:53 +02:00
Arthur Schiwon
bb4b34ff69
Read mtime of version.php only once
...
- in most cases it would read again in \OC_Util::loadVersion anyway
- remove some unused use statements
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-04-21 14:10:47 +00:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +02:00
Côme Chilliet
e94a689bca
Fix version number in phpdoc for app loading refactor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-27 14:27:23 +02:00
Simon L
67614150b5
Merge pull request #36636 from nextcloud/fix/oc-image-getimagesize
...
fix OC_Image: Prevent E_WARNING from getimagesize*
2023-03-23 14:59:57 +01:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts
2023-03-22 09:17:28 +01:00
Côme Chilliet
13c71ed24a
Small cleanups for AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +01:00
Côme Chilliet
78c1716818
Move loadApps to the AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +01:00
Côme Chilliet
8dc5f82189
Move isType to AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +01:00
Côme Chilliet
a7c8090dc3
Move loadApp function to the AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:01:17 +01:00
Christoph Wurst
416c824c74
perf(autoloader): Drop legacy class autoloader
...
The documentation says apps should use PSR-4 to get their classes
loaded. The legacy PSR-0 is still in place and has a negative impact on
performance.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-03-16 12:02:09 +00:00
Marcel Klehr
4a2accaa27
fix OC_Image: Prevent E_WARNING from getimagesize*
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-03-16 11:10:36 +00:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events
...
OCP\App\ManagerEvent is depreciated since 22 without a replacement
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +01:00
Maxence Lange
e1b91fecf1
Merge pull request #36883 from nextcloud/fix/noid/gs-saml-pre-login-event
...
dispatch BeforeUserLoggedInEvent
2023-03-07 08:01:18 -01:00
Julius Härtl
d515da502f
fix: Use proper path for quota fetching
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-06 22:46:07 +00:00
Julius Härtl
3287eddbbc
fix: Recalculate storage statistics on updating the quota
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-06 22:46:07 +00:00
Maxence Lange
980e8e24f0
dispatch BeforeUserLoggedInEvent
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-03-01 15:31:31 -01:00
Ferdinand Thiessen
b642137c65
feat(OC/Template): Add type="module" for ES6 scripts
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +01:00
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +01:00
Robin Appelman
fe78ef7a38
instrumentation for app booting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-09 17:41:43 +01:00
Côme Chilliet
2a4ab201b7
Make sure application are only loaded once
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 16:06:32 +01:00
Côme Chilliet
b7d9e43e25
Put back string in $includeMounts as it actually does something
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:32 +01:00
Côme Chilliet
cd885b5705
Type sizes as int|float throughout the code base
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +01:00
Côme Chilliet
d00422b812
Fix computerFileSize when called with a string without unit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +01:00
Côme Chilliet
7a628c0361
Fix 32bits bigint support in Util/OC_Helper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +01:00
Côme Chilliet
255f230a87
Fix bigsize support on 32bits in OC_Helper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +01:00
Côme Chilliet
e156f8339c
Revert "remove 32-bit workarounds"
...
This reverts commit dd8774389e .
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +01:00
Maxence Lange
4cac49c797
refresh cached app folder on install/upgrade
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-02-01 11:07:31 -01:00
Côme Chilliet
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Côme Chilliet
0c466b7ff5
Attempt at reducing psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:09 +01:00
John Molakvoæ
b9906fb21e
feat(files): Quota in navigation
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-17 18:30:41 +01:00
Côme Chilliet
e4a780127d
Small fix in OC_API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:05:18 +01:00
Simon L
bfb3b2af9f
increase preview_max_memory and make it easier to debug
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +01:00
Julius Härtl
1746344481
Use display name cache on getStorageInfo
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Adapt test to also run isolated
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-16 17:15:21 +00:00
J0WI
110ea0df46
Allow empty mimeType
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:33 +01:00
J0WI
1dd3afefcd
Add type hints
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:32 +01:00
J0WI
53994f600d
Fix redundant condition
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:47:43 +01:00
J0WI
40166ddc0a
Remove obsolete GD function overwrites
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:47:43 +01:00
Vincent Petry
0b09531dc6
Don't use quota cache through user management
...
When querying the free space through user management APIs, don't use the
cached quota value. The latter is only there to accelerate PROPFINDs.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-21 16:24:22 +01:00
John Molakvoæ
d27a39271e
getAppValue expects string
...
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +01:00
Git'Fellow
c7e2787300
Default Jpeg quality to 80
...
See https://sirv.com/help/articles/jpeg-quality-comparison/
Almost 50% of file size (compared to 90) and no visual differences.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2022-11-16 10:59:50 +01:00
Vincent Petry
966ee67efb
Merge pull request #34834 from nextcloud/bugfix/noid/skeleton-size-calc
...
Fix size calculation on copying the skeleton files
2022-11-04 17:23:40 +01:00