upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-24 07:39:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 42
78826 commits 864 branches 1197 tags 8.3 GiB
Commit graph

1284 commits

Author SHA1 Message Date
Robin Appelman
ae4b127daa fix: use nc's binary finding logic for smb 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-13 14:08:00 +02:00
Robin Appelman
85f2161031 feat: add command to check files_external dependencies 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-13 11:25:29 +02:00
provokateurin
1d16dcc0e4
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-06 09:46:50 +02:00
provokateurin
5ce0bdc26b
fix(files_external): Convert VALUE_HIDDEN to FLAG_HIDDEN to allow combining VALUE_PASSWORD and FLAG_HIDDEN 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-06 09:46:47 +02:00
Ferdinand Thiessen
832f79ac93
chore: apply code style 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-04-30 19:04:59 +02:00
Stephan Orbaugh
ff70d226c9
Merge pull request #51387 from nextcloud/backport/51364/stable30 
[stable30] fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage
 2025-03-24 14:26:11 +01:00
skjnldsv
4db27972ab fix(external_storage): fix settings save 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-03-12 00:28:29 +01:00
provokateurin
f4f236bdf7 fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-11 10:46:24 +00:00
provokateurin
e7f7bb3915 fix(files_external): Move definition parameter to the correct place 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-02-27 14:25:10 +00:00
Robin Appelman
b1ee1b80d4 fix: detect deleted items as updated for smb storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-30 14:27:31 +00:00
Benjamin Gaussorgues
8f779a5aab fix(files_external): wrong type for external mount id 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-12-13 10:32:13 +00:00
John Molakvoæ
38e2936935
Merge pull request #49651 from nextcloud/backport/49288/stable30 
[stable30] fix: smb: don't fail hard if we can't load acls for a file
 2024-12-12 13:21:43 +01:00
Robin Appelman
f92de57ba0 fix: smb: don't fail hard if we can't load acls for a file 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-04 17:23:34 +00:00
Oleksander Piskun
603174b614 fix(external_storage): Cast id to int 2024-12-03 13:01:40 +00:00
Louis Chemineau
97732de328
feat: Use inline password confirmation in external storage settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-28 13:03:51 +01:00
Marcel Klehr
0b4d0187c5 fix(external_storage): Cast id to int 
follow up to #49218

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-11-25 10:33:19 +00:00
provokateurin
a7f5b452d1
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 08:38:58 +01:00
Josh Richards
1fc1543a8b
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-11-13 09:11:17 +05:30
skjnldsv
51df897f73 fix(files_external): cast storage id int 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-12 09:55:21 +00:00
Maxence Lange
7e0ef243e8 fix(files-external): set password as sensitive 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-10-31 11:17:30 +00:00
yemkareems
a967355756 fix: add PasswordConfirmationRequired to saveGlobalCredentials 
Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-30 11:36:39 +00:00
yemkareems
b9b23a76c9 fix: cs fix namespace 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-29 11:08:33 +00:00
yemkareems
8739a0add6 fix: add PasswordConfirmationRequired to the eternal storages mentioned in review 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-29 11:08:33 +00:00
Ferdinand Thiessen
c3d52f6681
Merge pull request #48748 from nextcloud/backport/48373/stable30 
[stable30] fix: add PasswordConfirmationRequired to create user storages endpoint
 2024-10-23 17:12:55 +02:00
Joas Schilling
cb65e75e18
Merge pull request #48550 from nextcloud/backport/48540/stable30 
[stable30] fix(filesexternal): Remove unneeded 3rdparty library use
 2024-10-21 18:50:10 +02:00
Joas Schilling
564040c3ae
fix: Ensure we only pass string to writeln() 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-21 11:28:54 +02:00
Joas Schilling
91b9562bdd
ci: Fix psalm by typing the QuestionHelper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-21 11:28:53 +02:00
yemkareems
c9075d3379 fix: add PasswordConfirmationRequired to update and delete method 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-18 11:28:37 +02:00
yemkareems
501bea8226 fix: add PasswordConfirmationRequired to create user storages endpoint 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-18 11:28:37 +02:00
Joas Schilling
fb95695f28 fix(filesexternal): Remove unneeded 3rdparty library use 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-03 10:29:10 +00:00
Louis Chemineau
9668f48bd7 fix: Use hashed password in files_external settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-26 13:04:58 +00:00
Marcel Klehr
3b29a3959e fix(files_external): Catch correct exception 
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-26 07:37:40 +00:00
Ferdinand Thiessen
7537b5bcc4
Merge pull request #47923 from nextcloud/backport/47527/stable30 
[stable30] fix(files_external): Handling in SFTP UI for custom ports
 2024-09-14 22:52:01 +02:00
Git'Fellow
8a7cd1aefb fix(files_external): Check key exists before accessing it 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-14 16:57:21 +00:00
John Molakvoæ (skjnldsv)
89bf128708 fix(files_external): broken credentials dialog 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2024-09-13 15:21:45 +00:00
Josh Richards
600fc1d4df fix: custom port handling in UI for SFTP 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-09-12 13:37:07 +00:00
Daniel Calviño Sánchez
61b64b109c fix: Fix unmodified placeholder replacing the actual value when updating 
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-09-04 10:11:59 +00:00
provokateurin
c102b89cd5
refactor(files_external): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-14 09:44:57 +02:00
Robin Appelman
c2b1f079b1
feat: add a specialized writeStream implementation for s3 external storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-24 17:37:20 +02:00
Benjamin Gaussorgues
369c552e41
Merge pull request #46073 from nextcloud/fix/save_global_credentials 2024-06-25 09:48:24 +02:00
Benjamin Gaussorgues
e93866f904
fix: allows admin to edit global credentials 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-06-24 15:20:44 +02:00
Daniel Calviño Sánchez
733e3f62fd fix: Do not log an error when connecting to SFTP without a logged in user 
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.

Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.

Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-06-18 07:06:30 +02:00
Andy Scherzinger
c1555fc33e
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 18:05:37 +02:00
Côme Chilliet
4d060818d1
fix(files_external): Be extra safe with null handling to please psalm 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:24:00 +02:00
Côme Chilliet
3ad4bbb096
Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-type 
fix: Remove obsolete resource typing
 2024-04-16 17:13:07 +02:00
Julius Härtl
4910e7e231
fix: Pass the mountpoint target user to storages without owner 
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-09 09:04:24 +01:00
Côme Chilliet
72a0da6d4e fix: Fix small psalm errors in FTP and LDAP connections 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
0f348516d2 fix: Remove obsolete resource typing 
In PHP>=8.1, LDAP and FTP resources are always typed objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
81319e78bf chore: Improve phpdoc typing to silence psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00