Commit graph

1682 commits

Author SHA1 Message Date
Robin Appelman
195358eb8e fix: fix unjailedroot of nested jails if there are other wrappers in between
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-14 20:08:02 +02:00
Ferdinand Thiessen
832f79ac93
chore: apply code style
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 19:04:59 +02:00
John Molakvoæ
2fdb5096dd fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-04-15 11:54:03 +02:00
skjnldsv
94d1435a6a fix(files_sharing): rate limit share creation 10 times per 10 minutes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-15 08:58:02 +00:00
skjnldsv
71dfb43f8f fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-04-09 15:22:18 +00:00
Luka Trovic
713ead5d7d
Merge pull request #51614 from nextcloud/backport/50542/stable30
[stable30] fix(files_sharing): skip expiration notify for invalid share record
2025-03-27 17:23:57 +01:00
Luka Trovic
986a570dd7 fix(files_sharing): skip expiration notify for invalid share record
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-03-27 12:56:00 +01:00
Marcel Klehr
1f0241fdfe perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-27 12:01:14 +01:00
Ferdinand Thiessen
c0003fbd9c
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:52:07 +01:00
Ferdinand Thiessen
7d3047f5cb
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:46:55 +01:00
Ferdinand Thiessen
7f8f8aa9d2 fix(files_sharing): Also list deleted team shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 15:00:43 +00:00
Git'Fellow
59a0bc9982 fix(SharedStorage): Check if storage ID is set on cache
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-14 17:54:02 +01:00
Robin Appelman
3bfcd8371b
fix: don't use cached root info from shared cache if the watcher has detected an update
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 16:21:37 +01:00
nfebe
08426e0a8f refactor: Remove some deprecated containers and exceptions
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 22:14:12 +01:00
John Molakvoæ
5839a58737
Merge pull request #50217 from nextcloud/backport/49898/stable30 2025-02-06 10:34:54 +01:00
Ferdinand Thiessen
f9bd0ed462
fix(sharing): Ensure download restrictions are not dropped
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 16:22:11 +01:00
Ferdinand Thiessen
ee5f5bc159
fix(files_sharing): Respect permissions passed when creating link shares
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:21:26 +01:00
Ferdinand Thiessen
9658c051de fix: Ensure label is always a string
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 19:59:25 +00:00
Anna Larch
6af3bec748 fix(sharing): send share emails for internal users too
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-01-16 17:51:52 +00:00
Luka Trovic
021b335065
Merge pull request #49612 from nextcloud/backport/43025/stable30
[stable30] fix: Add command to update re-share if shared-by user has been revoked
2024-12-19 14:01:06 +01:00
Kate
c2e9e078e1
Merge pull request #49822 from nextcloud/backport/49361/stable30
[stable30] fix(files_sharing): Fix error messages from password policy
2024-12-12 21:13:04 +01:00
John Molakvoæ
d8c9c0ca2e
Merge pull request #49615 from nextcloud/backport/49569/stable30
[stable30] perf: improve performance of SharedStorage::getWatcher
2024-12-12 18:40:13 +01:00
Côme Chilliet
2fa67bfd52
fix(files_sharing): Fix error messages from password policy
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:16 +01:00
Luka Trovic
317c9b2c05 fix(sharing): add command to fix broken shares after ownership transferring
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2024-12-12 07:15:50 +01:00
skjnldsv
8466d6adf3 fix(activity): make emails for link share uploads true by default
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 14:51:39 +00:00
Robin Appelman
150fc1efde
perf: improve performance of SharedStorage::getWatcher
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-03 14:17:02 +01:00
Benjamin Gaussorgues
7699598b94 chore: stricter access to testremote endpoint
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-11-28 10:49:27 +00:00
provokateurin
a7f5b452d1
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 08:38:58 +01:00
provokateurin
2ba4f6b2a0
fix(files_sharing): Cleanup error messages
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 13:07:38 +01:00
fenn-cs
26678174cc refactor(ShareApiController): Check for null and empty strings with empty()
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-25 10:26:16 +00:00
fenn-cs
0f2013d24f fix(ShareAPI): Send mails for mail shares by default
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-24 16:29:20 +00:00
Joas Schilling
58ac37dfcc fix(activity): Fix download activity parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-20 06:05:14 +00:00
Ferdinand Thiessen
d7d6874242 revert: "fix(files_sharing): Make share labels nullable"
This reverts commit 01c4fa3ba8.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 17:11:16 +00:00
provokateurin
35d2da42ec fix(files_sharing): Check if propfind response is valid before accessing share permission props
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 14:23:55 +00:00
provokateurin
93b634f497 refactor(files_sharing): Make permissions prop checks less error prone
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 14:23:55 +00:00
provokateurin
7f22f3d42d fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 14:23:55 +00:00
skjnldsv
338e045141 fix(files_sharing): adjust permissions from custom edit and delete check methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-11 11:48:25 +00:00
Marcel Klehr
1e08f91408 fix: Display 'Leave share' instead of 'Delete'
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-11 11:48:25 +00:00
provokateurin
c320bea7b5 fix(files_sharing): Make share labels nullable
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-29 06:45:35 +00:00
Louis Chemineau
e5a8f996bd chore: Apply php:cs recommendations
Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2024-08-28 14:54:14 +02:00
Robin Appelman
b2645590ce fix: implement sharding compatible cleanup for various bits
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +02:00
Ferdinand Thiessen
4bbcbc5206
feat: Make ISharedStorage public API and reuse where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:42:10 +02:00
skjnldsv
3cb80626e4 feat(activity): add share link upload notifications
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-07 09:49:38 +02:00
Andy Scherzinger
f0b658014a
Merge pull request #47070 from nextcloud/circToTeam
fix(share): Rename Circle to Team
2024-08-06 23:25:47 +02:00
skjnldsv
db28aa8cd1 fix(files_sharing): show proper share not found error message
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +02:00
Git'Fellow
6002566d92
fix(share): Rename Circle to Team
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-06 14:48:07 +02:00
Maxence Lange
b6e3009e12
Merge pull request #47043 from nextcloud/fix/noid/ignore-root-on-inherited-shares
fix(inherited-shares): ignore top root folder
2024-08-06 11:08:17 -01:00
skjnldsv
712965daa1 fix(files_sharing): filter out invalid shareWith in sharee API
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-05 20:36:45 +02:00
Maxence Lange
6c4b0dba77 fix(inherited-shares): ignore top root folder
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-05 13:40:53 -01:00
Stephan Orbaugh
5faa903363
Merge pull request #46881 from nextcloud/try-non-recursive-source
fix: try to find non-recursive share source
2024-08-01 16:55:59 +02:00