upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-24 02:11:51 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
64394 commits 675 branches 1186 tags 6.7 GiB
Commit graph

82 commits

Author SHA1 Message Date
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Côme Chilliet
77bdad84c2 Add ldap:reset-group command to unmap groups from LDAP 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:02 +00:00
Côme Chilliet
dab5ea958a
Fix unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 16:35:06 +01:00
Côme Chilliet
e80eb79a1e
Remove redundant is_array check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 11:41:59 +01:00
John Molakvoæ
b5ae67ac2a
Merge pull request #29329 from nextcloud/fix/noid/groups-unwarranted-members 2021-12-20 10:07:55 +01:00
Côme Chilliet
f3dcbfe146
Fix PHP 8.1 support for user_ldap application 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-16 09:43:30 +01:00
Arthur Schiwon
8266f88755
fix potential unwarranted memberships in nested groups from LDAP 
- the issue was present only when using PHP based resolving of nested
  group members. Normally nested members are common in AD (and Samba4) and
  are resolved per LDAP_MATCHING_RULE_IN_CHAIN by default
- resolving nested members is recursive
- when the cache entry was created it happend for intermediate groups, too,
  containing members from the parent group
- the check was added to only cache the root group with its members
- a runtime cache stores intermediate ldap read results


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-11-19 13:07:19 +01:00
Côme Chilliet
f9e6f2ea57
Use Psr\Log\LoggerInterface where it can easily be used in user_ldap 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-14 14:12:03 +02:00
Arthur Schiwon
7178194198
fix caching of objectsid searches 
- store result when no name could be retrieved, too
- cached value is not an array, was treated wrongly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-21 13:32:42 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Arthur Schiwon
4d33449faa
fix detecting cyclic group memberships 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-02-23 22:50:43 +01:00
Arthur Schiwon
90d82b03ef
fix parameter provided as string not array 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-28 15:15:55 +01:00
Arthur Schiwon
270912848f
check number of members after potential resolving of rdns 
- the type check is not necessary anymore for the return type of
  _groupMembers()

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-27 18:44:27 +01:00
Arthur Schiwon
1f40ecca86
use faster and less hungry foreach 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-27 18:38:08 +01:00
Tobias Perschon
594370e2f2 moved the array_reduce to fix large search case 
also added some additional comments and renamed some vars to make it intuitive whats in them

Signed-off-by: Tobias Perschon <tobias@perschon.at>
 2020-11-27 11:12:14 +01:00
Arthur Schiwon
57bfe0d1f9
flatten result array as expected by following code 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-26 23:36:04 +01:00
Arthur Schiwon
d741c5ab30
when nesting is not enabled, the group filter can be applied right away 
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-19 13:44:32 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Arthur Schiwon
7eb6d8df0a
do not flip available state to unavailable, allow empty results 
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-11 19:03:27 +02:00
Arthur Schiwon
7ea262dba0
LDAP: shortcut in reading nested group members when IN_CHAIN is available 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-11 18:22:11 +02:00
Arthur Schiwon
7c07f0c7f3
use break not continue in switch to avoid warning 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-10 17:34:11 +02:00
Tobias Perschon
551d904bb0
added "zimbraMailForwardingAddress" as a Group-Member association attribute to enable the use of Zimbra Distribution Lists as groups in nextcloud when connecting to a zimbra LDAP 
Signed-off-by: Tobias Perschon <tobias@perschon.at>

fix cs:check

Signed-off-by: Tobias Perschon <tobias@perschon.at>

Update apps/user_ldap/lib/Group_LDAP.php

Co-authored-by: blizzz <blizzz@arthur-schiwon.de>
Signed-off-by: Tobias Perschon <tobias@perschon.at>
 2020-08-07 23:30:44 +02:00
Morris Jobke
d72d9ff1f4
Merge pull request #21171 from nextcloud/enh/noid/tidy-up-group-ldap 
tidy up Group_LDAP
 2020-07-06 14:00:27 +02:00
Arthur Schiwon
b8bef4ded0
fix strings being passed where arrays where expected 
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-24 23:34:37 +02:00
Arthur Schiwon
64fe042b0d
tidy up Group_LDAP 
* remove unused method
* resolve code duplication
* remove usage of deprectad Util::writeLog
* phpDoc updates
* signature updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-08 13:40:24 +02:00
Arthur Schiwon
aed6f0f71e
simplify getGroups, fixing wrong chunking logic 
pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-05-27 14:41:10 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Clement Wong
9f5f505acf Don't remove last user in ldap group when limit is -1 
Signed-off-by: Clement Wong <git@clement.hk>
 2020-04-27 02:33:00 +02:00
Arthur Schiwon
4babdc082b
formatting 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-23 21:34:05 +02:00
Arthur Schiwon
e8ddb4718c
consolidate groupsMatchFilter in groupsExist 
- less duplication
- profiting of the same cache entry

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:38:07 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
blizzz
950856d5bb
Merge pull request #17717 from nextcloud/fix/noid/ldap-relax-getHome 
relax strict getHome behaviour for LDAP users in a shadow state
 2020-01-14 09:57:24 +01:00
Arthur Schiwon
489ed878e1
ensure that only valid group members are returned 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-13 17:13:08 +01:00
Arthur Schiwon
79667b58a9
cache group existence early to save useless requests to LDAP 
we do it for users already

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 11:02:37 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Arthur Schiwon
213016f758
uid can be false when the user record does not exit 
fixes not loading files app for users who got a share by the gone LDAP user

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-11-20 19:44:12 +01:00
Arthur Schiwon
d0f31c590d
Also invalidate groups after deletion 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-27 10:33:40 +02:00
Arthur Schiwon
660fbd64e3
ensures mapping of chosen userid 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-19 17:02:28 +02:00
Arthur Schiwon
1d48c0313c
fix inGroup check, thus make integration tests succeed 
there is not such strange return mode. Having invalid user ids caused this
check to fail, and as side effect share limitation to groups to not work.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-14 06:23:58 +02:00
Arthur Schiwon
c6c8a41d2f
group display name support (service level + ldap) 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-05-27 12:03:05 +02:00
Vinicius Cubas Brand
a2c38148e7
Cache cleaning when subadmin adds user to group 
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.

This just forces the cache to be reset after an user is added to a
group.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
 2019-03-21 10:20:46 +01:00
Arthur Schiwon
5dd2207c95
fix nested group retrieval also for 2 other cases 
and also consolidate logic in one method

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-03-05 11:07:40 +01:00