Commit graph

547 commits

Author SHA1 Message Date
Ferdinand Thiessen
e56fe07bbc
fix(files): Correctly validate new node name
* Resolves https://github.com/nextcloud/server/issues/45409

This includes two fixes:

1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming

2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-02 22:08:16 +02:00
skjnldsv
b1ca898ffd fix(files): show folder sharing overlay on received shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 17:53:33 +00:00
skjnldsv
a2ea37921f chore(cypress): adjust files-sidebar.cy.ts
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-02 15:00:47 +02:00
Ferdinand Thiessen
c27de43886 fix(files): Close the sidebar on navigation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-02 10:21:05 +02:00
skjnldsv
670fa2a7e0 fix(files): empty folder pending size
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 12:42:09 +00:00
fenn-cs
7e4b0d2894 fix: Adjust tests for editLocallyAction
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-31 12:31:03 +01:00
fenn-cs
4d9ba27142 feat(editLocallyAction): Handle possible no local client scenario
Resolves: https://github.com/nextcloud/server/issues/46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-31 10:12:23 +00:00
Raimund Schlüßler
bfa8c9625f fix(files): correctly shrink breadcrumbs bar
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
2024-07-30 09:53:46 +00:00
skjnldsv
6df8bdf5df fix(files): always ask for confirmation if trashbin app is disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-27 10:05:38 +02:00
Ferdinand Thiessen
9002461e0f
fix(files): Use @nextcloud/files filename validation to show more details
This will enable showing more details what exactly is wrong with the filename.
Especially with the new capabilities introduced with Nextcloud 30.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-26 02:23:19 +02:00
Ferdinand Thiessen
0539b0a92d
fix: Use functions from @nextcloud/files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-26 02:23:19 +02:00
Ferdinand Thiessen
190f3a901b
fix(files): Do not split filename into base and extension for folders
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-26 02:23:19 +02:00
Ferdinand Thiessen
6a5926ce64
chore(deps): Update @nextcloud/files to v3.7.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-26 02:23:18 +02:00
Maksim Sukharev
7ea8ace4ce
fix(files): ensure forbiddenCharacters is an array
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-07-25 08:19:42 +02:00
Maksim Sukharev
9ed5c96e3a
fix(files): validate input when creating file/directory
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-07-24 18:33:41 +02:00
grnd-alt
5981e6a08f fix: stop file actions when conflict dialog skipped
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-16 19:52:11 +00:00
Ferdinand Thiessen
57869f565f refactor: Use composable for currentView and views to make it reactive when shared with other Vue apps
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 19:05:38 +02:00
Ferdinand Thiessen
7a2fbe11ec chore(deps): Update debounce to 2.1.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 19:05:38 +02:00
Ferdinand Thiessen
07fa445f38 refactor(files): Update @nextcloud/files to v3.5.0
* Removed now duplicated code

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 19:05:38 +02:00
Louis Chemineau
a91d44b15e
fix(files): Don't react to clicks when renaming
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-01 18:34:32 +02:00
John Molakvoæ
5a232e997a
feat(files): increase max copy-move concurrency to 5
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-07-01 13:43:10 +02:00
John Molakvoæ
af5ae03b7a
Merge pull request #46137 from nextcloud/backport/45977/stable29 2024-06-28 15:58:30 +02:00
Louis Chemineau
b65135e319
fix(files): Update favorites navigation list on folder renames
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-26 16:02:07 +02:00
Louis Chemineau
ff10c5487e fix(files): Rename openFileInfo to fileInfo
And check if openFile is set in the URL before opening a file.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-19 15:10:33 +00:00
Ferdinand Thiessen
057d81c8d7 fix(files): correctly import WebDAV client in files store
The files store was importing the client, but this is only on current master
on stableX we still need to import the getter function.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-18 08:39:44 +00:00
fenn-cs
0841d9efc5 fix(deleteAction): Bump up delete requests concurrency to 5
A concurrency of who is not efficient. Low throughput, underutilization, high latency etc...

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-17 09:02:15 +00:00
Louis Chemineau
76c77cc9c5
fix(files): Show non writable folders during move or copy
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-14 11:02:02 +02:00
Louis Chemineau
f8446f73f7
fix(files): Ignore right click for default action
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-13 16:23:02 +02:00
skjnldsv
ed51cf2d5e fix(files): fetch nodes if we have multiple of the same fileid in the store
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-13 09:32:23 +02:00
skjnldsv
e2adc32175 fix(files): do not rely on unique fileid
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-13 09:32:23 +02:00
John Molakvoæ (skjnldsv)
1981d84938 fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-12 14:48:08 +00:00
skjnldsv
e82241cf89 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 11:06:09 +00:00
Sanskar Soni
d78d468b36 fix(files): handling numbered type owner name & id
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
2024-06-12 09:10:20 +02:00
John Molakvoæ (skjnldsv)
9142ad65f4
fix(files): reset menu pos when opening in grid mode
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-06-11 18:13:13 +02:00
Ferdinand Thiessen
81aa6ff233 fix(files): Ensure that focussed file is always scrolled right
Ensure the correct file is scrolled if the content changes,
this also sets a minimal height to the virtual scrolling area
so that the `scrollTop` can be set.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:10:16 +00:00
Ferdinand Thiessen
506343706b fix(files): Keep query when trigger the sidebar action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:10:16 +00:00
Ferdinand Thiessen
f02a465fa9 fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:10:16 +00:00
Ferdinand Thiessen
10cbc5748f refactor(files): Fix TypeScript issues in FileEntryActions
* We filter the array in `enabledSubmenuActions` so we can be sure the action does have a parent
* Node attributes must be accessed using the `attributes` getter not the private `_attributes` property
* Cast action ref to correct component interface to make TypeScript happy

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:10:16 +00:00
Ferdinand Thiessen
87ebfe3eef refactor(files): Consistently sort imports of FileEntryMixin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 12:11:42 +02:00
Ferdinand Thiessen
b0c29f2622 fix(files): Ensure entry with fileid is marked as active
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 12:09:53 +02:00
Ferdinand Thiessen
52039ea152 fix(files): Update current fileid in route if that node was deleted
We do not change the view to the trash bin but stay in the current view,
so we need to update the current fileid on the route if that was deleted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 12:07:33 +02:00
Ferdinand Thiessen
cc35d07a8c fix(files): Close sidebar if shown node is deleted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 12:07:33 +02:00
Ferdinand Thiessen
ace4b50819 fix(files): Only execute default action if there is an action to perform
Some files do not have a default action (can not be viewed and only downloaded).
If the `openfile` query is set on them the `handleOpenFile` will throw an error.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 12:06:37 +02:00
Christopher Ng
8aa6493c17 fix(files): Display selected files count
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit a999544ff2)
2024-06-07 11:02:05 +02:00
Ferdinand Thiessen
730aabe5bc fix(deps): Update @nextcloud/event-bus to version 3.3.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 08:54:25 +02:00
Ferdinand Thiessen
41aadc43b5 fix: Update @nextcloud/files to 3.4.0 to fix public link shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 08:54:25 +02:00
Ferdinand Thiessen
05eb647697
Merge pull request #45534 from nextcloud/backport/45419/stable29
[stable29] fix(files): Implement `SortingService` to fix sorting of files
2024-05-29 10:26:35 +02:00
Ferdinand Thiessen
b964439b35
fix(files): Focus filename input in new-node dialog when opened
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-05-28 14:09:13 +02:00
Ferdinand Thiessen
8b0a8b653b
fix(comments): Fix issues thrown by comments sidebar tab code
When the comments tab is used instead of the merged activity+comments, then some issues are throws due to prop altering and duplicated names (resourceId as prop and data).

This is fixed as well as some other vue related errors in the sidebar

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-28 10:41:34 +02:00
Ferdinand Thiessen
a9c21376f4
fix(files): Implement SortingService to fix sorting of files
The previously used library was parsing strings to try to detect dates,
but for filenames it makes no sense to parse them as dates.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-27 18:12:37 +02:00