Commit graph

1261 commits

Author SHA1 Message Date
Benjamin Gaussorgues
abd8b1645c fix(files_external): wrong type for external mount id
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-13 10:30:52 +00:00
John Molakvoæ
7e1617cfcc
Merge pull request #49652 from nextcloud/backport/49288/stable29
[stable29] fix: smb: don't fail hard if we can't load acls for a file
2024-12-12 13:21:56 +01:00
John Molakvoæ
9ab6ea8809
Merge pull request #49623 from nextcloud/backport/49602/stable29
[stable29] fix(external_storage): Cast id to int
2024-12-12 13:18:47 +01:00
Marcel Klehr
e876c8fff1 fix(external_storage): Cast id to int
follow up to #49218

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-12-05 15:27:41 +01:00
Robin Appelman
8f76edf64a fix: smb: don't fail hard if we can't load acls for a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-04 17:25:51 +00:00
Oleksander Piskun
e25bb2f0b3 fix(external_storage): Cast id to int 2024-12-03 13:00:45 +00:00
provokateurin
c8dbb119c7
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 08:40:57 +01:00
Josh Richards
ce3cec9681
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-13 08:34:23 +05:30
skjnldsv
fc08dc2ac0 fix(files_external): cast storage id int
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 09:53:49 +00:00
Maxence Lange
ae2906fa0f fix(files-external): set password as sensitive
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-10-31 10:47:09 -01:00
yemkareems
09a86b39a7
fix: resolve conflict add PasswordConfirmationRequired to saveGlobalCredentials
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-30 17:13:06 +05:30
yemkareems
63bf012461
fix: conflicts resolved by adding PasswordConfirmationRequired to update method
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-29 18:04:39 +05:30
yemkareems
c808417502 fix: add PasswordConfirmationRequired to the eternal storages mentioned in review
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-29 11:06:12 +00:00
yemkareems
7198f04258 fix: cs fix for namespace
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-24 15:51:33 +02:00
yemkareems
7f7732f96c fix: add PasswordConfirmationRequired to user storages create, update and delete
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-24 15:51:33 +02:00
Louis Chemineau
fa12da0ce7 fix: Use hashed password in files_external settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-26 13:03:28 +00:00
Marcel Klehr
50eecc7ded fix(files_external): Catch correct exception
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-26 07:36:04 +00:00
Git'Fellow
61684129e1 fix(files_external): Check key exists before accessing it
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-14 16:56:05 +00:00
Josh Richards
dc65c37af4 fix: custom port handling in UI for SFTP
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-13 03:10:27 +02:00
Daniel Calviño Sánchez
5ed377e003 fix: Fix unmodified placeholder replacing the actual value when updating
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
Andy Scherzinger
b1eb1c5a0f
Merge pull request #46679 from nextcloud/backport/44294/stable29
[stable29] fix: Pass the mountpoint target user to storages without owner
2024-07-25 19:40:10 +02:00
Robin Appelman
ed58026e4d feat: add a specialized writeStream implementation for s3 external storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-25 11:02:42 +00:00
Julius Härtl
c60725c813 fix: Pass the mountpoint target user to storages without owner
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 12:51:50 +00:00
Benjamin Gaussorgues
a631733d06 fix: allows admin to edit global credentials
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-10 22:06:47 +02:00
Daniel Calviño Sánchez
8c2f05f05e fix: Do not log an error when connecting to SFTP without a logged in user
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.

Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.

Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-07-10 15:17:47 +02:00
Côme Chilliet
cd53e71d80 chore: Improve phpdoc typing to silence psalm errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Julius Härtl
e330efe5a0
fix: Implement option to temporarily set the user session
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-19 13:48:23 +01:00
Robin Appelman
42e14cc4c7 feat: add command to scan external storages directly
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 19:11:08 +01:00
Julius Härtl
d576b8eaf9 fix: Allow to disable multipart copy on external s3 storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-02-24 17:11:07 +01:00
Maxence Lange
2f41b9c092 mark MOUNT_TYPE_PERSONAl as deprecated
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-24 11:33:44 +01:00
Maxence Lange
1a5b545fe8 full uppercase const
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-24 11:33:44 +01:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Arthur Schiwon
35d0c63abc
Merge pull request #43349 from nextcloud/fix/case-sensitive-root-smb
SMB: allow to list root directory when using case-insensitive option
2024-02-12 11:14:07 +01:00
Josh
2e00184eb4
fix(files_external) Add sensitive S3 values redacted by list command
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-02-07 10:05:46 -05:00
Benjamin Gaussorgues
2cb0bf5437
fix(files_external): list root when using SMB case-insensitive option
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-05 11:24:12 +01:00
Côme Chilliet
b2e9e0fa0d chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +01:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +01:00
Valdnet
9064171b27 Correct a typo
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-28 15:48:58 +01:00
Joas Schilling
64f5faf8b5
fix(files_external): Fix "Could not find resource main.js to load"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-27 12:35:41 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
jld3103
755de1e0b5 refactor: Rename OpenAPI type aliases to their namespaces
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-02 11:37:15 +01:00
Benjamin Gaussorgues
c52d5e418a
Merge pull request #41053 from nextcloud/bug/smb/in-place-case-rename
fix(files_external): on case insensitive system, block case change
2023-10-31 16:07:29 +01:00
Joas Schilling
4759e7a22d
fix(external): Get storage before update it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 06:46:05 +02:00
Louis Chemineau
e66e8bad1a
Return correct status if touch failed
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-10-23 15:26:43 +02:00
Benjamin Gaussorgues
a45e12abc8
fix(files_external): on case insensitive system, block case change
When a file/directory is renamed to the same name with only case change,
the rename fail. We block this kind of rename.
The user will have to rename to another name first.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-10-23 10:32:28 +02:00
John Molakvoæ
ae29608e46
fix(files_external): basic auth user storage trigger
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-10 12:07:48 +02:00
Louis
45cac16432
Merge pull request #39131 from fsamapoor/refactor_lib_files_external_commands
Refactors files_external app commands
2023-09-28 14:39:49 +02:00