Commit graph

622 commits

Author SHA1 Message Date
Git'Fellow
23e8b2d757 fix(setupchecks): Binary data can have problems with serialize
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-10 08:01:39 +00:00
Joas Schilling
08713db193
Merge pull request #49593 from nextcloud/backport/49588/stable29
[stable29] fix(setupcheck): Make the Memcache setupcheck use the cache
2024-12-20 11:15:34 +01:00
Joas Schilling
e3c1eb6935
fix(setupcheck): Make the Memcache setupcheck use the cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-19 15:36:24 +01:00
Joas Schilling
42f8482c1b fix(setupcheck): Disable PhpMaxFileSize setupcheck for now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-04 08:04:37 +00:00
Git'Fellow
60d1ab252c fix(SetupChecks): Make sure array key is set
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 12:10:20 +00:00
skjnldsv
e3f5b721c6 fix(settings): psalm PhpMaxFileSize setup check warning
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 19:08:19 +01:00
skjnldsv
2cb56e2f1a feat(settings): add big file upload setup checks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 16:23:47 +00:00
Kate
749b6f3f68
Merge pull request #48570 from nextcloud/backport/48532/stable29 2024-10-29 10:27:14 +01:00
Marcel Müller
50be325119 fix(appstore): Hide last modified information for shipped apps
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-10-18 12:06:56 +02:00
Ferdinand Thiessen
d126fc3ad0
refactor(settings): CheckServerResponseTrait always expect absolute path
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-11 13:27:41 +02:00
Ferdinand Thiessen
39d66ed5f6
fix(setup-checks): Ensure URL with webroot works
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-11 13:09:20 +02:00
Maksim Sukharev
d03659bb0f fix: do not reduce count for subadmins if they are members of group
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-04 18:06:31 +00:00
Maksim Sukharev
a448d5d171 fix: correctly count disabled users for subadmins
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-09-30 10:10:45 +00:00
Ferdinand Thiessen
954213642a fix: Ensure app discover section is returned as list
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 11:36:45 +00:00
Joas Schilling
f7748b7e64
fix(a11y): Add OTF font loading check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 10:05:51 +02:00
Côme Chilliet
48c807e667 fix(setupchecks): Test overwrite.cli url first, then generated one, and
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 15:53:45 +00:00
Daniel Kesselberg
e004fb7042 fix: add option to remove the webroot for setup checks and don't check trusted_domains.
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 15:53:45 +00:00
provokateurin
e08bf1f4b0 fix(settings): Fix sharing exclude groups from password requirement option not working
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-03 15:13:57 +00:00
Joas Schilling
bb324019fa fix(security): Update expiration date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-14 10:45:22 +00:00
Git'Fellow
9d062fb7cc fix: typo
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Git'Fellow
6c39e9d074 fix: check both CLI and value
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Git'Fellow
dde693cdf6 fix(setupchecks): Skip checking for OPcache if running from CLI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-01 18:05:12 +00:00
Anupam Kumar
092fbb206f fix(AdminSettings/AI): show pref list of only the enabled translation providers
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-08-01 10:57:07 +00:00
Anna Larch
620d58fdf1 fix(caldav): lower scheduling table size warning
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-25 20:16:26 +02:00
Benjamin Gaussorgues
0022db138d fix(search): show user search provider for deactivated and admin pages
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-24 14:40:35 +00:00
Ferdinand Thiessen
2071f4d713
Merge pull request #46298 from nextcloud/backport/46174/stable29
[stable29] fix(IntegrityCheck): Ensure the check is run if no results are available
2024-07-10 19:01:43 +02:00
MichaIng
79bcb9d3de fix(settings): make trailing slash for caldav/carddav redirects optional
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.

Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.

This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).

While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.

This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.

Signed-off-by: MichaIng <micha@dietpi.com>
2024-07-10 00:24:39 +02:00
Ferdinand Thiessen
57c889f773
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-05 12:32:39 +02:00
Daniel Kesselberg
c0d4d376cb fix(setupchecks): skip check when disk_free_space is disabled
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-29 14:00:33 +00:00
Robin Appelman
d3d2488fbb feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 11:22:49 +02:00
John Molakvoæ
39adc5f019
Merge pull request #44675 from nextcloud/backport/44306/stable29 2024-06-07 12:17:37 +02:00
John Molakvoæ
8ed2df80c2
Merge pull request #44988 from nextcloud/backport/44973/stable29 2024-06-07 11:03:00 +02:00
Anna Larch
ec94f5499c fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 11:10:03 +00:00
Josh
cb63ff82c1
Merge pull request #45284 from nextcloud/backport/45262/stable29
[stable29] fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-14 07:47:25 -04:00
Josh Richards
a4ef527e75 fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-13 10:07:35 +00:00
Josh Richards
00b22f6c11 fix(setupCheck): Only warn when memcache present w/o memcached
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-13 09:55:37 +00:00
Côme Chilliet
5f8157f693
fix(setupchecks): Fix opcache buffer check
This was broken by last codestyle update, maybe even before because of
 operator precedence. Now using vars to make it readable and correct at
 the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 10:51:51 +02:00
Christopher Ng
5885a75a96 feat: Add legal notice and privacy policy links to help page
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-23 15:40:36 +00:00
Johannes Merkel
8b614a9dc1 fix(settings): show warning for indexToReplace as part of missing indices
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-04-05 11:17:30 +00:00
Joas Schilling
69a3038086
Merge pull request #44622 from nextcloud/backport/44534/stable29
[stable29] build(deps): bump nextcloud/coding-standard from 1.1.1 to 1.2.1 in /vendor-bin/cs-fixer
2024-04-04 13:07:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Josh
c0debe27d6 fix(SetupChecks): Add hint about dns/firewall if mjs check can't run
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 16:53:30 +00:00
Joas Schilling
48a4a95594 fix(security): Update expiration date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-28 11:09:23 +00:00
Ferdinand Thiessen
5453c1d7fa
feat(settings): Allow to sort groups in the account management alphabetically
We can do this purly in the frontend - but when enforced from the backend using the existing system config,
we need to follow the requirement. We then show a warning about the configuration.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-27 12:04:03 +01:00
Ferdinand Thiessen
14addf3fdb
fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +01:00
Ferdinand Thiessen
bae133bf4f fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-19 09:36:06 +01:00
Corentin Damman
0fa9f3049f feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
Relates to #3387

Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +01:00
Julien Veyssier
ba94de2510
fix: when no AI setting has been set, make sure the selected text processing provider is the same as the one that will be used
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-03-15 13:17:29 +01:00
Ferdinand Thiessen
df502c114d
feat(settings): Cache app discover images to ensure privacy of users
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +01:00
Ferdinand Thiessen
f4efb762ec
feat: Allow to fetch app discover json and provide frontend API route
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:24 +01:00