Commit graph

10 commits

Author SHA1 Message Date
Jonas Meurer
af00399893
Respect user enumeration settings in user status lists
So far, the functions to find user statuses listed didn't respect user
enumeration settings (`shareapi_allow_share_dialog_user_enumeration`
and `shareapi_restrict_user_enumeration_to_group` core app settings).

Fix this privacy issue by returning an empty list in case
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

In the long run, we might want to return users from common groups if
`shareapi_restrict_user_enumeration_to_group` is set. It's complicated
to implement this in a way that scales, though. See the discussion at
https://github.com/nextcloud/server/pull/27879#pullrequestreview-753655308
for details.

Also, don't register the user_status dashboard widget at all if
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

Fixes: #27122

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-10-25 10:00:20 +02:00
blizzz
56b68ce4e0
Merge pull request #27375 from nextcloud/bugfix/noid/dont-update-offline-status
Don't update statuses to offline again and again
2021-06-07 12:12:33 +02:00
Joas Schilling
55c44580c2
Don't update statuses to offline again and again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-07 09:32:00 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Morris Jobke
2adfb27007
Merge pull request #23129 from nextcloud/enh/noid/tests-user-status
More tests for user_status
2020-10-06 22:13:44 +02:00
Joas Schilling
0c7c358d13
Increase the timeout of statuses
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-01 08:54:35 +02:00
Daniel Kesselberg
a61394d528
Add test case for getDefaultStatusById
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-24 22:32:27 +02:00
Georg Ehrke
7fedd33825
Better cleanup routine for statuses
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:38 +02:00
Georg Ehrke
bd6a6cf3bf
Add Status Dashboard
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 15:43:34 +02:00
Georg Ehrke
0fad921840
Add user-status app
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-31 16:45:27 +02:00