Commit graph

6106 commits

Author SHA1 Message Date
Christopher Ng
312a208be6 Test all scopes
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-08 23:37:51 +00:00
Christopher Ng
107c940f78 Fix get avatar authorization
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-08 23:37:50 +00:00
Vincent Petry
ec47f342c4 Add unit tests for encryption's isSystemWideMountPoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-02 12:15:29 +00:00
Joas Schilling
277fe92ca0
Merge pull request #32433 from nextcloud/backport/32305/stable22
[stable22] Fix user agent trimming on installation
2022-05-16 21:28:23 +02:00
Joas Schilling
ec9cdf2a43 Fix user agent trimming on installation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 13:11:40 +00:00
Joas Schilling
355359be81
Extend tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 13:57:36 +02:00
Joas Schilling
23a6262f2e Add a unit test for translation with trailing colon
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:51:48 +00:00
Kirill Popov
651b7b2141 Get not only time-sensitive next job from list but any
Before the change webcron used to select
**only** time-sensitive tasks.

Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-25 13:22:36 +00:00
blizzz
01874d9a9d
Merge pull request #31747 from nextcloud/backport/31592/stable22
[stable22] Add direct arg to login flow
2022-04-14 14:31:49 +02:00
blizzz
a96a2ec55c
Merge pull request #31677 from nextcloud/backport/31658/stable22
[stable22] Limit the length of app password names
2022-04-14 14:15:08 +02:00
Vincent Petry
b321a431aa Add direct arg to login flow
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-Authored-by: Carl Schwan <carl@carlschwan.eu>
2022-04-14 13:02:29 +02:00
Maxence Lange
7ce8459056 confirm user is internal to globalscale
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-04-12 12:22:08 +00:00
Joas Schilling
9b386f2b43
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 21:44:33 +01:00
Joas Schilling
ea0be37e69
Limit the length of app password names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 21:44:33 +01:00
Robin Appelman
cb3dc01163 fix fs cache test user setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-21 13:55:08 +00:00
Joas Schilling
c43730238f
Allow apps to specify if their background job can be delayed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-22 11:56:17 +01:00
Vincent Petry
806d702458
Merge pull request #30958 from nextcloud/backport/30949/stable22
[stable22] Allow to disable AuthToken v1
2022-02-18 14:34:09 +01:00
Joas Schilling
ad55d3b4c0
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-01 14:32:00 +01:00
John Molakvoæ
c0b29720e1
Merge pull request #30826 from nextcloud/backport/stable22/psalm-fix 2022-01-27 20:05:54 +01:00
Carl Schwan
0262cc33d7
Fix psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-24 13:34:48 +01:00
Carl Schwan
8e9f02fce2
Fix tests with email templates
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-20 10:38:11 +01:00
John Molakvoæ
295348446b
Implement multibucket shift for ObjectStore
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-14 08:32:04 +01:00
Carl Schwan
e8f6e062dd
Fix idn emails not working in shares
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 17:16:21 +01:00
Joas Schilling
51d4f30e9b
Merge pull request #30610 from nextcloud/backport/30588/stable22
[stable22] Fix undefined/unset scope in account properties
2022-01-12 13:50:43 +01:00
Joas Schilling
7987158438 Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 18:44:46 +00:00
Joachim Bauch
d7d47169e4 Prevent loading images that would require too much memory.
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 14:49:15 +00:00
Christopher Ng
bbb78f848b Fix email verification
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-01-07 10:58:40 +00:00
Robin Appelman
dce2198f89 fix tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-06 01:11:44 +01:00
Vincent Petry
cc0d10435b Improve normalizer detecting IPv4 inside of IPv6
The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-23 10:25:54 +00:00
Vincent Petry
c247e237d7 Fix getting subnet of ipv4 mapped ipv6 addresses
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-23 10:25:54 +00:00
Vincent Petry
a721d346b9 Normalize directory entries in Encoding wrapper
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().

This makes the scanner work properly as it assumes pre-normalized names.

In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-19 14:51:40 +00:00
Naoto Kobayashi
0bb3232a33 OC_Util: Add fallbacks to check if current locale is UTF8
Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-17 09:01:45 +00:00
Naoto Kobayashi
0c1f10880b Add check whether escapeshellcmd behaves the same as basename
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-17 09:01:45 +00:00
Naoto Kobayashi
d5cff00d10 Fix missing setlocale with php 8
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-17 09:01:45 +00:00
Joas Schilling
3709a8182a
Apply changes from master's update to 3.1.3
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-15 19:06:36 +01:00
Joas Schilling
6ed9bccb3d Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-12 14:52:38 +00:00
Côme Chilliet
f8c8b2cea9 Enable Avatar tests as well for PHP>=8
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-02 09:59:36 +00:00
Côme Chilliet
e498aaf2c8 Revert "Do not run image tests on php8"
This reverts commit d690f90928.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-02 09:59:36 +00:00
MichaIng
5bd6a4fd29
Merge pull request #29415 from nextcloud/backport/27440/stable22
[stable22] Handle files with `is_file` instead of `file_exists`
2021-10-30 00:19:28 +02:00
MichaIng
eb79cb6861
Merge pull request #29393 from nextcloud/backport/26725/stable22
[stable22] Fix federated scope not shown when public addressbook upload is disabled
2021-10-24 20:05:38 +02:00
Daniel Calviño Sánchez
0547440069 Add missing scope to test
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-10-23 20:25:39 +02:00
MichaIng
629225c30a
Merge pull request #29391 from nextcloud/backport/29220/stable22
[stable22] s3 external storage fixes
2021-10-23 20:20:25 +02:00
acsfer
72776e5493 Update Tests 2021-10-23 09:28:13 +00:00
acsfer
1714ead4f2 Tests update 2021-10-23 09:28:13 +00:00
Robin Appelman
a3d365b33b ci
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-22 12:34:30 +00:00
Christoph Wurst
4e41638101 Prevent duplicate auth token activity updates
The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds

This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.

This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.

This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:16:05 +00:00
Daniel Kesselberg
8ce2a320a1 explicitly close source stream on local storage
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-08 08:04:34 +00:00
Joas Schilling
a8415ea7d7
Fix app version check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-29 10:07:45 +02:00
Joas Schilling
e4817972d8 Add a unit test to check for casting a IQueryFunction
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-24 20:20:02 +00:00
Daniel Kesselberg
74ba52641d
Add email addresses to contacts menu
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-17 10:04:22 +02:00