Commit graph

23014 commits

Author SHA1 Message Date
Lorenz Brun
a6f879e154 dav: fix wrong decoding of pluses in URLs
PHP's urldecode function does not decode URLs according to RFC 3986, but
according to the HTML 4.01 query parameter
encoding. This results in pluses being wrongly decoded to spaces even
though they should not be decoded at all.

Use rawurldecode instead, which follows RFC 3986 properly.

This fixes an issue where files on DAV shares containing pluses were
incorrectly decoded to spaces.

Fixes: #15849
Signed-off-by: Lorenz Brun <lorenz@brun.one>
2024-01-31 13:26:04 +01:00
Louis
7dc5a91f71
Merge pull request #38173 from arawa/feature/37677/exclude-some-groups-from-sharing-with-users
New core setting : shareapi_only_share_with_group_members_exclude_gro…
2024-01-31 13:24:47 +01:00
Christoph Wurst
6594360638
Merge pull request #42933 from nextcloud/fix/db/dirty-read-on-primary
fix(db): Execute dirty reads on the primary node
2024-01-31 10:55:05 +01:00
Baptiste Fotia
9af96d9f9a feat(php,vue): Create a new parameter
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Maxence Lange
6c49e9c68a Revert "switching to new IAppConfig"
This reverts commit c693c58d25.


Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:37:09 -01:00
Maxence Lange
c693c58d25 switching to new IAppConfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:33:50 -01:00
Côme Chilliet
52f3616254
Merge pull request #43194 from nextcloud/fix/fix-psalm-missing-template-parameter 2024-01-30 15:24:42 +01:00
Christoph Wurst
97152de9bf
fix(db): Execute dirty reads on the primary node
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 12:17:39 +01:00
Joas Schilling
e0053e1c06
Merge pull request #43185 from nextcloud/feat/db/dirty-queries-production
feat(db): Make dirty query logging available in production
2024-01-30 12:05:49 +01:00
Côme Chilliet
6533431c36
Merge pull request #43191 from nextcloud/fix/use-di-for-setup-class 2024-01-30 11:10:52 +01:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +01:00
Christoph Wurst
911ab393c0
feat(db): Make dirty query logging available in production
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 10:31:03 +01:00
Côme Chilliet
1f6279fa76
Merge pull request #43031 from nextcloud/fix/fix-throw-phpdoc-in-setupresult 2024-01-29 22:10:53 +01:00
Ferdinand Thiessen
85978593fe
Merge pull request #42794 from nextcloud/fix/invalid-trusted-proxies
fix(Request): Catch exceptions in `isTrustedProxy`
2024-01-29 16:19:51 +01:00
Côme Chilliet
67e3ecef98
chore: Cleanup Installer class as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 16:10:31 +01:00
Côme Chilliet
ccc66e912b
fix: Use DI for Setup class and move away from deprecated methods
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 15:28:00 +01:00
Côme Chilliet
a2eacf4487 Document throwing behavior of SetupResult upon invalid rich object
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 14:14:17 +01:00
Arthur Schiwon
3749c2c79b
Merge pull request #42930 from nextcloud/fix/6914/overwritecond
Fix: config param 'overwritecondaddr' not working
2024-01-29 09:56:56 +01:00
Nextcloud bot
f36a9d09f2
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-28 00:19:08 +00:00
Pavel Kryl
30ad530814 code style: ommited space, reverted [code review] 2024-01-27 15:11:26 +01:00
Pavel Kryl
446ecbc454 fixing bug #6914: Config Param 'overwritecondaddr' not working
- just ignoring/removing extra parameter 'protocol' as suggested by
  blizzz

Signed-off-by: Pavel Kryl <pavel@kryl.eu>
2024-01-27 15:11:26 +01:00
Ferdinand Thiessen
7620d230df
fix(Request): Catch exceptions in isTrustedProxy
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 14:59:51 +01:00
Nextcloud bot
764f34c4f6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-27 00:19:36 +00:00
Maxence Lange
8362025643 better indexes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-24 20:01:56 -01:00
Julius Härtl
8c777145f2
Merge pull request #42597 from nextcloud/perf/s3-mkdir-update-size
perf: Avoid updating the folder size if we know the size difference
2024-01-23 19:39:28 +01:00
Joas Schilling
582ec1294a
fix(apps): Fix type information of app manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-23 09:55:06 +01:00
Christoph Wurst
033a654389
Merge pull request #42929 from nextcloud/fix/db/transacted-read-not-dirty
fix(db): Do not log transacted reads as dirty read
2024-01-23 09:34:20 +01:00
Christoph Wurst
03774ad77c
Merge pull request #42971 from nextcloud/fix/auth/login-email-password-login-name-mismatch
fix(auth): Fix logging in with email and app password
2024-01-22 10:41:48 +01:00
Nextcloud bot
af313a79e8
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-21 00:19:16 +00:00
Christoph Wurst
7f2fdd8843
fix(auth): Fix logging in with email, password and login name mismatch
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-19 19:29:41 +01:00
Nextcloud bot
9f6df9171b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-19 00:19:27 +00:00
Christoph Wurst
ab0d7c007d fix(db): Remove very verbose dirty query logs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 18:33:07 +01:00
Christoph Wurst
f54b08c224
fix(db): Do not log transacted reads as dirty read
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 13:37:36 +01:00
Arthur Schiwon
c4f4c5a3fb
Merge pull request #41067 from Murena-SAS/preview-folder-deletes
Fix for previews not being generated sometimes
2024-01-18 11:46:12 +01:00
Joas Schilling
0e40457b86
Merge pull request #42847 from nextcloud/fix/42843/exception-on-their-own
exceptions on their own
2024-01-18 09:59:36 +01:00
Pytal
e42f511412
Merge pull request #42860 from nextcloud/jr/fix/i42858
Update ContactsStore: Avoid exceptions on empties
2024-01-17 10:39:16 -08:00
Robin Appelman
0492e0f1d4
Revert "add key location to info:file output"
This reverts commit 7bf82fc312.
2024-01-17 17:53:37 +01:00
Robin Appelman
7bf82fc312
add key location to info:file output
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-17 17:47:01 +01:00
Git'Fellow
72e0618f20
fix(session): Avoid two useless authtoken DB queries for every anonymous request
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:17:23 +01:00
Josh
36e0b02712
Update ContactsStore: Avoid exceptions on empties
Fixes #42858 and makes things more robust

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-01-16 23:57:58 -05:00
Maxence Lange
db8636ac1a exceptions on their own
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:48:27 -01:00
Maxence Lange
addd678682 returns default on exception
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:35:24 -01:00
Maxence Lange
fdd38b46e3
Merge pull request #41755 from nextcloud/enh/noid/lazyconfig
Lazy grouping within IAppConfig
2024-01-16 08:39:13 -01:00
John Molakvoæ
85849767f2
Merge pull request #42806 from nextcloud/bugfix/noid/only-send-subscription-key-to-our-appstore 2024-01-16 10:16:05 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check 2024-01-16 09:04:24 +01:00
Nextcloud bot
587057b0ed
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-16 00:18:51 +00:00
Maxence Lange
94fe48c998 small fixes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Maxence Lange
6daea857ab fixes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
d

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Maxence Lange
f7d0c74b10 lazy AppConfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Joas Schilling
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 15:39:45 +01:00