Commit graph

164 commits

Author SHA1 Message Date
Ferdinand Thiessen
a8358dad8c
fix(files_sharing): ugly hacks to update permissions on share creation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-18 16:00:54 +01:00
yemkareems
92a93393e1
fix: pass hide download attribute while creating the share to fix github issue 50788
Signed-off-by: yemkareems <yemkareems@gmail.com>
2025-03-18 16:00:54 +01:00
John Molakvoæ
466850f796 fix(eslint): Strings must use singlequote
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-02-28 16:43:14 +01:00
Valdnet
288287935a fix(l10n): use do not instead of don't
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-02-28 16:43:14 +01:00
Ferdinand Thiessen
b06f5ba4c4
refactor: Migrate nextcloud-vue usage to new import schema
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 02:28:13 +01:00
Ferdinand Thiessen
10265ba182
feat(sharing): Allow to set default view mode for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-10 18:57:38 +01:00
nfebe
3d090d2904 fix(files_sharing): Update QuickShareSelect if share is modified
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 12:15:38 +01:00
nfebe
a2d4be2ddb fix: Show default expiration date before create link share
Since `ShareEntryLink` component is used to both create and display/list the share links,
we should only set default expiration date on `share.expireDate` when we know is a new share.

Otherwise, we overidding data from the backend.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 12:15:38 +01:00
nfebe
5ee354f155 feat: Only show show inherited shares section if present
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
nfebe
ae854e0dd2 refactor(files_sharing): Split internal & external shares
Create two seperate sections for internal and external shares.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
Thomas Lehmann
fde013b3c7 refactor(files_sharing): move deprecated projects component
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:03 +01:00
Christopher Ng
1a43fc5718 feat(sharing): Toggle custom tokens setting as admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
cdc65b6985 feat(sharing): Make it possible to customize share link tokens
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Ferdinand Thiessen
214a084d92
fix(files_sharing): Remove debounce from expiration date formatting
This should be done as soon as changed, as the value is not passed to
API but needs to be tracked internally (e.g. if you quickly press
"save").

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-15 15:48:22 +01:00
nfebe
2034c3e107 fix: Only show share permission if re-sharable
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-03 14:25:15 +01:00
nfebe
d6efc531f6 refactor: Use new ShareType across file_sharing
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-03 14:25:15 +01:00
skjnldsv
dd5a344f5e chore: lint fix
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 09:56:30 +01:00
Ferdinand Thiessen
f6e6ba4851 refactor(styles): Adjust code style in SCSS sources to match our stylelint config
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:42:13 +01:00
fenn-cs
0daacbe81d fix(ShareEntryLinkList): Append new links to the end of list
Currently new shares are added to beginning of the share list in the UI
messing up the ordering with the original (first) looking like the most
recent and the most recent looking like the original share. This error
disappears on refresh.

Resolves : https://github.com/nextcloud/server/issues/48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-30 14:56:55 +01:00
Ferdinand Thiessen
abcb02f06e
fix(files_sharing): Password field must not be required if already set
If there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-30 10:30:09 +01:00
Ferdinand Thiessen
e8c1e2c611
fix(code-style): Adjust JS code to our code style
This resolves 68 ESLint warnings about invalid code style.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 22:11:59 +02:00
Ferdinand Thiessen
cb4c569486
fix(files_sharing): Ensure sidebar share entry lists are labelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
1dafdce3e7
fix(files_sharing): Set file-request header for nextcloud/upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
563f8e7c5d
refactor(files_sharing): Make file structure more clear
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
96c8275586
feat(files_sharing): Migrate public share to use Vue files list
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:42 +02:00
Julius Härtl
fe3926f0f0 fix: Properly handle share attributes if set to null
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-30 17:33:39 +00:00
Ferdinand Thiessen
aea0e8df6a fix: Adjust more places for logical position
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Mostafa Ahangarha
723780d184 feat: Add bidi support in core directory
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
Ferdinand Thiessen
a5e58dc45e
test: Migrated all Jest tests to vitest
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 17:27:22 +02:00
Ferdinand Thiessen
dc153f2ada fix(files_sharing): Sort by correct share attribute ("share with displayname")
There is no `title` attribute, so this causes an exception.
Instead sort by the "share with" displayname which will be the user or group the node is shared to.
Meaning this will also be the title of the share in the UI.
If this is not available or there are multiple for the same, then sort by the custom label.
If also this is not set sort by the creation time.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 02:32:02 +02:00
Ferdinand Thiessen
132220a89f
fix: Access node owner by top level owner property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 17:59:10 +02:00
Archisman Das
a6a1bb9e42
fix: Update translation string
Signed-off-by: Archisman Das <archisman.officials@gmail.com>
2024-08-13 14:34:42 +02:00
skjnldsv
b96800ecc5 fix(files_sharing): getShares optional chaining
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-07 16:06:25 +02:00
2lar
6cf1aed93a fix(files_sharing): tab shares title and creation sort
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-08-07 11:39:54 +02:00
Ferdinand Thiessen
5b400c1be7
fix(files_sharing): Ensure "note to recipient" textarea is shown if there is a note
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-31 15:05:15 +02:00
Ferdinand Thiessen
d6518196cc
fix(files_sharing): Add missing "note to recipient"
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-31 15:05:15 +02:00
skjnldsv
197c35598c chore(files_sharing): refactor Share model to ts
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-30 09:50:46 +00:00
skjnldsv
850cb082a9 feat(files_sharing): show file requests in navigation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-30 09:50:46 +00:00
skjnldsv
08af33b5d9 chore: add file request cypress testing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-19 12:20:25 +02:00
skjnldsv
2c94404969 fix(files_sharing): also allow removing READ permissions on email shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 20:15:39 +02:00
skjnldsv
f28d933acc feat(files_sharing): add public name prompt for files requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 20:15:39 +02:00
skjnldsv
208ff8013d chore(files_sharing): refactor sharing config
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
skjnldsv
75ca4944c9 feat(files_sharing): allow mixed values in share attributes and allow storing email arrays
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
skjnldsv
443c48aefb feat(files_sharing): add new file request option
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
skjnldsv
b6f635f6f6 chore(files_sharing): rename File drop to File requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
Ferdinand Thiessen
24c01695bb
test: Adjust Typescript definitions for OCP and OC
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
fenn-cs
48339500fc fix(SharingDetailsView): Prevent illegal unselection of read permissions
With the exception of "file drop" on link shares all other shares need the read permissions at least.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-08 20:32:52 +01:00
fenn-cs
f7527c3279 refactor(SharingDetailsView): Use NC logger
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-25 18:16:48 +01:00
fenn-cs
38b5987b40 fix(FilesView): Update files view upon share creation/delete
Resolves : https://github.com/nextcloud/server/issues/44961

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-25 18:16:48 +01:00
fenn-cs
8ac2c8e9e2 fix(files_sharing): Improve recursion in onNewLinShare
These changes fixes the issue of having the refresh the UI after share creation, as the share is not
immediately removed from the UI list.

Important changes

- The basis of checking wether a password/expire date is no longer based on config values alone
because the config is not expected in a share creation circle. Hence we check the configs and check
if the share object (this.share) has the expected values set. This way, once the required properties
are set, code control does not enter the block meant to handle the setting of required properties
unneccessarily.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-12 23:04:57 +01:00