Commit graph

9210 commits

Author SHA1 Message Date
Joas Schilling
8544be0867 Undefined variable response when server is no nextcloud anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-08-21 14:07:42 +00:00
Joas Schilling
c79156146b Filter more configs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-08-20 07:03:38 +00:00
Roeland Jago Douma
337aa1cd3c Properly return an int in the getId function of the cache
fixes #16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-08 06:15:53 +00:00
Arthur Schiwon
8c956693a5 treat sensitive config keys by pattern
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-07-26 14:07:17 +00:00
Marcel Klehr
eb14a8fcba Fix File#putContents(string) on ObjectStorage
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2019-07-17 20:40:05 +00:00
Roeland Jago Douma
7bd081ff84 Do not keep searching for recent
If userA has a lot of recent files. But only shares 1 file with userB
(that has no files at all). We could keep searching until we run out of
recent files for userA.

Now assume the inactive userB has 20 incomming shares like that from
different users. getRecent then basically keeps consuming huge amounts
of resources and with each iteration the load on the DB increases
(because of the offset).

This makes sure we do not get more than 3 times the limit we search for
or more than 5 queries.

This means we might miss some recent entries but we should fix that
separatly. This is just to make sure the load on the DB stays sane.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-17 05:48:53 +00:00
Morris Jobke
bbd4007753
Merge pull request #16215 from nextcloud/backport/16186/stable15
[stable15] Better check reshare permissions part2
2019-07-03 23:29:09 +02:00
Joas Schilling
132902337e
Unify the permission checking in one place only
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 21:31:40 +02:00
Joas Schilling
029ecb7966
Better check reshare permissions when creating a share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 21:29:31 +02:00
Roeland Jago Douma
32c072853f
Fix notification casting
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-03 20:32:45 +02:00
Robin Appelman
cdc97ec9c3 verify that paths are valid for recursive local move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-27 14:39:32 +00:00
Roeland Jago Douma
f63a2bfd97
Merge pull request #16083 from nextcloud/backport/15832/stable15
[stable15] Fix full text search for groupfolders
2019-06-26 15:48:57 +02:00
Joas Schilling
fdc532f753 Fall back to black for non-color values
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-26 08:18:31 +00:00
Morris Jobke
9ad616e221 Fix full text search for groupfolders
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-06-25 19:46:25 +00:00
Joas Schilling
bad2e92c89 Prevent faulty logs from nested setupFS calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-21 10:02:23 +00:00
Daniel Kesselberg
567fe4b833
Don't notify admins if no potentially over exposing links found
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-06-03 21:41:32 +02:00
Robin Appelman
2b845a7268 search files by id in shared storages last
this prevents unneeded recursion when the file is not in the share

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-05-29 19:58:44 +00:00
Julius Härtl
91bc8ba2cd Check for free space on touch
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-28 13:03:53 +00:00
Roeland Jago Douma
d0f8fa4619 Check the actual status code for 204 and 304
The header is the full http header like: HTTP/1.1 304 Not Modified
So comparing this to an int always yields false
This also makes the 304 RFC compliant as the resulting content length
should otherwise be the length of the message and not 0.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-24 17:52:33 +00:00
Morris Jobke
1a8de51e25 Allow redis cluster to use password
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-22 11:48:18 +00:00
Morris Jobke
a68495b443 Fix l10n for SettingsManager by injecting the l10n factory
Fixes #10832

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-21 22:52:06 +00:00
Julius Härtl
32a18602fd Only show sharing section if it has content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-21 08:34:40 +00:00
Joas Schilling
eb8c2e98bd
fix class might be undefined
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-09 11:25:54 +02:00
Arthur Schiwon
04bb1510fd
remove args from logging of common-spelled methods dependent on class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-09 11:25:54 +02:00
Arthur Schiwon
b5e4b774fa
remove setup args from logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-09 11:25:54 +02:00
Morris Jobke
740907101a
Use non-absolute logout URL to fix wrong URL in reverse proxy scenario
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-08 23:38:42 +02:00
Morris Jobke
e0ce0c8d97
Merge pull request #15307 from nextcloud/backport/15290/stable15
[stable15] take return of mkdir into consideration; photocache to not create a folder for deletion
2019-04-30 15:35:42 +02:00
Morris Jobke
2434b94956
Merge pull request #15139 from nextcloud/backport/15129/stable15
Backport/15129/stable15
2019-04-30 14:56:17 +02:00
Arthur Schiwon
ec9c1e2f52 take return of mkdir into account, throw exception on failure
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-30 07:27:32 +00:00
Roeland Jago Douma
ad5dcc2cd6 Always use a temp file for swift writes
Apparently the if statement doesn't work in all cases (even if I could
not reproduce it). So for the time being we will just not directly
stream to swift.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-24 07:02:46 +00:00
Joas Schilling
54219fb4cd
Use the querybuilder for the queries
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-17 15:33:57 +02:00
Joas Schilling
e77272e3fc
Allow to use Subqueries in from
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-17 15:33:57 +02:00
Roeland Jago Douma
7cbba3e717
Repair step for link shares
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-17 15:33:57 +02:00
Roeland Jago Douma
441e9fefad Block install without CAN_INSTALL file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-15 12:24:12 +00:00
Roeland Jago Douma
792c1a17a1
Do not allow invalid users to be created
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-15 09:04:32 +02:00
Roeland Jago Douma
dc99cc7eab Harden appdata putcontent
If for whatever reason appdata got into a strange state this will at
least propegate up and not make it do boom the next run.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-08 14:36:37 +00:00
Vlastimil Pecinka
7cab488c6f Store user object later in the code
Signed-off-by: Vlastimil Pecinka <pecinka@email.cz>
2019-03-21 21:37:41 +00:00
Morris Jobke
6fffd09a7c
Merge pull request #14759 from nextcloud/backport/14691/stable15
[stable15] always allow moving mountpoints inside the same mountpoint
2019-03-20 16:41:14 +01:00
Morris Jobke
8781a77d37
Merge pull request #14709 from HuemerGroup/groupname_like_username-allow_share_with_both
groupname like username - allow share with both
2019-03-20 16:32:53 +01:00
Morris Jobke
38beea8642
Update lib/private/Share20/Manager.php
tabulator change

Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
2019-03-20 12:51:26 +01:00
Morris Jobke
2a3645a5a8
Update lib/private/Share20/Manager.php
fixed tabulator

Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
2019-03-20 12:50:48 +01:00
Robin Appelman
9b6ead8abf always allow moving mountpoints inside the same mountpoint
even if that mountpoint isn't normally a valid target for moving mounts into

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-20 09:59:17 +00:00
Roeland Jago Douma
086f41b0bc Fix getting the access list on external storage
If a file is on external storage there is no owner. WHich means we can't
check. So just return an empty array then.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-19 17:44:32 +00:00
Christian Aigner
cde8a2896d groupname like username - allow share with both
Signed-off-by: Christian Aigner <christian.aigner@huemer-it.com>
2019-03-15 10:18:27 +01:00
Robin Appelman
54b14946b4 handle long etags from dav external storage
we can only store etags up to 40 characters long in the database, so when we get an etag that's longer we simply hash it to bring down the length

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-14 16:19:09 +00:00
Morris Jobke
144cf16221 Remove sensitive SMB arguments from exception log
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 13:00:57 +00:00
Morris Jobke
42cd3876d4
Merge pull request #14597 from nextcloud/backport/14425/stable15
[stable15] Do not calculate folder size for parent that also needs proper scan, fixes #3524
2019-03-08 17:31:54 +01:00
Ari Selseng
264b4ad3a9 Avoid calculating folder size for parent that needs scan.
Signed-off-by: Ari Selseng <ari@selseng.net>
2019-03-08 08:14:33 +00:00
Marius Blüm
7fa1cfcb17 Remove Google+ from Social Sharing Bundle (2)
Signed-off-by: Marius Blüm <marius@lineone.io>
2019-03-08 08:06:52 +00:00
Roeland Jago Douma
30e790606e Use a tmp file for swift writes
Else this leads to a seekable stream error with chunked uploads

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-06 14:34:15 +00:00