Commit graph

11877 commits

Author SHA1 Message Date
Côme Chilliet
54fc2caf0d
chore: Adapt syntax for PHP<8
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-04-27 10:24:42 +02:00
Côme Chilliet
b2ba4c8d40
fix: Fix type for stable27
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-04-27 10:24:41 +02:00
Côme Chilliet
6d3bba76c9
fix: Reduce the mixups between apptokens and session ids
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-04-27 10:24:27 +02:00
Joas Schilling
85894935a5
fix(comments): Check comment object
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 09:01:43 +01:00
Ferdinand Thiessen
54f81ac0c9
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 14:55:36 +01:00
Ferdinand Thiessen
37166f149e
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 15:24:52 +01:00
Arthur Schiwon
309f6186bc
Merge pull request #44558 from nextcloud/backport/44339/stable23
[stable23] fix(share): use share owner to get ownership
2024-04-24 16:11:28 +02:00
Joas Schilling
80ba4345ec
fix(files): Also skip cross storage move with access control
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 11:38:46 +02:00
Maxence Lange
f9cf7d89c3 fix(share): use share owner to confirm reshare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-28 17:11:47 +00:00
Christoph Wurst
876522204e fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-26 10:17:30 +00:00
Julius Härtl
b65c8c2cea
fix: Throw instead of yielding nothing when listing local directories
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
2024-03-07 15:22:20 +01:00
Côme Chilliet
1fb72e8277 Remove modern PHP syntax, and apply codesniffer fixes in Share20/Manager.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-26 10:42:52 +01:00
Côme Chilliet
0ee5c61eae Use nullsafe call syntax instead of additionnal check
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-02-26 10:42:52 +01:00
Côme Chilliet
603c0d00e4 Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-26 10:42:52 +01:00
Julius Härtl
9642615f52
fix: Only throttle on invalid requests for public share links
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-28 19:43:48 +01:00
Joas Schilling
d4f6fff9ad
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:59:27 +01:00
Arthur Schiwon
d844c956b1
Merge pull request #40321 from nextcloud/fix/supress-statana-warning-memcache
[stable23] fix(caching): suppress static analysis warning for memcaching
2023-09-13 21:56:26 +02:00
Anna Larch
3e895ba0b4 fix(caching): suppress static analysis warning for memcaching
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-07 09:48:54 +02:00
Joas Schilling
0fe4672e43 fix(ratelimit): Only use memory cache backend for redis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 18:40:13 +02:00
Daniel Kesselberg
6ddf1b705f
enh: skip processing for empty response
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-05 10:32:55 +02:00
Joas Schilling
56a23cead4
fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 10:55:13 +02:00
Daniel Kesselberg
cdad27c397
fix: use handleLoginFailed for invalid email address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-10 14:33:19 +02:00
Joas Schilling
9d6a7399a8
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 06:43:42 +02:00
Robin Appelman
9f31a6e127
use source cache when listing folder during recursive copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-19 12:29:37 +02:00
Joas Schilling
060b85c311
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:28:33 +02:00
Joas Schilling
c1f33854e4
Merge pull request #37555 from nextcloud/backport/37542/stable23
[stable23] feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 22:11:33 +02:00
Joas Schilling
fd892cddf1 feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 12:59:11 +00:00
Arthur Schiwon
706504bce3 hide shared files located in group folder's trash bin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-30 16:13:58 +00:00
Daniel Kesselberg
1c333cd1ea chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-17 19:21:22 +01:00
Julien Veyssier
b384a969f5
manual backport of #35057
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-03-15 10:22:38 +01:00
Joas Schilling
3f5ac26413
Fix appconfig compatibility with Oracle DB
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:21:04 +01:00
Joas Schilling
188b6c6611
fix(OCC): Don't throw in the repair step for phone validation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:20:56 +01:00
Joas Schilling
6c87707997 Fix double where() usage in resource manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-24 07:51:53 +00:00
Louis Chemineau
6b6e4a4fa0 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-02 15:30:28 +00:00
Côme Chilliet
6185e326dc
Fix LENGTH function name across databases
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-19 10:12:48 +01:00
Côme Chilliet
6e3cd43903
Use OCTET_LENGTH which is more common than LENGTHB
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-19 10:12:13 +01:00
Côme Chilliet
131a397472
Add octetLength and charLength to function builder, and tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-19 10:10:00 +01:00
Julius Härtl
6fc0e39c5f
Merge pull request #35371 from nextcloud/backport/35250/stable23
[stable23] Properly compare quota against both float/int values
2022-11-24 08:23:54 +01:00
blizzz
d74e2b68a8
Merge pull request #35369 from nextcloud/backport/35353/stable23
[stable23] Update cache when file size === 0
2022-11-23 21:11:23 +01:00
Julius Härtl
48ec3477ee Properly compare quota against both float/int values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-23 17:33:51 +00:00
Louis Chemineau
36243c5cbf Update cache when file size === 0
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-23 15:12:45 +00:00
Joas Schilling
4214458d97 Fix forwarding the object id when searching comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-23 10:42:35 +00:00
Christoph Wurst
9e82dceb66 Fix unsuccessful token login logged as error
The condition of a non-existent login token can happen for concurrent
requests. Admins can not do anything about this. So this is to be
expected to happen occasionally. This event is only bad if none of the
requests is able to re-acquire a session. Luckily this happens rarely.

If a login loop persists an admin can still lower the log level to find
this info. But a default error log level will no longer write those
infos about the failed cookie login of one request.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-22 16:49:31 +00:00
Côme Chilliet
37d849694c
Merge pull request #35144 from nextcloud/backport/34160/stable23
[stable23] Detect weird local ips
2022-11-21 09:33:30 +01:00
Joas Schilling
21f0fde0de
Mark more config values as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-16 10:08:59 +01:00
Julius Härtl
abe243e4b6
Merge pull request #35051 from nextcloud/backport/28610/stable23
[stable23] Use storage filter when fetching previews to cleanup
2022-11-15 19:14:06 +01:00
Côme Chilliet
6bdb5d2804
Pass default values to idn_to_utf8 to fix behavior under PHP 7.3
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 12:11:09 +01:00
Vincent Petry
b43f2b1d52
Merge pull request #35050 from nextcloud/backport/34834/stable23
[stable23] Fix size calculation on copying the skeleton files
2022-11-14 16:41:08 +01:00
Côme Chilliet
96d3d09444
Fix tests for nested v4 in v6
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:27:27 +01:00
Côme Chilliet
be070516a9
Use new dependency to normalize IPs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:26:52 +01:00