upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-26 11:31:13 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
63063 commits 681 branches 1186 tags 7 GiB
Commit graph

154 commits

Author SHA1 Message Date
Roeland Jago Douma
3d0dff0d2b Fix lying docblocks 
* typed the return
* removed unneeded temp variable

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-01 16:48:04 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Roeland Jago Douma
bd8b1786c5 Some psalm fixes in the settings app 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-15 10:00:35 +01:00
Roeland Jago Douma
7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00
Robin Appelman
01118a2218
use the configured forwarded headers for the setup check 
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-12 14:22:27 +01:00
Robin Appelman
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-12 13:32:51 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-12 14:09:13 +01:00
Roeland Jago Douma
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db 
Add setup check to verify that the used DB version is still supported…
 2021-01-11 14:21:42 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm 
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-11 13:14:41 +01:00
Morris Jobke
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-08 13:38:32 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
90d0732828
Fix updating user settings 
The requests dispatched from the personal settings page don't always
send all the possible params but just a subset. Hence requests currently
fail on master e.g. when you update your email. This makes the arguments
optional again.

Regression of da9462b482

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-05 12:59:50 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net 
Unify links to php.net
 2020-12-22 09:53:31 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Julius Härtl
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string 2020-12-09 17:25:59 +01:00
Julius Härtl
8f6c2ec357
Move columns to bigint 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:53 +01:00
Joas Schilling
f648635758
Make the throwing optional, so background tasks don't break 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
46b073d7ce
Add a config for default region of phone numbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
efe79f2937
Validate and standardize the phone number on saving 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Joas Schilling
c2913f18d2
Also return the phone number and twitter handle on the API 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Joas Schilling
da9462b482
Make code strict 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Morris Jobke
fe79a1ad3e
Harden setup check for TLS version if host is not reachable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 13:17:05 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Morris Jobke
a223f603f9
Simplify the check if admin can change password based on encryption status 
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-05 22:20:34 +01:00
Morris Jobke
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 10:06:33 +01:00
nhirokinet
830348dbee
Add SVG support check to setup check 
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
 2020-11-02 11:29:08 +01:00
Morris Jobke
b8ed997238
Remove ISection in favor of IIconSection 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 23:05:00 +01:00
Roeland Jago Douma
28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email 
save email as lower case
 2020-10-27 20:14:43 +01:00
Robin Appelman
cbd6e65678
save email as lower case 
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-10-27 14:56:52 +01:00
timm2k
60efad45cf
Update CheckSetupController.php 2020-10-26 09:42:01 +01:00
Roeland Jago Douma
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2 
Remove setup check for php mail
 2020-10-08 22:40:37 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Daniel Kesselberg
9c8e8007f9
Remove setup check for php mail 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-03 21:58:55 +02:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Roeland Jago Douma
05edd1e5d6
Merge pull request #22890 from nextcloud/techdebt/18680/help-static-code-analysis-understand-code 
Help static code analysis to understand code
 2020-09-17 08:51:20 +02:00
Daniel Kesselberg
096fe20611
Help static code analysis to understand code. 
It adds proper type hints to private namespace to allow private namespace methods.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-09-16 16:37:17 +02:00
Morris Jobke
d3680e682a
Remove not needed semicolon and PHPDoc hint 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 16:18:43 +02:00
Arthur Schiwon
f959828616
emit typed event for user management 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-09-08 22:50:05 +02:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again) 
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-09-07 14:37:44 +02:00
Jan C. Borchardt
4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
 2020-09-07 08:30:01 +02:00
Julius Härtl
7a1748e6f0 Show changelog in apps management 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-09-03 19:16:13 +00:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Joas Schilling
b09620651c
Don't use deprecated getIniWrapper() anymore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-08-20 16:35:38 +02:00
Morris Jobke
da584462d1
Merge pull request #22018 from nextcloud/bugfix/noid/harden-key-generation 
Harden SSE key generation
 2020-08-19 20:42:34 +02:00
Morris Jobke
603d7dab5e
Add setup check that links to the migration documentation 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 15:45:45 +02:00
Julius Härtl
36cfdd320b
Harden key generation 
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-14 07:58:40 +02:00
Daniel Kesselberg
89c6a2bc1f
Add setup checks for php default charset and output buffering. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-26 00:54:16 +02:00
Morris Jobke
7e281a07bb
Use IBootstrap for the app federatedfilesharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-14 16:34:43 +02:00
Morris Jobke
54d36c047b
Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session 
Fix type for $urlGenerator
 2020-07-08 09:06:56 +02:00
Daniel Kesselberg
ba0ef74c06
Fix type for $urlGenerator 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-08 09:06:29 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Joas Schilling
6e46df26a8
Unify settings middleware with others 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-23 20:18:38 +02:00
Roeland Jago Douma
ce7a15e804
Merge pull request #21274 from nextcloud/bug/21268/paswordless-for-everyone 
Enable passwordless for everyone not only admins.
 2020-06-07 15:04:47 +02:00
Daniel Kesselberg
761a7bf6a2
Enable passwordless for everyone not only admins. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-06 21:34:49 +02:00
Joas Schilling
7dcb1cdb42
Remove controller and routes which have no UI component anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-04 10:41:08 +02:00
Arthur Schiwon
653162a709
use the loginname to verify the old password in user password changes 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-05-26 16:53:25 +02:00
GretaD
fce716b905
Fix languages empty array 
Signed-off-by: GretaD <gretadoci@gmail.com>
 2020-05-08 10:03:58 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Roeland Jago Douma
19171d77e2
Merge pull request #19191 from laurisb/patch-1 
Improve Opcache detection
 2020-04-15 11:03:05 +02:00
Roeland Jago Douma
1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods 
Show setup check for recommended php modules
 2020-04-12 15:56:10 +02:00
Christoph Wurst
a7c8d26d31
Add visibility to all properties and move static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:48:31 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Roeland Jago Douma
75836f004d
Show setup check for recommended php modules 
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-10 13:25:12 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id 
Add optional comments reference_id
 2020-04-02 11:34:21 +02:00
Roeland Jago Douma
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19 
Update the license headers for Nextcloud 19
 2020-04-01 12:44:21 +02:00
Roeland Jago Douma
53db05a1f6
Start with webauthn 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-03-31 22:17:07 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Joas Schilling
720dc4e93d
Add optional column oc_comments.reference_id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:15 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Roeland Jago Douma
3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe 
Check the user on remote wipe
 2020-03-24 20:26:52 +01:00
Roeland Jago Douma
b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-23 10:37:08 +01:00
Daniel Kesselberg
73643fe70b
Make sure app_install_overwrite is an array 
otherwise in_array will complain.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-03-16 22:33:47 +01:00
Joas Schilling
9935c71ec3
Check the user on remote wipe 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-16 09:29:28 +01:00
Roeland Jago Douma
c8a360cd7a
Merge pull request #19580 from nextcloud/debt/noid/outdated-check 
Update check for outdated php version.
 2020-03-10 20:10:54 +01:00
Christoph Wurst
d47daefe38
Revive the "send email to new users" toggle for the user form 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-02-28 14:01:03 +01:00
Daniel Kesselberg
f228d73b38
Update check for outdated php version. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-24 20:14:13 +01:00
Daniel Kesselberg
8e8e912015
Make sure quota_preset is using numerical indexes 
If one set quota_present to "default, none, 1 GB, 5 GB, 10 GB" the old implementation will remove default and none but keep the array indexes. Later json_encode will recognize a array with 2 as first index as object and hence quotaPreset.reduce will fail.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-22 20:06:16 +01:00
Lauris Binde
8413a4ec92
Improve Opcache detection 
Improve Opcache detection by checking if extension is loaded, as opcache_get_status() is commonly disabled on shared hosting servers
 2020-01-29 10:44:14 +01:00
Arthur Schiwon
faf18b5f02
apps can have polyamorous relationships with bundles 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-24 12:50:06 +01:00
Christoph Wurst
6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Christoph Wurst
1b46621cd3
Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Joas Schilling
3eee359d7f
Allow to force enable apps via CLI 
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-13 13:06:12 +01:00
Roeland Jago Douma
6ddb789f0d
Merge pull request #18299 from nextcloud/bugfix/noid/filecache_bigint_mounts 
Convert various columns in oc_mounts to bigint
 2019-12-09 21:37:58 +01:00
Daniel Kesselberg
8f403b66d1
Fix Argument 3 passed to OCA\Encryption\Recovery::__construct() must be an instance of OCA\Encryption\KeyManager 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2019-12-09 14:29:22 +01:00
Georg Ehrke
699f3a6817
Convert various columns in oc_mounts to bigint 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2019-12-09 14:13:18 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs 
Some php-cs fixes
 2019-11-25 14:07:00 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Arthur Schiwon
bb1ce203bc
make help available to ordinary users again 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-11-21 12:52:37 +01:00
Roeland Jago Douma
decdb6b40f
Convert more columns to bigint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-20 19:31:17 +01:00
Arthur Schiwon
0a1937208f
Fixes a 500 without userid 
plus cleanup of unused use statements

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-11-16 01:10:19 +01:00
blizzz
75ecae28e6
Merge pull request #17450 from nextcloud/fix/17368/odd-group-numbers 
hide strange Everyone and Disabled group numbers with LDAP
 2019-10-21 11:53:44 +02:00