upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-01 13:00:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
63063 commits 695 branches 1186 tags 7 GiB
Commit graph

20601 commits

Author SHA1 Message Date
Joas Schilling
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper 
Improve JSConfigHelper code quality a bit
 2022-05-31 10:29:30 +02:00
Joas Schilling
cf9660fdf0
Merge pull request #32628 from nextcloud/bugfix/noid/json-throw 
Use JSON_THROW_ON_ERROR instead of custom error handling
 2022-05-31 10:06:21 +02:00
Nextcloud bot
016895d539
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-31 02:33:09 +00:00
Pytal
4873faa951
Merge pull request #32206 from nextcloud/enh/migrator-add-estimatedsize-getter 2022-05-30 17:16:33 -07:00
Côme Chilliet
fa041dabf4 Add the ISizeEstimationMigrator interface for method getExportEstimatedSize 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 17:49:05 +00:00
Julius Härtl
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-30 19:17:49 +02:00
Côme Chilliet
7140201a32
Merge pull request #32634 from nextcloud/debt/noid/psalm-moveable-mount 
[Psalm] Fix docblock for return type
 2022-05-30 17:05:50 +02:00
Carl Schwan
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74 
Update core to PHP 7.4 standard
 2022-05-30 14:37:37 +02:00
Carl Schwan
e86bcc8953
Merge pull request #32655 from nextcloud/fix/handle-non-existing-settings 
Handle non existing settings again
 2022-05-30 12:53:36 +02:00
Joas Schilling
f9efc410fa
Restore old behaviour of sending flase for not found apps 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-30 12:41:35 +02:00
Joas Schilling
eb1a69d627
Improve JSConfigHelper code quality a bit 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-30 12:33:45 +02:00
Carl Schwan
63f589109b Handle non existing settings again 
See https://github.com/nextcloud/server/pull/28189#issuecomment-1140874991

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-30 11:06:55 +02:00
Côme Chilliet
09917b8583 Implement getExportEstimatedSize in migrators 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 07:36:13 +00:00
Côme Chilliet
f20b7e5764 Add a method to get estimated export size in IMigrator 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 07:36:13 +00:00
Nextcloud bot
5a12e8f906
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-29 02:33:23 +00:00
Daniel Kesselberg
f399fd41ec
Fix docblock for return type 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-27 20:05:46 +02:00
Carl Schwan
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event 
Add event to load additional scripts for projects
 2022-05-27 18:36:40 +02:00
Julius Härtl
ac79137816
Merge pull request #32592 from nextcloud/fix/noid/allow-rememberme-token-apache-auth-backend 
allow use of rememberme cookies for IApacheAuth backends
 2022-05-27 17:21:08 +02:00
Git'Fellow
8d876358dd
Move Gd failed operations to debug level 
Instead of error
 2022-05-25 18:26:42 +02:00
Arthur Schiwon
a4a9e7601a
allow use of rememberme cookies for IApacheAuth backends 
- e.g. enables it for SAML backend

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-05-25 13:09:06 +02:00
Nextcloud bot
d32f683ad6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-25 02:36:02 +00:00
Daniel Kesselberg
be99ea969e
Fix type for resource 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-24 22:05:59 +02:00
Daniel Kesselberg
95ec67ecd7
Fix docblock for addFileFromStream 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-24 22:05:59 +02:00
Côme Chilliet
45a75c631e
Merge pull request #32555 from nextcloud/fix/revert-api-break 
Revert api break
 2022-05-24 09:06:00 +02:00
Joas Schilling
53af533853
Merge pull request #32560 from nextcloud/feature/noid/preferences-api 
Add API to change preferences
 2022-05-24 07:58:00 +02:00
Carl Schwan
6147bb611c
Revert api break 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-24 06:59:40 +02:00
Joas Schilling
1d14f08b56
Merge pull request #32554 from nextcloud/followup/32378/adjust-docs-on-interface 
Adjust docs to the same as the implementation
 2022-05-24 06:52:53 +02:00
Nextcloud bot
17bdfb1284
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-24 02:32:52 +00:00
Joas Schilling
31dc9aa682
Add API to change preferences 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 16:44:23 +02:00
Joas Schilling
5b82ad0b30
Create query parameters on correct objects to make debugging easier 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 13:02:36 +02:00
Joas Schilling
be4faebc47
Adjust docs to the same as the implementation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 12:56:47 +02:00
Carl Schwan
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend 
Fix psalm issues related to the user backend
 2022-05-23 11:41:21 +02:00
Christoph Wurst
450136b7cf
Add a helper function that makes it easier to log from anywhere 
Our DI is able to inject a logger implementation to any server and app
class if they want one. However, sometimes DI isn't applicable or hard
to add. In those cases we typically fell back to the *service locator*
pattern where we acquired a logger from the server via a global
variable.

There were some issues with that
* `\OC` is a private class, apps are not supposed to use it
* `\OC::$server` is a global variable, a well known anti-pattern
* `\OC::$server->get(...)` uses the service locator anti-pattern
* `\OC::$server->get(...)` may throw
* `\OC::$server->get(LoggerInterface::class)` is not scoped to an app

With this patch I'm proposing a new helper function ``\OCP\Log\logger``
that can be used to acquire a logger more easily. This function is meant
to be public API and therefore apps may use it and there is an optional
parameter to specifiy the app ID.
The function hides all the ugly details about the global variable and
the potentially thrown exceptions from the user. Therefore it's
guaranteed that you always get a logger instance. In the worst case you
get a noop, though those occasions should be rare.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-05-23 09:53:38 +02:00
Nextcloud bot
74d81655e8
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-23 02:31:03 +00:00
Carl Schwan
b70c6a128f Update core to PHP 7.4 standard 
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-20 22:18:06 +02:00
Carl Schwan
d90583ca28
Merge pull request #32486 from nextcloud/debt/noid/psalm-username 
[Psalm] Rename $userName to $username  to align with child classes
 2022-05-20 18:19:53 +02:00
Carl Schwan
9ec0cb0a90 Fix psalm issues related to the user backend 
- Reflect the actual return value returned by the implementation in the
  the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
  Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
  methods. Also helps with getting rid at some point of the old
  implementActions

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-20 17:14:58 +02:00
Joas Schilling
ad908cd87a
Make appName of TemplateResponse accessible in BeforeTemplateRenderedEvent 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-20 15:03:40 +02:00
Joas Schilling
bc82fa48d1
Merge pull request #32406 from nextcloud/debt/noid/psalm-warning-idbconnection 
[Psalm] Fix spelling for PreConditionNotMetException
 2022-05-20 14:32:33 +02:00
John Molakvoæ
87ce03db1a
Merge pull request #32410 from nextcloud/bugfix/noid/imaginary-exception 2022-05-20 08:14:17 +02:00
Carl Schwan
a5a4e0df1c Fix crop condition 
Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-19 17:25:32 +02:00
Julius Härtl
3742b7392d Add explicit return if getSmallImagePreview fails 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-19 17:01:01 +02:00
Daniel Kesselberg
cf2bc22e0f
Fix return type for createSpecificUser 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-19 14:36:52 +02:00
Daniel Kesselberg
e163b1bb48
Rename userName to username to align with child classes 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-19 14:36:41 +02:00
Nextcloud bot
cdd1793efd
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-19 02:32:23 +00:00
Carl Schwan
1b60f304c2
Merge pull request #32451 from nextcloud/fix/cropped-image-when-not-asked 
Fix cropped image generated when not asked
 2022-05-18 16:08:58 +02:00
Simon L
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags 
Files: Extend search to also cover tags
 2022-05-18 10:58:02 +02:00
Marcel Klehr
f755ee0868 Files: Extend search to also cover tags 
fixes #326

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2022-05-17 21:05:09 +02:00
Thomas Citharel
28b0da59ce
Fix a doctype in OCP for IAddressBook 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2022-05-17 15:09:49 +02:00
Côme Chilliet
a4f23b17a9
Merge pull request #32404 from nextcloud/debt/noid/psalm-warning-iaddressbook 
[Psalm] Drop redundanten return comment
 2022-05-17 14:17:43 +02:00
Robin Appelman
83f831c263
Merge pull request #32427 from nextcloud/boot-event-ordering 
reorder startup events to fix overlapping
 2022-05-17 11:55:00 +00:00
Carl Schwan
05bf8b4445 Fix cropped image generated when not asked 
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-17 10:19:54 +02:00
Louis
8ed92ad4f7
Merge pull request #32216 from SUNET/master 
Respect user settings in php.ini if they are big enough
 2022-05-17 10:14:56 +02:00
John Molakvoæ
9e18a3be2d
Merge pull request #32405 from nextcloud/debt/noid/psalm-warning-isearchrequest 2022-05-17 08:29:32 +02:00
Thomas Citharel
4d26a9afa0
Allow to tweak default scopes for accounts 
Close #6582

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2022-05-16 22:54:51 +02:00
Julius Härtl
778db45631
Merge pull request #32357 from nextcloud/user-delete-remove-wrappers 
remove storage wrappers when deleting the user storage
 2022-05-16 19:08:35 +02:00
Julius Härtl
795a13a888
Merge pull request #32412 from nextcloud/bugfix/noid/maintenance-script 
Properly import maintenance script
 2022-05-16 19:04:56 +02:00
Carl Schwan
03c46cf115
Merge pull request #32413 from nextcloud/fix/psalm-oc-legacy 
Fix psalm errors from the end of the baseline file
 2022-05-16 18:30:09 +02:00
Joas Schilling
a6ca9d592d
Revert "Remove call to already default php.ini values" 2022-05-16 15:54:18 +02:00
Robin Appelman
a67bf03ac0
reorder startup events to fix overlapping 
current the `request` and `runtime` events overlap with the `init` event which makes it hard to create usefull visualizations.

this reorders things a bit to remove an overlap

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-16 13:26:38 +02:00
Robin Appelman
e700c3cd33
Merge pull request #32382 from nextcloud/event-logger-log-minimum 
only log diagnostic events if a treshhold is set
 2022-05-16 09:52:23 +00:00
Joas Schilling
fd576b568c
Merge pull request #32305 from nextcloud/bugfix/32302/fix-browser-agent-trimming 
Fix user agent trimming on installation
 2022-05-16 11:20:46 +02:00
Carl Schwan
53169890d6 Fix psalm errors fron the end of the baseline file 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-16 10:58:26 +02:00
Micke Nordin
0ace1831f4
Fix suggestions by @artonage 
Signed-off-by: Micke Nordin <kano@sunet.se>
 2022-05-16 10:15:45 +02:00
Julius Härtl
d3acf8203d
Properly import maintenance script 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-16 09:28:15 +02:00
Daniel Kesselberg
00b9e576b4
Fix spelling for PreConditionNotMetException 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-15 22:05:55 +02:00
Daniel Kesselberg
f43df2b917
Fix spelling for return type 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-15 22:03:28 +02:00
Daniel Kesselberg
c65952a5e8
Drop redundanten return comment 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-15 21:57:50 +02:00
John Molakvoæ
85758a4f70
Merge pull request #31662 from nextcloud/modernize-contactmenu 2022-05-13 20:14:31 +02:00
John Molakvoæ
20a648ed95
Merge pull request #32384 from nextcloud/improve-psalm-server-get 2022-05-13 20:13:58 +02:00
John Molakvoæ
aff37408a6
Merge pull request #32261 from nextcloud/feat/remove-scss-support 2022-05-13 17:28:40 +02:00
John Molakvoæ
9de0e77ee0
Merge pull request #32376 from nextcloud/debt/noid/fix-psalm-warning-for-zip-response 2022-05-13 16:26:45 +02:00
Carl Schwan
7f899b3bc8 Improve psalm annotation to make it stricter 
Now using class-string<T> as input will only return T, and any other
string will return mixed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-13 16:14:01 +02:00
John Molakvoæ
73918b8af9
Cleanup and compile 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-05-13 16:13:00 +02:00
John Molakvoæ
9a9409e315
Remove SCSSCacher 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-05-13 16:10:45 +02:00
Daniel Kesselberg
7cd356ee7d
Fix psalm warning for zip response due wrong type 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-13 15:50:26 +02:00
Robin Appelman
eda997f2bd
only log diagnostic events if a treshhold is set 
this prevents log spam and it's rare that you actually want to very short events logged anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-13 15:15:26 +02:00
Carl Schwan
9fcf531154
Merge pull request #30863 from nextcloud/performance/saving-user-profile-info 
Minor optimizations for saving user personal information
 2022-05-13 12:56:39 +02:00
John Molakvoæ
fe33e9c08c
Merge pull request #32250 from nextcloud/cleanup/cappedmemorycache 2022-05-13 08:27:28 +02:00
Carl Schwan
eef973e85b Minor optimizations for saving user personal information 
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition

* Make createCard not check if an card exists if we already checked
  previously. We also don't try to get the card if the user is disabled
  as we don't use the card in this case

We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
 2022-05-12 21:02:52 +02:00
Carl Schwan
eb45a6ca40
Merge pull request #32008 from nextcloud/fix/getSize-bool 
Fix Call to a member function getSize() on bool
 2022-05-12 21:00:27 +02:00
Carl Schwan
febbd21814
Merge pull request #32335 from nextcloud/storage-info-dont-unjail 
Don't unjail the path when getting the storage info
 2022-05-12 20:59:06 +02:00
Carl Schwan
5c84d3781e
Merge pull request #32185 from nextcloud/fix/default-share-provider-oracle 
Fix getting shares in a folder on Oracle
 2022-05-12 20:58:05 +02:00
Carl Schwan
23771f0587
Merge pull request #32077 from nextcloud/cleanup/lock 
Cleanup lock related code
 2022-05-12 20:57:38 +02:00
Thomas Citharel
232322fe06
Modernize contacts menu 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2022-05-12 18:31:59 +02:00
Carl Schwan
1c97611fa2 Fix Call to a member function getSize() on bool 
getFileInfo might return false, handle this case by ignoring the result

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:11:46 +02:00
Carl Schwan
fcae6a68c3 Cleanup lock related code 
- Port to QueryBuilder
- Improve the doc a bit
- Add type hinting

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:09:58 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Carl Schwan
81500bf837 Fix getting shares in a folder on Orache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:03:25 +02:00
Robin Appelman
5d69343efa
remove storage wrappers when deleting the user storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-12 14:40:20 +02:00
Vincent Petry
01dbd22c9c
Validate requested length is random string generator 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-05-12 13:58:18 +02:00
Joas Schilling
7d218bfb0a
Merge pull request #32344 from nextcloud/fix/always-free-db-result-qbmapper-find-entities 
Always free the DB result in QBMapper::findEntities
 2022-05-12 11:05:03 +02:00
Julius Härtl
9a6869943e
Introduce event for loading additional script on projects 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-12 10:50:13 +02:00
Carl Schwan
fc1db22629
Merge pull request #32339 from nextcloud/appdatafactory-public 
Make it possible to get the appdata folder using the public API
 2022-05-12 10:45:38 +02:00
John Molakvoæ
be49f79503
Merge pull request #32278 from nextcloud/remove-default-php 2022-05-12 10:05:46 +02:00
Christoph Wurst
1cd05a06fa
Always free the DB result in QBMapper::findEntities 
Without this patch it only happened if the code ran through without any
errors. Now the result is also freed in the case of an error.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-05-12 09:51:37 +02:00
Carl Schwan
a392cd70fb Make it possible to get the appdata folder using the public API 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-11 23:28:37 +02:00
Joas Schilling
d18a293ee5
Add talk-poll to the ROS definitions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-11 14:37:26 +02:00
Robin Appelman
643ef06efc
don't unjail the path when getting the storage info 
the original reason for adding it no longer exist.

This was added with #30985 since then the share source storage was also used, however this was changed with #32076

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-11 11:42:13 +02:00
John Molakvoæ
5a0b28d603
Merge pull request #32326 from nextcloud/fix/icons-cacher 2022-05-11 09:28:58 +02:00