Commit graph

14060 commits

Author SHA1 Message Date
Côme Chilliet
c999fea57c fix: Remove call to non-existing method in 28 and add missing use in test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-19 10:33:11 +02:00
Côme Chilliet
2e05ae2ffc fix: Remove shares only if there are no more common groups between users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-19 10:33:11 +02:00
Louis Chemineau
6b1266a49e fix(files_sharing): Delete user shares if needed when user is removed from a group
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-19 10:33:11 +02:00
Robin Appelman
d78f7acfd7
Merge pull request #47081 from nextcloud/backport/47038/stable28
[stable28] fix: check for correct storage class when checking for link parent
2024-08-08 15:55:42 +02:00
Côme Chilliet
a59176b7dc fix(encryption): Fix mountpoint check to accept if several are found
There is no strong requirement to have only one mount for a given
 storage id. Also the error in this case would be misleading.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-07 18:59:42 +00:00
Robin Appelman
f741191d25 fix: check for correct storage class when checking for link parent
fixes #39123

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-07 20:56:18 +02:00
Andy Scherzinger
8e5956ea6a
Merge pull request #47079 from nextcloud/backport/38364/stable28
[stable28] fix(previews): Don't crash on animated WEBP images
2024-08-07 10:34:57 +02:00
Josh Richards
2c58184b85 fix(previews): Don't crash on animated WEBP images
Fixes #30029 and #37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-08-06 16:07:24 +00:00
Ferdinand Thiessen
7ad057ef94 fix: Ensure database connection is setup when getting group details
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 15:54:40 +00:00
Ferdinand Thiessen
e102c752f9 fix: OCP\Files\Node\Folder::search was not setting the owner
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 11:05:22 +00:00
Andy Scherzinger
c8961c7160
Merge pull request #46763 from nextcloud/backport/46672/stable28
[stable28] Avoid using partial file info as valid one
2024-07-28 12:14:48 +02:00
John Molakvoæ
f4b4485cdc
Merge pull request #46712 from nextcloud/backport/45353/stable28 2024-07-27 16:12:15 +02:00
Andy Scherzinger
9c94775260
Merge pull request #46668 from nextcloud/backport/46640/stable28
[stable28] fix(Token): take over scope in token refresh with login by cookie
2024-07-25 19:43:16 +02:00
Andy Scherzinger
f02bbf8eb6
Merge pull request #46678 from nextcloud/backport/44295/stable28
[stable28] Allow injecting the user temporarily for direct editing
2024-07-25 19:41:20 +02:00
Julius Härtl
ce6768027e fix: Do not return partial file info if we have a cache entry
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-25 17:40:12 +00:00
Andy Scherzinger
942a91916a
Merge pull request #46683 from nextcloud/backport/46674/stable28
[stable28] feat: add config flag to toggle persistent redis connections
2024-07-25 19:39:20 +02:00
Robin Appelman
bd28c9f70e
feat: add additional logging for database errors
including the stack trace of the current database transaction

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-25 14:51:03 +02:00
Hoang Pham
da0353dc6a feat: support excalidraw file
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
2024-07-25 16:59:25 +07:00
Hoang Pham
b3143bf930 feat: support excalidraw file
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
2024-07-25 16:59:24 +07:00
Ferdinand Thiessen
1f1d625212 fix: FileInfo from View should have the correct name of a mountpoint
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-24 13:25:05 +00:00
Robin Appelman
7c33e5c00f feat: add config flag to toggle persistent redis connections
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-22 13:08:39 +00:00
Joas Schilling
be5d40e3e2
fix(logging): Restore the option to log with debug level
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-22 14:45:44 +02:00
Julius Härtl
1c75c5f1e0 fix: Implement option to temporarily set the user session
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 12:44:21 +00:00
Julius Härtl
f413e80fed fix: Do not use incognito mode for direct editing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 12:44:21 +00:00
Joas Schilling
03a08e3863
Merge pull request #46628 from nextcloud/backport/46419/stable28
[stable28] fix(mail): Fix big logos in mail templates for Outlook
2024-07-22 09:00:11 +02:00
Arthur Schiwon
79dcb5ae76 fix(Token): take over scope in token refresh with login by cookie
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-22 06:53:35 +00:00
Git'Fellow
3aef5ac05c
Merge pull request #46577 from nextcloud/backport/46555/stable28
[stable28] fix(appstore): Return an empty array in case of fail
2024-07-19 17:52:02 +02:00
Git'Fellow
62e45de6c5
Merge pull request #46520 from nextcloud/backport/46475/stable28
[stable28] fix(redis): Require version >=4 for unlink
2024-07-19 17:49:13 +02:00
Anupam Kumar
aa66e16699 fix(TextProcessing): use error instead of info for exception logging
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-07-19 12:02:25 +00:00
Joas Schilling
b087e140e6
fix(mail): Fix big logos in mail templates for Outlook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 10:11:43 +02:00
Git'Fellow
e4a67f271e chore: add warning in case of failure
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-17 10:34:43 +00:00
Git'Fellow
803bc2cfc4 fix(appstore): Return an empty array in case of fail
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-17 10:34:43 +00:00
Git'Fellow
73913936ff fix(redis): Require version >=4 for unlink
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-15 07:55:45 +00:00
Arthur Schiwon
f5866137ad fix(Session): avoid race conditions on clustered setups
- re-stablishes old behaviour with cache to return null instead of throwing
  an InvalidTokenException when the token is cached as non-existing
- token invalidation and re-generation are bundled in a DB transaction now

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-11 07:27:29 +00:00
Joas Schilling
ef5249bb64
Merge pull request #46394 from nextcloud/backport/46320/stable28
[stable28] perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP
2024-07-11 09:19:11 +02:00
Andy Scherzinger
242770089e
Merge pull request #46067 from nextcloud/backport/45877/stable28
[stable28] fix: don't use custom certificate bundle if no customer certificates are configured
2024-07-10 22:27:14 +02:00
Andy Scherzinger
e57dd34846
Merge pull request #45920 from nextcloud/backport/45582/stable28
[stable28] delete background jobs by id when cleaning up
2024-07-10 22:26:43 +02:00
Julius Härtl
9974f0b722 perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP
By default there is a Pragma: no-cache header set due to the default
value `no-cache` of session.cache-limiter, which will cause Chrome and
iOS to not cache even with a different Cache-Control header set on the
response.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-10 09:55:28 +00:00
Git'Fellow
936de57201
Merge pull request #46297 from nextcloud/backport/46174/stable28
[stable28] fix(IntegrityCheck): Ensure the check is run if no results are available
2024-07-09 18:22:31 +02:00
Git'Fellow
18ffec158c fix(s3): Don't wait indefinitely for S3 to return
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-09 07:50:39 +00:00
Daniel Kesselberg
470cfe2dbc
feat: log file id and path when extracting the mp3 cover fails
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-08 11:39:19 +02:00
Ferdinand Thiessen
90d3160185
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-05 12:42:29 +02:00
Louis
dbbbefa408
Merge pull request #46141 from nextcloud/backport/46097/stable28
[stable28] fix(files_sharing): Also set the expiration date timezone during validation
2024-07-01 12:03:23 +02:00
yemkareems
6f9c67d8af fix: removed unused variable and check if tag ids are empty before starting the inserts
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-27 11:39:54 +02:00
yemkareems
f8700e8add fix: filtering tags based on existing tags and doing a transaction around the select and insert
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-27 11:39:54 +02:00
yemkareems
48ab7fce3b fix: do a select in systemtag_object_mapping to see if tag exists already in db. if it does not exist alone insert the same or else do nothing
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-27 11:39:54 +02:00
Louis Chemineau
d7093ed24b fix(files_sharing): Store the expiration date relative to the server's timezone
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-27 11:39:31 +02:00
Arthur Schiwon
f016e7e350 fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION
The scope design requires scopes to be either not specified, or
specified explicitely. Therefore, when setting the
skip-password-validation scope for user authentication from mechanisms
like SAML, we also have to set the filesystem scope, otherwise they will
lack access to the filesystem.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-25 07:39:20 +00:00
Robin Appelman
b86392691e fix: don't use custom certificate bundle if no customer certificates are configured
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-24 09:30:17 +00:00
Robin Appelman
97cdd9b90c fix: set mimetype_version during upgrade to the old version
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-21 11:37:13 +02:00