upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-17 18:00:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
78061 commits 691 branches 1186 tags 6.6 GiB
Commit graph

434 commits

Author SHA1 Message Date
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-05 09:58:11 +01:00
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 09:07:41 +01:00
fenn-cs
227b8462d8 refactor(ShareApiController): Check for null and empty strings with empty() 
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 18:37:42 +01:00
fenn-cs
e2d2a17810 fix(ShareAPI): Send mails for mail shares by default 
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 14:41:07 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Ferdinand Thiessen
e9d590674d
feat(files_sharing): Make ShareController download route use the DAV ZipFolderPlugin 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-28 13:18:34 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
skjnldsv
bb37954abb fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 13:17:42 +02:00
Marcel Klehr
c43353d6e6 fix: Display 'Leave share' instead of 'Delete' 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-06 13:50:52 +02:00
Ferdinand Thiessen
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:47 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-05 21:23:38 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Ferdinand Thiessen
dd58e5290f
feat: Use new password context in sharing API 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-22 19:16:55 +02:00
Andy Scherzinger
f0b658014a
Merge pull request #47070 from nextcloud/circToTeam 
fix(share): Rename Circle to Team
 2024-08-06 23:25:47 +02:00
skjnldsv
db28aa8cd1 fix(files_sharing): show proper share not found error message 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-06 16:25:10 +02:00
Git'Fellow
6002566d92
fix(share): Rename Circle to Team 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-08-06 14:48:07 +02:00
Maxence Lange
b6e3009e12
Merge pull request #47043 from nextcloud/fix/noid/ignore-root-on-inherited-shares 
fix(inherited-shares): ignore top root folder
 2024-08-06 11:08:17 -01:00
skjnldsv
712965daa1 fix(files_sharing): filter out invalid shareWith in sharee API 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-05 20:36:45 +02:00
Maxence Lange
6c4b0dba77 fix(inherited-shares): ignore top root folder 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-05 13:40:53 -01:00
provokateurin
9128a23af1
refactor(files_sharing): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-07-27 22:42:51 +02:00
skjnldsv
43ca07809d fix(files_sharing): file request creation permissions and link copy display 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 19:47:11 +02:00
skjnldsv
bb730a1ee3 fix(files_sharing): remove undesirable translations from ShareAPIController 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-16 08:33:53 +02:00
skjnldsv
df42a10e56 chore(files_sharing): lint & refactor fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
bc5839e5b5 chore(files_sharing): cleanup NewFileRequestDialog vue 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
30f9ef414e fix: psalm, cs, autoloader and lint 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
5ce4bb368f chore(files_sharing): refactor share password mail 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
75ca4944c9 feat(files_sharing): allow mixed values in share attributes and allow storing email arrays 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
c253112cf7 chore(files_sharing): refactor mail handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
d388370c3b feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
443c48aefb feat(files_sharing): add new file request option 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
fenn-cs
6136112be1 docs(ShareApiController): Correct note about expiry date timezone 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-07-01 13:53:18 +01:00
Louis Chemineau
f5fd6c8f08
fix(files_sharing): Store the expiration date relative to the server's timezone 
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-06-26 12:49:42 +02:00
Andy Scherzinger
1e04619675
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 22:53:41 +02:00
fenn-cs
c8a90f04b7 fix(ShareApiClients): Maintain meaning of '' and null for share api clients 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:36:26 +01:00
fenn-cs
59a5b4e0bd fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-23 14:11:33 +01:00
Joas Schilling
490f545006
fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 14:31:45 +02:00
fenn-cs
ec8a0a6267 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:13 +01:00
fenn-cs
9a0913afdc refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:08 +01:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00
Benjamin Gaussorgues
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time 2024-02-26 10:07:41 +01:00
Aragon Gouveia
311d1d2306 fix truncated circleId returned from Share API 2024-02-23 14:43:31 +01:00
Benjamin Gaussorgues
01983d50d4
feat(share): save date and time for expiration 
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-22 11:26:01 +01:00
F. E Noel Nfebe
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger 
chore: Migrate away from OC::$server->getLogger
 2024-02-14 10:47:22 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person 
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2024-02-13 21:06:30 +01:00