Commit graph

24531 commits

Author SHA1 Message Date
Julius Knorr
75381dfe0c
fix: Allow overriding shouldApplyQuota check from child classes
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-10-09 08:25:30 +02:00
Christopher Ng
ea5e27dcd8 fix: Subadmin can access self
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-08 16:24:40 -07:00
Côme Chilliet
f8c987f029
Merge pull request #48613 from nextcloud/feat/add-query-param-to-force-language
feat(l10n): Allow to force language with a query parameter
2024-10-08 16:29:03 +02:00
Côme Chilliet
5a05af05db
feat(l10n): Respect forceLanguage query parameter in more places
Attempt to make L10N Factory consistent with itself when forceLanguage
 query parameter is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-08 15:40:40 +02:00
Kate
614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
Côme Chilliet
1b8949ebac
feat(l10n): Allow to force language with a query parameter
This will be used by support application to always generate the support
 report in english. It may also be used to debug a language, or to
 temporarily show a page in an other language to take a screenshot or to
 share your screen with someone speaking another language.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-08 14:44:03 +02:00
Joas Schilling
e11520e6af
Merge pull request #48603 from nextcloud/bugfix/noid/censor-more-values
fix(logger): Remove more parameters of other methods
2024-10-08 13:49:53 +02:00
provokateurin
b209508d8f
feat(TimedJob): Add debug log about time sensitive jobs with long intervals
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +02:00
provokateurin
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +02:00
Nextcloud bot
d7aff6c150
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-08 00:20:08 +00:00
Joas Schilling
a90921e239
fix(logger): Remove more parameters of other methods
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 21:04:49 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:11:56 +02:00
provokateurin
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:02:27 +02:00
Ferdinand Thiessen
bbb6cb2eb0
Merge pull request #48584 from nextcloud/bugfix/noid/increase-exclude-list
fix(config): Mark more app configs sensitive
2024-10-07 13:14:23 +02:00
Joas Schilling
87acaef73c
fix(command): Make method compatible with upstream class (requires 3rdparty bump)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:25 +02:00
Joas Schilling
fd77bc84d1
fix(command): Make method compatible with upstream class (backportable)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:25 +02:00
Ferdinand Thiessen
02f3c88d73
Merge pull request #48438 from nextcloud/fix/bring-back-zip-event
fix(dav): Emit `BeforeZipCreatedEvent` when creating folder zip archive
2024-10-07 11:58:34 +02:00
Ferdinand Thiessen
3095a92551
Merge pull request #47896 from nextcloud/fix/resiliant-user-removal
fix: Make user removal more resilient
2024-10-07 11:33:07 +02:00
Joas Schilling
c900ef9d8e
fix(config): Mark more app configs sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 10:58:03 +02:00
Nextcloud bot
219cc82ddd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-06 00:21:20 +00:00
Robin Appelman
103b464eea fix: use nc's binary finding logic for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-04 15:56:31 +02:00
Nextcloud bot
53b1bc5eb7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-04 00:20:04 +00:00
Kate
8638a89fca
Merge pull request #48522 from nextcloud/fix/querybuilder/output-columns-aliases 2024-10-03 15:48:10 +02:00
Thomas Citharel
fe0f89c237
feat(preview): add command to cleanup preview folder
When changing preview parameters (size, format, …), one can simply delete the preview folder and run
files:scan-app-data in order to retrigger updated preview recreation because files are absent.

However, that's not possible when using ObjectStorage as primary storage, as there's no concept of
"preview folder".

This command allows to simply delete and recreate the preview folder properly from
Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-10-03 13:41:32 +02:00
Nextcloud bot
6c14c933eb
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-03 00:20:34 +00:00
provokateurin
e445be1202
fix(QueryBuilder): Account for aliases in output columns
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-02 11:55:27 +02:00
Marcel Klehr
d2df0f42f1 fix(TaskProcessing\Manager): Don't provoke PHP notice in setTaskResult
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-10-02 08:38:20 +02:00
Nextcloud bot
17cb6a81fd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-02 00:19:58 +00:00
Julien Veyssier
0e1cb723e8
Merge pull request #48496 from nextcloud/enh/noid/taskprocessing-commands-task-errors
[taskprocessing] Add new command to get a task from a task ID
2024-10-01 23:42:08 +02:00
Daniel
1c1f48830a
Merge pull request #48451 from nextcloud/bug/noid/federated-addressbook-sync-without-localaddressallowed
fix: make federation address book sync work with allow_local_remote_servers = false
2024-10-01 20:41:42 +02:00
Julien Veyssier
14cf5b03ca
feat(taskprocessing): new command to get a task from a task ID, include error_message in list and get commands
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-01 20:30:31 +02:00
Kate
4bfa30620d
Merge pull request #48426 from nextcloud/jtr/fix-45671 2024-10-01 18:19:51 +02:00
Daniel Kesselberg
6be00432b7
chore: always execute parse_url in preventLocalAddress
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-01 18:00:47 +02:00
Kate
26762172f5
Merge pull request #48454 from nextcloud/fix/storage/get-directory-content-return-type 2024-10-01 16:22:16 +02:00
Arthur Schiwon
7f7a3cd45f
Merge pull request #48484 from nextcloud/fwdport/48445/master
fix(Auth): ignore missing token when trying to set password-unconfirm…
2024-10-01 15:47:11 +02:00
Robin Appelman
1bf27e74dd
Merge pull request #48235 from nextcloud/readd-object-store-phpunit
test: re-add object store primary storage phpunit tests
2024-10-01 15:11:10 +02:00
Arthur Schiwon
12d39e818d
fix(Auth): ignore missing token when trying to set password-unconfirmable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-10-01 12:24:20 +02:00
Daniel Kesselberg
fbaa4cc5e0 fix: catch NotPermittedException in Folder.nodeExists
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 19:00:36 +02:00
Daniel Kesselberg
3db20c8b00 docs: Folder.get throws a NotPermittedException exception
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 19:00:36 +02:00
provokateurin
e1998b6b6c
fix(Storage): Fix getDirectoryContent() return type
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-30 16:49:27 +02:00
Daniel
be87dec2d9
Merge pull request #48439 from nextcloud/fix/background-image
fix(theming): Use `AppConfig` for setting background image
2024-09-30 12:42:29 +02:00
Côme Chilliet
6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-30 11:21:42 +02:00
Ferdinand Thiessen
e0c00af3bf
fix(dav): Emit BeforeZipCreatedEvent when creating folder zip archive
This is required to not break behavior on zip download (apps should be able to react to zip download especially for shares).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-29 13:29:04 +02:00
Nextcloud bot
da591eaec3
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-29 00:27:57 +00:00
Ferdinand Thiessen
60083b1b5f
fix(theming): Use AppConfig for setting background image
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 22:44:03 +02:00
Ferdinand Thiessen
a0b2297c53
Merge pull request #48424 from nextcloud/fix/declarative-settings-priority
fix(settings): Sort all settings - incl declarative settings - by priority
2024-09-28 19:45:36 +02:00
Ferdinand Thiessen
b5256181a4
fix(settings): Sort all settings - incl declarative settings - by priority
Previously declarative settings were sorted by priority but behind the "native" settings,
this is now fixed, meaning a declarative setting with higher priority than an `ISetting` will
be correctly rendered before that `ISetting` in the settings list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 14:08:26 +02:00
Ferdinand Thiessen
eb69e89fa5
chore: Drop unused legacy OC_Files
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:40 +02:00
Ferdinand Thiessen
2f66bd5b75
fix: Allow Streamer to specify type in constructor instead of magin UA handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:29 +02:00
ernolf
b4ea146d10 feat(share): make sharelink token length configurable
- ensure unique share token with dynamic length adjustment

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
2024-09-28 08:06:24 +02:00
Nextcloud bot
5140585fbb
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-28 00:20:08 +00:00
Josh
ce51cecb44
fix(config): Suppress error at install time
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-27 17:28:14 -04:00
Robin Appelman
3e12e1e789
fix: rework move into object store to better preserve fileids
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:46:08 +02:00
Robin Appelman
888d06dff9
fix: preserve fileid when moving from objectstore to non-objectstore
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:45:42 +02:00
Robin Appelman
da21acfb3f
fix: ensure source folder is removed from cache when moving to objectstore
otherwise this causes confusion down the line as it's contents will be moved to the new cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:45:42 +02:00
Joas Schilling
234c44a77e
fix(l10n): Fix list of RTL languages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-27 12:50:30 +02:00
Ferdinand Thiessen
d57a2dd465
fix: Skip users that still exist in backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:45 +02:00
Ferdinand Thiessen
16833aff86
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:37 +02:00
provokateurin
227609a954
fix(IStorage): Use false instead of bool intersection type to match implementations
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 18:13:03 +02:00
provokateurin
7cdccd058f
fix(Storage): Fix IStorage return types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 18:13:03 +02:00
provokateurin
35dfc639b3
fix(QueryBuilder): Restrict identifier length to 30 characters due to Oracle limitations
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 08:57:06 +02:00
Nextcloud bot
9a220989dd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-26 00:23:09 +00:00
Joas Schilling
1f188c3048
fix(icons): Document icon requirements for notifications and activities
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-25 16:47:23 +02:00
Côme Chilliet
280f6df66c
Merge pull request #32018 from nextcloud/cleanup/event/trashbin
Port files trashbin events to IEventDispatcher/IEventListener
2024-09-24 17:15:39 +02:00
Richard Steinmetz
19ad13571c
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-24 12:36:09 +02:00
Joas Schilling
12ed773b58
Merge pull request #47349 from nextcloud/feat/31420/bidi-backend-support
Add bidirectional text support - Backend
2024-09-24 11:27:42 +02:00
Côme Chilliet
b80bc81579
chore: Use SPDX headers and property promotion in new files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 18:13:29 +02:00
Carl Schwan
77821f8f3e
feat(trashbin): Port files trashbin events to IEventDispatcher/IEventListener
oc_hooks is deprecated and will at some point be removed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 18:13:21 +02:00
Joas Schilling
7ddad46137
Merge pull request #48268 from nextcloud/debt/noid/ignore-docker-image-lock-file
fix: skip the integrity check for nextcloud-init-sync.lock
2024-09-23 17:48:40 +02:00
Joas Schilling
82566c5479
fix(rtl): Make clear that the direction is based on language
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 17:00:07 +02:00
Joas Schilling
ae06ab5860
fix(rtl): Fix list of RTL languages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 16:59:49 +02:00
ali ghorbani
2b7efd66b6
feat(rtl): Set layout direction based on language
Signed-off-by: ali ghorbani <ghorbani.ali.developer@gmail.com>
2024-09-23 16:59:20 +02:00
Nextcloud bot
a8ee7424ad
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-23 14:52:32 +00:00
Joas Schilling
643e216a25
Merge pull request #48274 from nextcloud/feat/noid/priority-notifications
feat(prioritynotifications): Allow some apps to mark notifications as priority
2024-09-23 16:10:25 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +02:00
Côme Chilliet
eac9255966
chore: use a proper @param tag for IConstructableStorage constructor parameter
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-09-23 11:42:41 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 10:40:38 +02:00
Côme Chilliet
94b0a0e863 fix: Move storage constructor to specific interface
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 09:46:44 +02:00
Joas Schilling
5193579e4f
feat(prioritynotifications): Allow some apps to mark notifications as priority
They will be still send as push during DND.
Apps are currently limited to:
- twofactor_nextcloud_notification to help with login
- spreed which will only set it for pushes in manually picked conversations

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 09:02:48 +02:00
Daniel Kesselberg
6e870c0206
fix: skip the integrity check for nextcloud-init-sync.lock
nextcloud-init-sync.lock is used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time.

Ref: https://github.com/nextcloud/docker/issues/2299.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-22 17:48:43 +02:00
Nextcloud bot
77c1db0cd6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-22 00:20:39 +00:00
Ferdinand Thiessen
59059f6605
Merge pull request #48246 from nextcloud/bug/noid/profile-clear-not-working
fix(profiler): clear command does not work
2024-09-21 12:52:47 +02:00
Nextcloud bot
a33a2e2f9c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-21 00:20:41 +00:00
Andy Scherzinger
3009da3722
Merge pull request #43968 from exi/custom-binary-search-paths
feat: make search path for BinaryFinder customizable.
2024-09-20 19:14:17 +02:00
Git'Fellow
2ba3f7ed5c
Merge pull request #47782 from nextcloud/reworkShareExceptions
fix(l10n): Rephrasing some exceptions to be translated
2024-09-20 18:53:40 +02:00
Git'Fellow
dcbe8da2a6 fix(l10n): Rephrasing some exceptions to be translated
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-20 18:35:11 +02:00
Daniel Kesselberg
4ae10aa7f9
fix(profiler): clear command does not work
- The loop is supposed to delete the files first and then the directories.
- getPathInfo returns a SplFileInfo object for the parent (the folder in our case).
- A non-empty directory cannot be deleted.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-20 18:14:33 +02:00
Reno Reckling
ef7e857881
feat: make search path for BinaryFinder customizable.
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue #43922

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>
2024-09-20 17:00:06 +02:00
Julius Knorr
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +02:00
Ferdinand Thiessen
4ba3d4a31a
Merge pull request #48196 from nextcloud/chore/add-deprecation-date
chore: Add proper deprecation dates where missing
2024-09-20 03:03:12 +02:00
Nextcloud bot
436bd44967
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-20 00:21:13 +00:00
Ferdinand Thiessen
e243cb8b7d
chore: Remove deprecated Share_Helper::generateTarget $exclude parameter
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 00:51:00 +02:00
Ferdinand Thiessen
a8f46af20f
chore: Add proper deprecation dates where missing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 00:46:03 +02:00
Julius Härtl
232c22fcd1 fix(federation): Do not overwrite certificate bundle
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-09-20 00:13:00 +02:00
Ferdinand Thiessen
2a59f4fc95
Merge pull request #48220 from nextcloud/chore/remove-travis
chore: Remove old travis related stuff
2024-09-19 23:26:39 +02:00
Ferdinand Thiessen
7ae7f7fd12
chore: Remove old travis related stuff
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 20:16:29 +02:00
Robin Appelman
47d281865e perf: reuse cache info we already have when moving to object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 19:06:06 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Joas Schilling
086b11f8fb
Merge pull request #47978 from nextcloud/chore/remove-ilogger
chore!: Remove `ILogger` and its friends
2024-09-19 10:58:38 +02:00