Commit graph

675 commits

Author SHA1 Message Date
Ferdinand Thiessen
da32af0185
fix(files): Harden thumbnail endpoint
- Catch all thrown exceptions and handle in such a way you do not get
  information about forbidden files.
- Resepect download permissions of shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 16:56:31 +01:00
Côme Chilliet
f0e10eaeed
fix: Transfer incomming shares first, do not delete non-migratable ones
Canceling the previous add of deletion of invalid shares in
 transferownership because in some cases it deletes valid reshares, if
 incoming shares are not transfered on purpose.
Inverting the order of transfer between incoming and outgoing so that
 reshare can be migrated when incoming shares are transfered.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:41:58 +01:00
Luka Trovic
024f98a8a1
fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:39:44 +01:00
Louis
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos" 2024-12-12 14:28:09 +01:00
Louis Chemineau
3b6920fa81
fix: Copying a live photo to a folder with a conflicting mov file
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:47:57 +01:00
Louis Chemineau
62163890f7
fix: Handle copy of folders containing live photos
We need to recursively look for live photos in the folder,
and then handle them as usual.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:47:57 +01:00
Robin Appelman
ca33a62ec6
fix: smuggle storage id to metadata insert queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 10:35:24 +01:00
provokateurin
a7f5b452d1
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 08:38:58 +01:00
Benjamin Gaussorgues
9fde83cbeb
Merge pull request #48618 from nextcloud/backport/48597/stable30 2024-10-30 14:07:43 +01:00
John Molakvoæ
a9dd34ab35
Merge pull request #48746 from nextcloud/backport/46124/stable30 2024-10-29 11:33:42 +01:00
Maksim Sukharev
d74fdbbf8f fix: add notification icon for transfer ownership
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-17 15:02:48 +02:00
Maksim Sukharev
5eecc0481c fix: do not duplicate existing entity
- this reverts 1e8048abee

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-17 15:02:48 +02:00
Maksim Sukharev
197cdfb480 fix: dismiss notification only after transfer bg job created
- do not create 'denied' notification if bg job exists

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-17 15:02:48 +02:00
Christopher Ng
6090985ca3 refactor: Inject IRootFolder
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 16:16:38 -07:00
Christopher Ng
a7ca1c6289 fix: Fix "Unknown path" error when source user files folder has not been initialized
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 16:16:11 -07:00
Côme Chilliet
3a6d4ae3aa feat(transfer-ownership): Improve verbose output of command
Makes debbuging way easier

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 14:37:49 +02:00
Côme Chilliet
e1317962b0 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 16:02:41 +00:00
Côme Chilliet
7bac8f0fca feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 16:02:41 +00:00
Christopher Ng
83ae86271c perf(files): Do not block files page load with server-side favorites retrieval
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:54:22 -07:00
Louis Chemineau
140b36fcea fix: Backport to 30
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 14:54:14 +02:00
Louis Chemineau
e5a8f996bd chore: Apply php:cs recommendations
Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2024-08-28 14:54:14 +02:00
Robin Appelman
b2645590ce fix: implement sharding compatible cleanup for various bits
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +02:00
Robin Appelman
ddecae894a fix: adjust systemtag orphan cleanup query to work with sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +02:00
Robin Appelman
550072342b fix: make background scan job compatible with sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +02:00
Robin Appelman
13231effd0 perf: improve cleanup of tags/comments
delete entire chunk at once instead of one-by-one

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-19 11:41:41 +00:00
Ferdinand Thiessen
7fec706f68 refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:31:27 +02:00
Christopher Ng
36cf891b7f feat(files): Update openapi
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Christopher Ng
e9083db768 feat(files): Allow specifying path and depth for returned folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Ferdinand Thiessen
4150492ffc
fix(files): When redirecting to a file (internal link) then it should open by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-03 13:53:53 +02:00
Christopher Ng
012e2687ab feat(files): Update openapi spec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
0def7fa71c feat(files): Allow toggling folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
aa4d82d428 feat(files): Implement endpoint to retrieve a user's folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:14:44 -07:00
Kate
13921cab98
Merge pull request #46807 from nextcloud/refactor/files/security-attributes 2024-08-01 15:40:40 +02:00
Julius Härtl
a6d421e767
chore: Remove deprecated legacy search backend
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +02:00
provokateurin
3fde60db85
refactor(files): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:44:01 +02:00
Andy Scherzinger
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id
Avoid using partial file info as valid one
2024-07-25 19:37:30 +02:00
Elizabeth Danzberger
b749a89a33
fix: PHP formatting
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:41 +02:00
Elizabeth Danzberger
efe03ee690
feat: Add support for filling fields to backend components
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Julius Härtl
6c1e896a03 fix: Ignore preview requests for invalid file ids
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 22:32:34 +02:00
Ferdinand Thiessen
0936af9960
feat(files): Allow to configure Windows filename compatibility in the settings
This adds an admin setting to toggle Windows filename compatibility.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-17 16:17:14 +02:00
Ferdinand Thiessen
f4ede27cdb
refactor: Remove deprecated Util function for filename validation to FilenameValidator
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:10 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 19:39:18 +02:00
Ferdinand Thiessen
a229723b8c
feat: Add new forbidden filename options to Capabilities
Allow clients to access the new filename validation options
and make frontend name validation possible.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 13:31:54 +02:00
Benjamin Gaussorgues
ec39228b89
Merge pull request #46059 from nextcloud/perf/remove_useless_session 2024-06-27 11:15:50 +02:00
Joas Schilling
8130968a35
feat(notifications): Migrate server INotifiers to new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 11:56:24 +02:00
Benjamin Gaussorgues
71dffd9b70
perf(session): remove useless session open
`UseSession` isn’t used in theses controllers.
Not using it should avoid a few session locks.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-06-24 10:17:05 +02:00
Louis Chemineau
f7c9ac8b54
fix(files): Rename openFileInfo to fileInfo
And check if openFile is set in the URL before opening a file.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-19 15:38:13 +02:00
Julius Härtl
40a416ba00
perf: Tell browsers to cache storage stats endpoint as it is cached
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-18 23:00:17 +02:00
Ferdinand Thiessen
1550af87cd
fix(files): Properly handle denied ownership transfers
When the receiver denies the transfer the notification handler was missing,
so no notification was created for the transfer owner.

But also the internal notification was created two times:
1. When rejecting the transfer
2. By the reject function when dismissing the notification

This is fixed by only relying on the dismiss function.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-14 17:35:59 +02:00
Ferdinand Thiessen
4bd9bc7b06
feat(files): Use receiving users language for the ownership transfer target folder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 20:19:58 +02:00