Commit graph

7258 commits

Author SHA1 Message Date
Louis Chemineau
9e6cc5737f
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:23 +01:00
Kate
c1cd784c89
Merge pull request #50437 from nextcloud/fix/encoding-wrapper-scanner-stable30 2025-01-29 11:26:23 +01:00
Ferdinand Thiessen
a82a097e6a
fix(TemplateLayout): core is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 08:37:33 +01:00
Ferdinand Thiessen
ef015a99d2
fix: Correctly return app id and app version for core styles and images
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 08:37:33 +01:00
Marcel Klehr
fb7f1631d0
Merge pull request #50418 from nextcloud/backport/50331/stable30
[stable30] fix(taskprocessing): More caching
2025-01-28 23:03:09 +01:00
Ferdinand Thiessen
67e0ef5b72
fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:51:42 +01:00
Marcel Klehr
af8d0aee76 fix(taskprocessing): Fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-27 21:13:16 +01:00
Louis Chemineau
474d93625b fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 18:57:00 +01:00
Dario Mehlich
654034638e fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 15:09:36 +00:00
Josh
4d31d418c2 test: fix periodic Test\Group\DatabaseTest::testSearchGroups failure
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 17:46:56 +00:00
Côme Chilliet
28c885dbf2
fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:08 +01:00
Côme Chilliet
e30cd2f03f
fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:02 +01:00
Côme Chilliet
10c7e100d1
fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:49 +01:00
Côme Chilliet
16decdede7
fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:41:50 +01:00
Luka Trovic
024f98a8a1
fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:39:44 +01:00
Côme Chilliet
2546bc5f59
fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:18 +01:00
John Molakvoæ
00d225aacb
Merge pull request #49165 from nextcloud/backport/48563/stable30 2024-12-12 13:32:37 +01:00
Robin Appelman
c3a2d789f1 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:44 +00:00
Robin Appelman
be7b6a7b1b
test: add some minimal testing for metadata storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 10:35:24 +01:00
Louis Chemineau
d224b3fed2
test:(PasswordConfirmationMiddleware): Fix constructor call
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 13:03:52 +01:00
Christoph Wurst
b385520f21
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:43:47 +01:00
georglauterbach
c97cb962ee fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:45:23 +00:00
Richard Steinmetz
442d036ac9
Merge pull request #49098 from nextcloud/backport/48933/stable30
[stable30] Clear pending two factor tokens also from configuration
2024-11-13 10:47:20 +01:00
yemkareems
3b336466e4
fix: conflicts resolved in apps.php loadDirectory
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-11-13 09:11:43 +05:30
Josh Richards
1fc1543a8b
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-11-13 09:11:17 +05:30
Josh
fa17ed6fb4 fix(tests): Add IpAddressClassifier v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-07 09:30:06 -05:00
Josh
7ff1654ed3 fix(tests): Add RemoteAddress v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-06 08:19:56 +00:00
Daniel Calviño Sánchez
fcefd37a5f fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:50:29 +00:00
Daniel Calviño Sánchez
c7b5c3e02f fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:50:29 +00:00
Joas Schilling
849b205b59 fix(appinfo): Make sure screenshot, author and category are always arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-01 14:48:33 +00:00
Benjamin Gaussorgues
9a7ee321fa
fix(users): improve recently active search
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 10:17:03 +01:00
Robin Appelman
8842fcb003 test: add test for nested jail cross-storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-29 15:02:49 +00:00
yemkareems
07d020b4d5
fix: crypto added manually as expected
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 18:42:47 +05:30
yemkareems
051cc83854 fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:29:20 +00:00
yemkareems
b7e4138886 fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:29:20 +00:00
Joas Schilling
57069e35c7
test(settings): Correctly only return bool for Symfony Input::hasParameterOption calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:55 +02:00
Joas Schilling
decc236f98
fix(message): Fix logic of Mail test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:54 +02:00
Joas Schilling
c71097640a
test: Fix mock creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:53 +02:00
Joas Schilling
498c3dc566 fix(comments): Add test for email mention
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 06:21:01 +00:00
Ferdinand Thiessen
761f7e1f70
Merge pull request #48703 from nextcloud/backport/48673/stable30
[stable30] fix(share): Return empty string if no label is set
2024-10-17 18:25:16 +02:00
Ferdinand Thiessen
dfe8f642cd fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 17:11:16 +00:00
provokateurin
d10330b217
fix(UserTrait): Fix backend initialization
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 21:02:30 +02:00
Ferdinand Thiessen
7dd85e15b9
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:07 +02:00
Benjamin Gaussorgues
8290de3b93
Merge pull request #48077 from nextcloud/backport/47852/stable30 2024-10-02 10:43:41 +02:00
Kate
6949e21c09
Merge pull request #48317 from nextcloud/backport/48307/stable30 2024-09-30 10:24:20 +02:00
Richard Steinmetz
c4ffd84439
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-30 09:11:42 +02:00
Joas Schilling
8cf91a32d8
fix(tests): Fix test selection and run unit tests of DAV and user_status
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-25 08:39:14 +02:00
Louis Chemineau
9a34a6c4c4
fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 18:06:38 +02:00
Kate
ae7241f6c8
Merge pull request #48221 from nextcloud/backport/30/fix_move_on_same_bucket 2024-09-20 10:06:14 +02:00
Côme Chilliet
656e32c6c1 fix(tests): Fix most obvious errors in ObjectStore tests
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-19 18:54:26 +02:00