upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-11 23:04:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 12
58936 commits 687 branches 1182 tags 8.3 GiB
Commit graph

11235 commits

Author SHA1 Message Date
Joas Schilling
7b274fa48c
fix(comments): Check comment object 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-12-11 09:06:59 +01:00
Joas Schilling
2986019408 fix(files): Also skip cross storage move with access control 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-24 09:42:33 +00:00
Christoph Wurst
1ec9961fb5 fix(config): Make sure user keys are strings 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-03-26 10:16:09 +00:00
Joas Schilling
a741a58973
fix(apps): Fix loading info.xml file 
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-20 15:09:02 +02:00
Joas Schilling
6ae4876fe9
fix(middleware): Also abort the request when reaching max delay in afterController 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-15 16:30:52 +02:00
Côme Chilliet
88e1d6bbb7 Make sure that path is normalized and then checked, 
and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-08 11:14:09 +00:00
Robin Appelman
ce5f0cacd1 handle stream wrappers in SeekableHttpStream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-21 15:08:22 +00:00
Christoph Wurst
440b2fef63 Log why the login token can't be used for credentials 
And always pass the exception object to the logger.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-05-19 13:03:07 +00:00
Joas Schilling
17f4160f05 Fix user agent trimming on installation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-16 13:13:36 +00:00
Joas Schilling
efbbdb79df Limit the length of app password names 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-13 18:34:18 +00:00
Joas Schilling
599fdb794e
Make the DB query simpler (as we just deleted all other entries) 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-03-10 14:47:55 +01:00
Joas Schilling
595e1dec73 Allow to disable AuthToken v1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-02-16 10:31:07 +00:00
Côme Chilliet
8f11994537 Always call flush() as getAllKeys() is broken 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-01-27 08:30:20 +00:00
John Molakvoæ
301ecd0fc0
Merge pull request #30660 from nextcloud/backport/29622/stable21 2022-01-20 10:22:22 +01:00
Julius Härtl
b9e3fb02ff
Add hashed attribute column for indexed job existence check 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-01-18 15:16:40 +01:00
Louis
22fcd65717
Merge pull request #30633 from nextcloud/backport/30358/stable21 
[stable21] Reset job disabling timer on adding the job again
 2022-01-17 10:42:59 +01:00
Carl Schwan
396157af18 Fix psalm issues 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 14:16:59 +00:00
Carl Schwan
73e402f715 Add helper method in Wrapper 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 14:16:54 +00:00
John Molakvoæ
6b94630f44
Implement multibucket shift for ObjectStore 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-01-14 08:39:37 +01:00
Carl Schwan
2f10bc14f7
Fix idn emails not working in shares 
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 17:19:28 +01:00
Louis Chemineau
67ccb325ef Update lib/private/BackgroundJob/JobList.php 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-01-12 17:44:33 +01:00
Julius Härtl
04e8861192 Reset job disabling timer on adding the job again 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-01-12 15:14:51 +00:00
Joachim Bauch
3ad763cf18 Prevent loading images that would require too much memory. 
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
 2022-01-11 14:48:27 +00:00
Vincent Petry
79d26e4d7f Fix fail when keys/files folder already exists 
Fixes an issue with transfer ownership in move mode where the folder
"files_encryption/keys/files" already exists.

Instead of failing, its existence is checked before calling mkdir.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-01-11 10:15:40 +00:00
John Molakvoæ
cf46808a7f
Merge pull request #30488 from nextcloud/backport/29780/stable21 2022-01-07 13:11:26 +01:00
MichaIng
768bf3c59a [stable22] Remove iconv from dependencies and tests 
which is not used anymore since: https://github.com/nextcloud/server/pull/29470

Signed-off-by: MichaIng <micha@dietpi.com>
 2022-01-07 10:19:13 +01:00
Joas Schilling
67a43a6ad4
Run migrations fully when reenabling an app 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-07 08:50:31 +01:00
John Molakvoæ
dbdc814e81
Merge pull request #29963 from nextcloud/backport/29951/stable21 2022-01-07 08:48:20 +01:00
John Molakvoæ
064f2615d7
Merge pull request #29325 from nextcloud/backport/28541/stable21 2022-01-07 08:46:22 +01:00
MichaIng
92744f3047
Merge pull request #30248 from nextcloud/backport/30245/stable21 
[stable21] Only wildcard search if enumeration is allowed
 2021-12-20 18:41:53 +01:00
Robin Appelman
f6024a895c
also use case sensitive like when searching in a folder 
this case was missed from https://github.com/nextcloud/server/pull/29080

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-12-14 17:49:48 +01:00
Côme Chilliet
e34ec33199
Avoid assignment in if clause 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-14 11:20:13 +01:00
Côme Chilliet
07997131d3
Fix typing problems in OC_Image 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-14 11:20:13 +01:00
Côme Chilliet
3f10cf8996
Avoid calling image* methods on boolean 
This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-14 11:20:13 +01:00
Louis Chemineau
565da24b4f Fix backport 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2021-12-13 15:36:45 +01:00
Joas Schilling
846929b90d Make psalm more happy 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:22 +00:00
Joas Schilling
9da9a53166 Fix docs to make Psalm happier 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:22 +00:00
Joas Schilling
ae068fb47a Convert strict_search to wildcard property and add psalm docs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:22 +00:00
Joas Schilling
749935e91b Limit more contact searches 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:22 +00:00
Joas Schilling
448ee8e30d Only limit search in the system address book 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:22 +00:00
Joas Schilling
18e665364a Only wildcard search if enumeration is allowed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-13 14:26:21 +00:00
Vincent Petry
65d4d30251 Check resource before closing in encryption wrapper 
In case of error there is no guarantee that $source or $target is set or
is a resource when handling an error.

Without this fix, there's a risk that fclose will fail and the actual
exception will not be thrown, making it impossible to find out about the
root cause.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-12-10 00:10:44 +00:00
Louis
f41c1fffff
Merge pull request #30056 from nextcloud/backport/29735/stable21 
[stable21] find users for background scan one by one
 2021-12-08 18:06:00 +01:00
John Molakvoæ
fda86f8c8c
Merge pull request #29834 from nextcloud/carl/bugfix/file-search-21 2021-12-06 14:51:55 +01:00
Robin Appelman
bd677f6741 background scan the source storage when a background scan on a storage jail is triggered 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-12-02 20:00:45 +00:00
Joas Schilling
cabc6eaec6 Fix log_query config flag 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-02 09:41:33 +00:00
Arthur Schiwon
26c66d210d ensure that factoryClass exisits before instantiation 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-12-01 08:27:56 +00:00
Christoph Wurst
56fb21769f Include previous execption for repair steps that don't exist 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-11-30 12:03:51 +00:00
Christoph Wurst
bb91d5bd69 Let repair step query exceptions bubble up 
And hide the type error caused by a constructor call with missing
arguments.

`new $repairStep();` only works for the rare case that no arguments are
required. Anything else will throw. Then we previously hid the trace of
the more important query exception.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-11-30 12:03:51 +00:00
Christoph Wurst
603d623d54 Interpolate the log message also for logged exceptions 
According to PSR-3 the log message can have placeholders that are
replaced from the context object. Our logger implementation did that for
all PSR-3 logger methods. The only exception was our custom `logException`.

Since PsrLoggerAdapter calls logException when an exception key is
present in the context object, log messages were no longer interpolated.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-11-29 15:55:00 +00:00