Commit graph

2190 commits

Author SHA1 Message Date
Richard Steinmetz
a794f15b1f fix(caldav): event links in shared calendar notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-11 18:44:14 +00:00
Joas Schilling
b3705418f3 fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-10 11:55:30 +00:00
John Molakvoæ
5d962241ca
Merge pull request #45543 from nextcloud/backport/44664/stable29 2024-06-07 12:17:58 +02:00
Daniel Kesselberg
8330825f3e feat(caldav): order the calendar objects by start date for search
Sorting the events by the start date leads to more predictable results for the search API consumers.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-06 12:29:29 +02:00
Daniel Kesselberg
449af33c29 fix(caldav): event search with limit and timerange
Event recurrences are evaluated at runtime because the database only knows the first and last occurrence.

Given, a user created 8 events with a yearly reoccurrence and two for events tomorrow.
The upcoming event widget asks the CalDAV backend for 7 events within the next 14 days.

If limit 7 is applied to the SQL query, we find the 7 events with a yearly reoccurrence and discard the events after evaluating the reoccurrence rules because they are not due within the next 14 days and end up with an empty result even if there are two events to show.

The workaround for search requests with a limit and time range is asking for more row than requested and retrying if we have not reached the limit.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-06 12:29:29 +02:00
Anna Larch
ec94f5499c fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 11:10:03 +00:00
Anna Larch
9bea6eca98 fix(userstatus): catch unique constrain violation on revert
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-29 10:31:14 +02:00
Hamza Mahjoubi
2abfae81cb fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-05-28 10:09:22 +00:00
Anna
d8a29a459c
Merge pull request #45224 from nextcloud/backport/44752/stable29
[stable29] Expose subscription calendars
2024-05-24 16:42:31 +02:00
Anna Larch
21dd449e47 fix(caldav): loop through all events for busy events
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-14 13:35:27 +00:00
Daniel Kesselberg
9faddcd5d8
feat(caldav): expose calendar subscriptions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-08 10:49:21 +02:00
Côme Chilliet
20e378d5e5
Merge pull request #44564 from nextcloud/automated/noid/stable29-update-psalm-baseline
[stable29] Update psalm-baseline.xml
2024-05-06 19:31:16 +02:00
Côme Chilliet
82e593b83b
chore: Fix small psalm errors related to documented return types
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-05-06 18:21:38 +02:00
Joas Schilling
137d4617cb
Merge pull request #45018 from nextcloud/backport/45001/stable29
[stable29] fix(DAV): Migrate known exceptions to Sabre exceptions when copying
2024-05-06 08:16:18 +02:00
Anna Larch
e32ea9ab37 fix(CalDAV): remove UNKNOWN from room / resource consideration
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-04-26 11:20:08 +00:00
Joas Schilling
368769aa5a fix(DAV): Migrate known exceptions to Sabre exceptions when copying
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 16:32:39 +00:00
Louis Chemineau
a97c2131d2 feat(dav): Support multiple scopes in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-04-22 15:28:29 +00:00
Joas Schilling
69a3038086
Merge pull request #44622 from nextcloud/backport/44534/stable29
[stable29] build(deps): bump nextcloud/coding-standard from 1.1.1 to 1.2.1 in /vendor-bin/cs-fixer
2024-04-04 13:07:22 +02:00
Côme Chilliet
cd53e71d80 chore: Improve phpdoc typing to silence psalm errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
ae7105b990 fix(dav): Fix quota check for chunk upload
Do not ignore OC-Total-Length when Content-Length and
 X-Expected-Entity-Length are missing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 15:45:57 +00:00
Robert C. Schaller
fa6e6131ee fix(dav): wrong comparison method between two events
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.

Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
2024-03-25 13:18:58 +01:00
Christoph Wurst
3dea99f42b
fix(dav): Add retention time to sync token cleanup
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 18:37:21 +01:00
Anna
bdd4ac2c17
Merge pull request #44360 from nextcloud/fix/add-exdate-exrule-to-confidential-object
fix(caldav): add EXDATE and EXRULE to confidential object
2024-03-21 14:34:08 +01:00
Hamza
007b54afed
Merge pull request #44376 from nextcloud/fix/dav/acls-shared-addressbook
fix(dav): ACLs for shared addressbooks
2024-03-21 14:33:43 +01:00
Christoph Wurst
b6e1685683
fix(dav): ACLs for shared addressbooks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:50:35 +01:00
Anna Larch
a96f8f7fee fix(caldav): add EXDATE and EXRULE to confidential object
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 10:01:33 +01:00
Côme Chilliet
c1b451ea86
chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:25 +01:00
Côme Chilliet
fa8efd5df8
fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:12 +01:00
Côme Chilliet
443b26761d
fix: Migrate WebDAV endpoint check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 16:20:17 +01:00
Christoph Wurst
f40f962c2e
fix(dav): Add occ command to fix missing caldav sync tokens
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-12 12:44:00 +01:00
Maxence Lange
f4beb95cdc
Merge pull request #42707 from nextcloud/enh/noid/store-file-etag-at-metadata-creation
enh(metadata): store current file etag
2024-03-11 12:46:29 -01:00
Julius Härtl
ca453f5b84
fix: Use proper path when trying to check if a file needs to get copied
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-08 10:02:45 +01:00
Maxence Lange
3fa5e598a8 feat(metadata): get deprecated status using file etag
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-07 12:49:06 -01:00
John Molakvoæ
65a05834cf
Merge pull request #43903 from nextcloud/fix/dav/dirty-address-book-update
fix(dav): Fix atomic addressbook update
2024-03-05 22:00:08 +01:00
Richard Steinmetz
00e0fa48a0
Merge pull request #43904 from nextcloud/fix/dav/dirty-caldav-updates
fix(dav): Fix atomic calendar/subscription updates
2024-03-05 21:44:40 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +01:00
Christoph Wurst
a2fcf50f43
fix(dav): Fix atomic calendar/subscription updates
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-29 09:42:51 +01:00
Christoph Wurst
09031211da
fix(dav): Fix atomic addressbook update
Sabre executes the proppatch callback *after* calling updateAddressbook
and not synchronously. That means the code inside the callback was run
outside a database transaction. This moves the atomic helper into the
callback to create the expected transaction span.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-29 09:27:49 +01:00
Richard Steinmetz
53ef6c5f71
feat(dav): update a principal's schedule-default-calendar-URL
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-28 14:51:10 +01:00
Louis Chemineau
5137757053
fix(dav): Init ViewOnlyPlugin after auth
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-27 09:22:29 +01:00
John Molakvoæ
9eece36235
Merge pull request #39553 from zero0cool0/fix/caldavbackend_getChangesForCalendar 2024-02-23 21:35:43 +01:00
John Molakvoæ
54e6ad6e63
Merge pull request #39750 from nextcloud/Jerome-Herbinet-to-dos-wording-change 2024-02-23 21:30:06 +01:00
John Molakvoæ
b91fb12258
Merge pull request #39214 from shdehnavi/replace_substr_calls_in_dav_app 2024-02-23 21:29:15 +01:00
John Molakvoæ
3cc50790bc
Merge pull request #32466 from nextcloud/fix/skip-dav-migrator 2024-02-23 21:28:53 +01:00
John Molakvoæ
db9fd9439e
Merge pull request #42459 from nextcloud/fix/dav/fallback-realm 2024-02-23 19:42:41 +01:00
Jérôme Herbinet
678c003546 "Taks" to fit calendar wording
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2024-02-23 17:05:56 +01:00
Patrick Fischer
0f16153e4a Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR
Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>
2024-02-23 16:18:01 +01:00
Hamid Dehnavi
7bf31df0bc Refactors "substr" calls to improve code readability
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:54:10 +01:00
Christopher Ng
a770fd8236 Skip instead of throwing on invalid address book migration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-02-23 15:24:46 +01:00