Commit graph

6529 commits

Author SHA1 Message Date
Arthur Schiwon
d5b69c1698
chore: ugly type juggling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-04 23:10:25 +02:00
Artur Neumann
37c017ccad
unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-06-15 13:19:40 +05:45
Joas Schilling
44d7dbb33d
Merge pull request #38276 from nextcloud/backport/38274/stable25
[stable25] fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:31:26 +02:00
Joas Schilling
1131e6fabd
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:25:39 +02:00
Joas Schilling
156d53f010
fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:13:58 +02:00
Ferdinand Thiessen
323afd1f4e fix: Throw NotFoundExceptionInterface to fulfill PSR container interface if class not found
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-05-11 13:03:28 +02:00
Julius Härtl
2e09f075ee
tests: Adapt node related unit tests mocks to required root view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-09 13:00:23 +02:00
Julius Härtl
46e924aa7b
fix: Use proper path when creating node instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-09 13:00:04 +02:00
Vitor Mattos
a597bf347d Cover expire_date with unit tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-05-03 09:14:00 +00:00
Joas Schilling
4b62137a17 feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 12:39:52 +00:00
Christopher Ng
537cc2351d Add label for logo link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-30 00:39:15 +00:00
Daniel Kesselberg
cc1b616f24 chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-16 13:18:28 +01:00
Arthur Schiwon
b8608ee0fd
Merge pull request #36899 from nextcloud/backport/36837
[stable25] fix(SystemTagManager): Truncate overlong tag names
2023-03-15 14:27:10 +01:00
Arthur Schiwon
892a8045ce
Merge pull request #36749 from nextcloud/backport/36689/stable25
[stable25] Change X-Robots-Tag header from "none" to "noindex, nofollow"
2023-03-15 14:23:45 +01:00
Julien Veyssier
a7d1313c14
manual backport of #35057
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-03-15 10:18:38 +01:00
Côme Chilliet
f404122aa8
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-14 16:02:01 +01:00
Simon L
fb594fc6ab
Merge pull request #37003 from nextcloud/backport/36803/stable25
[stable25] [db]: Remove not supported column comments for SQLite
2023-03-07 18:20:56 +01:00
Joas Schilling
ac7df441d5 fix(CI): Fix acceptance test password field selector after @nextcloud/vue lib update
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-07 10:06:52 +00:00
Ferdinand Thiessen
d91f27b0bd tests(db): Add test case to ensure column comments work
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-03-02 11:29:19 +00:00
Marcel Klehr
db9c322b0c fix(SystemTagManager): Truncate overlong tag names
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-28 14:50:17 +01:00
Christoph Wurst
adb4507b2f fix(client-login-flow): Handle missing stateToken gracefully
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-27 16:10:15 +00:00
Christopher Ng
65179836d6 Port user menu to Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit c77998209f)
2023-02-24 12:40:38 -08:00
Simon L
f2885b3378 fix the contacts-menu vcf-contact avatars
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-16 13:12:07 +00:00
MichaIng
b194d8475a Change X-Robots-Tag header from "none" to "noindex, nofollow"
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-16 10:48:40 +00:00
Julius Härtl
9df31d7195 tests(oci): Test where statement on longtext column
Signed-off-by: Julius Härtl <jus@bitgrid.net>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-07 13:15:44 +00:00
Joas Schilling
65e81601d6
fix(CI): Adjust expected result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 07:39:19 +01:00
Joas Schilling
71e17f3a23
Remove failing test that works with mocks only anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 15:15:36 +01:00
Christopher Ng
6c6bce514d Port files sharing selector
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-25 02:33:01 +00:00
Joas Schilling
a49d8a0bd8 Disable unreliable acceptance tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-19 10:43:45 +00:00
Christopher Ng
6f3a0e2e91 Focus trap contacts menu with NcHeaderMenu port
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-18 15:06:57 -08:00
Christoph Wurst
197a2ea1f9 Fix login loop if login CSRF fails and user is not logged in
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 11:04:59 +00:00
Simon L
28b3fbd803 increase preview_max_memory and make it easier to debug
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:46:20 +00:00
John Molakvoæ
1888458476
Fix testing
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-12-21 15:16:46 +01:00
John Molakvoæ
c007a3a670
Fix default primary for user theming
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-12-21 15:13:56 +01:00
Vincent Petry
1aa4a0ec04
Merge pull request #35798 from nextcloud/backport/35780/stable25
[stable25] Fix missing cast of double controller parameters
2022-12-19 12:07:11 +01:00
Vincent Petry
cc9b3fc884
Merge pull request #35668 from nextcloud/backport/35649/stable25
[stable25] Update the unencrypted file size when closing streams
2022-12-16 16:33:21 +01:00
Christoph Wurst
e8619feb18 fix(app framework): Fix missing cast of double controller parameters
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-16 15:28:09 +00:00
Artur Neumann
c8fa04fe62 check if params given to API are really an array
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-16 10:56:04 +00:00
Christopher Ng
bf0af98e09 Lighten default color slightly for increased contrast
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 1c753c2b15)
2022-12-13 23:01:55 +00:00
Joas Schilling
86d0206626 Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-12-09 21:46:23 +00:00
Julius Härtl
7107a3affe Also update the unencrypted size of files when creating them with empty content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-08 09:18:00 +00:00
Carl Schwan
1d33d37bf2 Fix unit tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit 01e2a26749)
2022-12-05 16:10:55 +00:00
Simon L
5137af7293 Revert "[stable25] Fix theming tests"
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-11-28 11:26:18 +01:00
Christopher Ng
143e603d4e [stable25] Fix theming tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-25 00:52:49 +00:00
Christopher Ng
d596900410 Add label to sharing search field
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 01:01:21 +00:00
Joas Schilling
30e72fe180 Increase the fair-use push limit to 1.000 users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-21 10:07:25 +00:00
Joas Schilling
3b427a09f0 Run integration tests on 3rdparty bump
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-11-14 08:52:51 +00:00
Christoph Wurst
f2cc09fef1 Fix PublicKeyTokenProviderTest import and mock
* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-11 09:34:59 +00:00
Vincent Petry
4127f33f4e
Merge pull request #34946 from nextcloud/backport/34804/stable25
[stable25] Skip general login with email for non-valid addresses and LDAP
2022-11-04 17:13:06 +01:00
Christoph Wurst
b8ad0752fa Run session token renewals in a database transaction
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token

If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-03 15:25:34 +00:00