Commit graph

1576 commits

Author SHA1 Message Date
Robin Appelman
79e7c48144 fix: ensure parent folder exists when writing a file to object storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:53 +02:00
Robin Appelman
671170a269 fix: verify that parent exists in cache when inserting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:45 +02:00
Robin Appelman
48cd657d26 fix: fix object store id for test object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:41 +02:00
Robin Appelman
6683711516 fix: cleanup objectstore file_put_content
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:34 +02:00
Robin Appelman
f71dce6c9e fix: create intermediate directories for objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:30 +02:00
Robin Appelman
68e82ba0e5 fix: get source file before moving the cache item in objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 17:44:27 +02:00
John Molakvoæ
790ef0ea17 chore: improve hash_file php usage in Local Storage
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-16 15:18:02 +00:00
Louis Chemineau
41111e5f0a fix(files): Ensure that the hash method does not return null
To match beececf660/lib/private/Files/View.php (L1050)

- Fix https://github.com/nextcloud/server/issues/44110

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 15:18:02 +00:00
John Molakvoæ
408c870f61
Merge pull request #47862 from nextcloud/backport/47860/stable29 2024-09-16 11:01:28 +02:00
John Molakvoæ
038eff0b60
Merge pull request #47795 from nextcloud/backport/47756/stable29
[stable29] fix(files): Check if target path is a descendant of the shared folder
2024-09-15 22:17:41 +02:00
John Molakvoæ
21a37d79f1
Merge pull request #47873 from nextcloud/backport/47853/stable29
[stable29] fix: make swift connect exception message more informative
2024-09-15 22:14:49 +02:00
John Molakvoæ
d792bc5a07
Merge pull request #48034 from nextcloud/backport/48016/stable29
[stable29] fix(S3ConfigTrait): Allow proxy field to take false
2024-09-15 22:12:26 +02:00
provokateurin
2cd8582467 fix(S3ConfigTrait): Allow proxy field to take false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 17:18:15 +00:00
provokateurin
789be3c141 fix(Storage\Local): Do not call getSourcePath() on SplFileInfo
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 14:52:42 +00:00
provokateurin
f1817dc82b fix(files): Adjust Cache::searchQuery() parameter name to match interface
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-13 20:12:49 +00:00
Robin Appelman
ab283f7b1b fix: make swift connect exception message more informative
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-10 14:46:21 +00:00
Julius Knorr
4b333e1b40
fix: Only write once to template instead of create/copy
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-10 10:13:04 +02:00
Git'Fellow
01596b54c0 fix(files): Check if the target path is a descendant of the shared folder path
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
2024-09-06 01:59:29 +00:00
Andy Scherzinger
473c9d8249
Merge pull request #47486 from nextcloud/backport/46013/stable29
[stable29] fix: write object to the correct urn when moving from another storage to object store
2024-09-05 16:23:10 +02:00
provokateurin
77c38979c6 fix(files): Create non-existent parents of mountpoints
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-04 18:02:56 +00:00
Robin Appelman
8a539df3a8 fix: write object to the correct urn when moving from another storage to object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-26 12:24:38 +00:00
Robin Appelman
cf2826d1f7 fix: use mountpoint from storage to find the encryption keys
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 14:22:44 +00:00
Robin Appelman
e9fcf6bc9c feat: store the mountpoint of storages in the mount options
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 14:22:44 +00:00
Côme Chilliet
c408c3868c fix(encryption): Fix mountpoint check to accept if several are found
There is no strong requirement to have only one mount for a given
 storage id. Also the error in this case would be misleading.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-07 19:01:35 +00:00
Ferdinand Thiessen
264074c161 fix: OCP\Files\Node\Folder::search was not setting the owner
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 11:06:30 +00:00
Julius Härtl
d76c0d4af6 fix: Do not return partial file info if we have a cache entry
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-29 08:16:30 +02:00
Andy Scherzinger
b1eb1c5a0f
Merge pull request #46679 from nextcloud/backport/44294/stable29
[stable29] fix: Pass the mountpoint target user to storages without owner
2024-07-25 19:40:10 +02:00
Ferdinand Thiessen
824803dd7b fix: FileInfo from View should have the correct name of a mountpoint
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-24 13:26:40 +00:00
Julius Härtl
c60725c813 fix: Pass the mountpoint target user to storages without owner
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 12:51:50 +00:00
Andy Scherzinger
0f332839af
Merge pull request #46035 from nextcloud/backport/46017/stable29
[stable29] fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
2024-07-10 20:32:36 +02:00
Git'Fellow
aa24a4ad5d fix(s3): Don't wait indefinitely for S3 to return
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-09 07:51:43 +00:00
Robin Appelman
bf8a73c539 fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-21 10:29:52 +00:00
Robin Appelman
3e56c3d681 feat: add option to disable scanner transactions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 12:02:53 +00:00
Robin Appelman
d1aac3292a fix: get child ids for folder in a separate query during move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 09:46:42 +00:00
Josh
fcdf453b58 fix(ObjectStore): handle empty S3 hostname
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-06-13 09:37:03 +02:00
Louis Chemineau
b7cd197315 fix(files): Use isRetryable to catch retryable exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-12 08:15:08 +00:00
Git'Fellow
eec6816d49 Try create folder first and check if it exists after
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00
Git'Fellow
75883cb4d9 fix(files): Try to create dir only if it not exists
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00
Ferdinand Thiessen
b3341a17dc
Merge pull request #45158 from nextcloud/backport/45140/stable29
[stable29] fix: fix FileAccess::getByFileId(InStorage)
2024-05-29 10:27:19 +02:00
Git'Fellow
340db5c3d7
Merge pull request #45529 from nextcloud/backport/45014/stable29
[stable29] fix: forbid moving a folder into a subfolder of itself
2024-05-29 10:26:00 +02:00
Josh
413526a688
Merge pull request #45215 from nextcloud/backport/45058/stable29
[stable29] perf(db): Sort data for IN before chunking
2024-05-28 17:04:56 -04:00
Maxence Lange
3f86f4e1ff feat(metadata): migrate to lazy appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-05-27 10:27:49 -04:00
Robin Appelman
4a8eaaf21b fix: forbid moving a folder into a subfolder of itself
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-27 12:33:00 +00:00
Christoph Wurst
9c4d8b3337 perf(db): Sort data for IN before chunking
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-05-25 20:48:55 -04:00
Josh
3fef446b62 fix(Files): Change how scanner diffs for changed metadata
Fixes #43408 

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-05-13 09:07:48 +00:00
Robin Appelman
62e712cb85 fix: fix FileAccess::getByFileId(InStorage)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-02 17:11:34 +00:00
Robin Appelman
cec057799d feat: add option to enable s3 acceleration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-04-26 13:44:59 +00:00
Joas Schilling
0a429e0f80
fix(CI): Suppress psalm UndefinedClass
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-18 09:25:17 +02:00
Joas Schilling
546b0471ed fix(files): Also skip cross storage move with access control
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-17 14:31:50 +00:00
Robin Appelman
6c142a3cd5 fix: use proper jailed patch in watcher
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-04-09 10:41:50 +00:00