Commit graph

306 commits

Author SHA1 Message Date
Ferdinand Thiessen
215b3bbc9d fix(settings): Migrate away from NcAppNavigationCounter
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-01 23:12:06 +02:00
Ferdinand Thiessen
97683a5b66 fix(settings): Migrate away from deprecated NcPopoverMenu
* Replace popover menu with `NcActions`
* Deduplicate user actions code between `UserRow` and `UserRowSimple`
* Fix user action to cover whole row heigh to prevent dropdown from shining through the actions
* Fix user action popover to be overlayed by current edited row actions

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-30 11:38:11 -07:00
julia.kirschenheuter
04d4fb6286 Replace plain input fields with NcTextField fields and NcMultiSelect fields with NcSelect fields
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-06-28 16:55:16 +02:00
John Molakvoæ
cd54f7c7f4
chore: upgrade typescript, eslint and fix lint
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-27 16:16:41 +02:00
Jérôme Herbinet
a07321f093
Add "button" class to the QR code link
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-06-26 14:48:42 +02:00
Johannes
199b9788e6
Merge pull request #38856 from nextcloud/fix/contacts/3404/put-location-in-proper-place
fix(sab): put location in proper address field
2023-06-22 11:51:33 +02:00
Christopher Ng
84ff000767 enh(a11y): New user modal
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-06-21 11:12:40 -07:00
Johannes Merkel
3cb8968808 fix(sab): put location in proper address field
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-06-20 16:18:09 +02:00
Jérôme Herbinet
e25fb29975
Improved display of app links
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-05-30 16:35:45 +02:00
julia.kirschenheuter
94e1a429e5 Revert "Fix table view"
This reverts commit cb852ef6

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-25 11:49:24 +02:00
Varun Patil
ace6df86d8
Fix lint errors
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-23 22:34:15 +02:00
Varun Patil
66a8a9fba1
Use consistent imports for Vue components
This makes tree shaking possible

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-23 22:34:14 +02:00
julia.kirschenheuter
1c90d7faf1 Add label to "default quota" multiselect
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-23 14:12:45 +02:00
Daniel Calviño Sánchez
2c1a1b1779
Disable "Enforce password protection" if not asking for a password
"Enforce password protection" is a subcase of "Always ask for a
password", so it should be disabled if its parent option is unchecked.
Although other dependant options in the sharing settings are fully
hidden instead of just disabled this option is disabled but shown to
avoid confusion when updating from a previous Nextcloud version where
"Always ask for a password" was unchecked and "Enforce password
protection" was checked.

Besides that, due to their dependency the enforced password protection
is now automatically unchecked too if its parent option is unchecked.

Finally, the groups excluded from password requirements are also
disabled when "Always ask for a password" is unchecked, as they might be
still shown if "Enforce password protection" was checked due to an
update from a previous version.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:34 +02:00
Simon L
ed5d8d5c4e address review
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-19 08:29:55 +00:00
Simon L
06d8a03315 migrate a few components to NcSelect
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-19 10:14:39 +02:00
fenn-cs
ec915474f0 Fix add new group event
1ee8fbaad1 broke the addgroup functionality
by not updating the event to reflect the one in
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vue

Resolves : https://github.com/nextcloud/server/issues/38340

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-18 07:49:27 +00:00
fenn-cs
a39f0de237 Use aria-expanded correctly on toggle user actions
The aria-expanded attribute was added on the expandable item rather
Than the button that triggers the expand.

Resolves : #37137

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-17 23:15:15 +00:00
Louis
128cd7030e
Merge pull request #38293 from nextcloud/fix/users-table-alignment
fix(settings): Fix `UserList` styles set to css but scss is used
2023-05-16 09:30:38 +02:00
F. E Noel Nfebe
e7ba25574b
Merge pull request #38202 from nextcloud/fix/37135/addgroup-link-to-button
Convert Add group link to button
2023-05-16 01:23:37 +01:00
Ferdinand Thiessen
02853fdae6 fix(settings): Fix UserList styles set to css but scss is used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-16 00:55:03 +02:00
fenn-cs
1ee8fbaad1 Convert Add group link to button
The "Add group" peforms an on-page action and does not route or link to
anywhere else hence, not semantically a link but a button.

This commit implements the ehancement described at the respository level.

A change would be required in [@nextcloud/nextcloud-vue](https://github.com/nextcloud/nextcloud-vue/issues/4108)
since the `NcAppNavigationNewItem` is an out-of-repo dependency.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-05-14 01:01:12 +01:00
Simon L
f5e8268ced Use the color-primary-element* variables
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-13 10:15:33 +00:00
Christoph Wurst
1381c4c157
feat(users): Store and load a user's manager
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 13:56:48 +02:00
Julia Kirschenheuter
0d3df2c795
Merge pull request #37870 from nextcloud/fix/36921-fix-table-for-users-app
Fix table view
2023-05-12 09:33:34 +02:00
julia.kirschenheuter
cb852ef63b Fix table view
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-11 16:36:37 +02:00
julia.kirschenheuter
b54afad28e Add autocomplete attrs to input fields
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-11 10:16:28 +02:00
Pytal
83ed1fb004
Merge pull request #38163 from nextcloud/show-loading-spinner-until-share-settings-are-fully-loaded 2023-05-10 17:20:56 -07:00
Daniel Calviño Sánchez
b677d3e27d Show loading spinner until share settings are fully loaded
The inputs of the sharing settings are generated in a template in the
server, but the listeners to react to changes in the elements and save
the values in the server are loaded in the client once the DOM finishes
loading. If the DOM takes long to load the user can start to interact
with the settings before the listeners were set up and, therefore, the
changes would not be saved in the server. However, as the inputs are
modified the user would think that the changes were already saved.

To address that now when the sharing settings are open a loading spinner
is shown instead of the contents of the sharing settings, and only once
the listeners to save the changes were set up the spinner is removed and
the contents shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-10 03:00:37 +02:00
julia.kirschenheuter
da36d19580 Add hidden labels for inputs while editing user row
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-09 12:48:15 +02:00
Ferdinand Thiessen
6f798b7dee fix(settings): Increase "Edit your profile visibility button" contrast
Before this the contrast of the button was too low in terms of accessibility.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-02 18:10:15 +00:00
Joas Schilling
58a4861390
fix(settings): Fix title of profile scope options
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 12:23:51 +02:00
Simon L
1ef23e7708 Allow images of any size as profile pictures
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-17 17:18:00 +00:00
Christopher Ng
7bc8b543be Improve handling of profile fields
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-30 17:11:41 -07:00
julia.kirschenheuter
85feae6d82 Create <h3> headings for profile page. Replace <label> which have no conncted <input> with <h3> heading
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-24 08:49:19 +01:00
Valdnet
47a989e15f l10n: Change name of app to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-23 15:01:45 +01:00
John Molakvoæ
ad6dcea779
chore(eslint): replace node/no-extraneous-import by n/no-extraneous-import
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-03-23 08:14:19 +01:00
John Molakvoæ
8633f13e0a
chore(eslint): fix missing import extensions
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-03-23 08:14:19 +01:00
Louis Chemineau
45c8a829c0 Add underline decoration to links and use div element as target
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-03-09 15:17:18 +01:00
Simon L
e6a81a692a add a direct link from files settings to app-token-settings
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-03-09 11:26:09 +00:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +01:00
Christopher Ng
db5d5c1705 Port admin delegation selects
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-28 16:08:11 -08:00
Christopher Ng
4b867bb7bb Port profile visibility select
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-06 17:34:12 -08:00
Christoph Wurst
84780ffd33
fix(user-management): Fix deleting user in hidden group(s)
E.g. guest_users

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-03 09:24:48 +01:00
Christopher Ng
edcf675e6e Drop vue-clipboard2 to fix copy to clipboard
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-01 15:40:13 -08:00
Simon L
e46daa8540 don't translate a variable
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-24 10:31:07 +00:00
julia.kirschenheuter
6d13916a5f Correct title for button on federation actions button
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-18 15:45:07 +01:00
julia.kirschenheuter
087f445499 Replace custom tooltips with native tooltips
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-11 14:22:47 +01:00
julia.kirschenheuter
1935828941 Replace custom tooltips with native ones in users page
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-11 10:07:22 +01:00
julia.kirschenheuter
36b2f6c12e Replace custom tooltips with native ones in apps page
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-10 14:25:05 +01:00