Commit graph

471 commits

Author SHA1 Message Date
nfebe
148fdbf6e3 feat: Use redundant label for accessibility only
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-25 12:04:19 +01:00
nfebe
5ee354f155 feat: Only show show inherited shares section if present
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
nfebe
14573fc96c feat: Improve create link texts
Use `Create public link` for first link share creation

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
nfebe
33eaf9ca4d feat(files_sharing): Modularize SharingInput to adapt with share sections
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
nfebe
ae854e0dd2 refactor(files_sharing): Split internal & external shares
Create two seperate sections for internal and external shares.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:29 +01:00
Thomas Lehmann
fde013b3c7 refactor(files_sharing): move deprecated projects component
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-23 23:36:03 +01:00
Ferdinand Thiessen
b5b28fda16
fix(files): Properly reset all file list filters on view change
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-21 16:38:06 +01:00
Christopher Ng
1a43fc5718 feat(sharing): Toggle custom tokens setting as admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
cdc65b6985 feat(sharing): Make it possible to customize share link tokens
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Ferdinand Thiessen
214a084d92
fix(files_sharing): Remove debounce from expiration date formatting
This should be done as soon as changed, as the value is not passed to
API but needs to be tracked internally (e.g. if you quickly press
"save").

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-15 15:48:22 +01:00
provokateurin
260e82a8c4
fix(files_sharing): Stop overwriting the share expiration date with the default expiration date
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-15 15:48:22 +01:00
skjnldsv
771584f5c1 fix(files_sharing): external share parsing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 12:54:51 +01:00
nfebe
482d4d5ab0 fix(files_sharing): Hide file request if public uploads disabled
The file request creation would error out on creation if public uploads is disabled
so we should not show the option at all.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-20 12:13:32 +01:00
skjnldsv
21e6c5c6f5 fix(files_sharing): also submit new share on password submit
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 10:25:32 +01:00
nfebe
9e734435ba fix(files_sharing): Correct property enforced property names
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-11 11:55:30 +01:00
provokateurin
f2898df23d fix(SharingEntryQuickShareSelect): Disable quick share select if user can not edit share
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-10 18:47:14 +01:00
provokateurin
1e44c671c8 fix(SharingEntry): Hide edit button if user can not edit share
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-10 18:47:14 +01:00
nfebe
e7dc141fd3 fix(files_sharing): Stop infinite loop blocking link share requests
Fixes infinite loop preventing share link creation requests
from being sent to the backend.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-09 01:40:39 +01:00
Louis Chemineau
d11f3c4c23
fix(files_sharing): List of share type during recipient lookup
ShareType lists both names and ids so Object.entries return too much.

This was also making useless the following condition adding ShareType.Email

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-04 13:37:48 +01:00
nfebe
2034c3e107 fix: Only show share permission if re-sharable
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-03 14:25:15 +01:00
nfebe
d6efc531f6 refactor: Use new ShareType across file_sharing
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-12-03 14:25:15 +01:00
provokateurin
c0db74633a
fix(SharingEntry): Display owner name if the owner is someone else
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
skjnldsv
dd5a344f5e chore: lint fix
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 09:56:30 +01:00
Ferdinand Thiessen
f6e6ba4851 refactor(styles): Adjust code style in SCSS sources to match our stylelint config
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:42:13 +01:00
skjnldsv
bfe8f8af40 fix(dav): file request guest nickname encoding
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 22:38:40 +00:00
fenn-cs
dd6d7a0aab fix(Federation): Show some icon for federated users on shares
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2024-11-09 10:33:17 +01:00
skjnldsv
f29697a7c0 fix(files_sharing): share assignment issue in SharingEntryLink
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 16:41:25 +01:00
fenn-cs
6d3f5d39cd fix(SharingEntryLink): Show default password before create if any
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : https://github.com/nextcloud/server/issues/48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-11-08 10:07:19 +01:00
fenn-cs
0daacbe81d fix(ShareEntryLinkList): Append new links to the end of list
Currently new shares are added to beginning of the share list in the UI
messing up the ordering with the original (first) looking like the most
recent and the most recent looking like the original share. This error
disappears on refresh.

Resolves : https://github.com/nextcloud/server/issues/48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-30 14:56:55 +01:00
Ferdinand Thiessen
abcb02f06e
fix(files_sharing): Password field must not be required if already set
If there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-30 10:30:09 +01:00
skjnldsv
a1ffa84eda fix(files_sharing): federated shares avatar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-10-25 12:18:40 +02:00
Ferdinand Thiessen
8e5b642685 fix(files_sharing): Add correct context to translation
This string is extracted in the `files_sharing` app so it needs to be accessed there and not on `files`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-21 12:46:56 +02:00
rakekniven
d852d6e723
chore(i18n): Improved grammar
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-10-19 11:41:06 +02:00
Ferdinand Thiessen
e8c1e2c611
fix(code-style): Adjust JS code to our code style
This resolves 68 ESLint warnings about invalid code style.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 22:11:59 +02:00
Ferdinand Thiessen
0ccced8664
fix(files_sharing): Add proper user facing messages on success
1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 12:09:53 +02:00
Louis
3f75c4808d
Merge pull request #48653 from nextcloud/rakekniven-patch-2
chore(l10n): Use default plural handling
2024-10-14 11:23:28 +02:00
rakekniven
3b3f0f0ed9 fix(i18n): Improved grammar
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-10-11 20:10:45 +02:00
rakekniven
7ed71dda49 fix(i18n): Improved grammar
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-10-11 20:10:45 +02:00
rakekniven
2496e5db9e
chore(l10n): Use default plural handling
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-10-10 21:51:36 +02:00
Louis Chemineau
2582b6a181 fix: Minor @nc/vue usage errors
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-10-09 19:49:07 +02:00
Ferdinand Thiessen
7d733cfb33 fix(files): Link share URL was not generated due to typo
`toen` vs `token`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 19:55:36 +02:00
Ferdinand Thiessen
085aab24ff
chore: fix usage of deprecated functions and adjust code style
This solves 57 ESLint warnings by replacing deprecated code with `@nextcloud/` libraries,
as well as adding missing type information, importing jQuery instead of relying on global one,
and the same with Moment.js.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 03:30:20 +02:00
Jonas
0e4438fc04
Merge pull request #47841 from nextcloud/fix/files-sharing-openfile
fix(files_sharing): Open single-file-share by default
2024-09-09 16:44:15 +02:00
Grigorii K. Shartsev
9348c1efba fix(files_sharing): add accessible labels in link share creation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 14:58:30 +02:00
Grigorii K. Shartsev
2fea735418 fix(files_sharing): checkbox for password in link share is not shown
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 14:58:30 +02:00
Ferdinand Thiessen
fccb132e2b fix(files_sharing): Open single-file-share by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-09 14:49:21 +02:00
Ferdinand Thiessen
f06fdb04a3
chore(files_sharing): Do not use files source files but directly the library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 16:53:42 +02:00
Ferdinand Thiessen
cb4c569486
fix(files_sharing): Ensure sidebar share entry lists are labelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
1dafdce3e7
fix(files_sharing): Set file-request header for nextcloud/upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
3134053497
fix(files_sharing): Disable sharing status action for public shares
This is disabled to not leak personal information into the public

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00