upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-02 13:31:14 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
79087 commits 698 branches 1186 tags 7.1 GiB
Commit graph

962 commits

Author SHA1 Message Date
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 16:40:50 +01:00
Christopher Ng
42d997bcd7 test: Update tests 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
skjnldsv
5c359e424f feat(federatedfilesharing): auto-accept shares from trusted servers 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-01-09 12:54:51 +01:00
Robin Appelman
e59ebafc87 test: add test for permissions of copied share 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-04 19:19:08 +01:00
Benjamin Gaussorgues
5581f0c7bf
chore: remove legacy action to test remote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-29 11:14:37 +01:00
Côme Chilliet
ae7f9cb3c1
Merge pull request #43025 from nextcloud/bugfix/error-on-reshare-after-transfer-ownership 
fix: update re-share if shared-by user has been revoked
 2024-11-25 18:20:29 +01:00
provokateurin
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Luka Trovic
2ca51919db fix(sharing): add command to fix broken shares after ownership transferring 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2024-11-18 21:24:23 +01:00
skjnldsv
4d9d617c84 feat(files_sharing): use share node or label as page title 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 14:20:58 +01:00
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 09:07:41 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
dependabot[bot]
bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-19 07:57:35 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
provokateurin
1642a34e8a
refactor(files_sharing): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Robin Appelman
f8a59b56b4
test: fix share storage move test with object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-27 14:45:43 +02:00
provokateurin
376d5665bb
fix(files_sharing): Fix all IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:47 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Robin Appelman
21678df4d6
Merge pull request #48200 from nextcloud/share-reminder-sharding 
fix: add sharding compatible version of share reminder job
 2024-09-19 12:50:37 +02:00
Robin Appelman
0bdd25eb0f fix: add sharding compatible version of share reminder job 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-19 11:59:46 +02:00
Joas Schilling
a0cb795f04
Merge pull request #48162 from nextcloud/bugfix/noid/array-keys 
fix(autocomplete): Move known array keys to psalm docs
 2024-09-19 10:25:06 +02:00
Robin Appelman
1ad58d68f3 test: fix ShareControllerTest.php 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Robin Appelman
7661a7e90a test: fix ShareAPIControllerTest.php 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Robin Appelman
1db3d94e1e test: put parent items into cache in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Joas Schilling
0af0bf3d42
fix(autocomplete): Move known array keys to psalm docs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-18 11:40:45 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:36 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
skjnldsv
bb37954abb fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 13:17:42 +02:00
Ferdinand Thiessen
11fdf4e2a7
chore(files_sharing): Remove now unused legacy scripts 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
96c8275586
feat(files_sharing): Migrate public share to use Vue files list 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:42 +02:00
John Molakvoæ
f9fcc5b170
Merge pull request #47412 from Luka-sama/feat/shares-reminder 2024-09-03 17:24:02 +02:00
Stefan Cherniakov
457eaee2b3 fix(files_sharing): Add missing check for null & use bool instead of int for reminder_sent field 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 17:23:31 +02:00
Ferdinand Thiessen
4d2556d4cf
refactor(IMenuAction): Make public menu actions use the new Vue UI 
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-03 16:07:49 +02:00
Stefan Cherniakov
d633b9bce6 fix(files_sharing): Make share reminders more stable & fix issues 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 13:37:17 +02:00
Stefan Cherniakov
5e4a166365 feat(files_sharing): reminder for link shares with expiration date 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 13:37:17 +02:00
Robin Appelman
ddbeb4cac9
test: mark share test cleanup as running across all shards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 10:21:19 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
skjnldsv
f28d933acc feat(files_sharing): add public name prompt for files requests 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 20:15:39 +02:00
Robin Appelman
7046aac7c4
test: update share tests to work with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-16 17:43:06 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
Ferdinand Thiessen
21a0009553
Merge pull request #44967 from nextcloud/perf/sharing-events 
perf(files_sharing): Move events to listener classes and registration instead of boot
 2024-06-10 11:57:53 +02:00
Andy Scherzinger
1e04619675
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 22:53:41 +02:00
Julius Härtl
0ca5c7487a
perf(files_sharing): Move events to listener classes and registration instead of boot 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-05-13 14:24:38 +02:00
fenn-cs
9a0913afdc refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:08 +01:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
339702e376 refactor: make share manager buildable 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 14:33:51 +01:00
Christoph Wurst
5c20f5b9a2
fix(sharing): Avoid (dead)locking during orphan deletion 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-03-05 20:19:30 +01:00