Commit graph

1561 commits

Author SHA1 Message Date
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +01:00
Ferdinand Thiessen
0baab8fd98
test: Reset sharing app config after test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +01:00
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +01:00
Kate
2f862d1fcb
Merge pull request #50221 from nextcloud/add-integration-tests-for-moving-a-file-from-and-to-a-shared-folder 2025-01-27 17:03:04 +01:00
Daniel Calviño Sánchez
b59c71ccf8 test: Add integration tests for moving a file from and to a shared folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-27 14:13:07 +01:00
Joas Schilling
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 12:46:15 +01:00
Ferdinand Thiessen
eea91fa1ba
fix(TemplateLayout): core is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 15:10:23 +01:00
Richard Steinmetz
d3126cd1bb
fix(dav): default calendar and address book not created on first login
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-23 22:02:52 +01:00
skjnldsv
abd3cb60fc fix(files): more conversion tests and translate error messages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-17 18:22:58 +01:00
Arthur Schiwon
2de855f0bc
Merge pull request #50162 from nextcloud/fix/improve-ldap-avatar-handling
Improve ldap avatar handling
2025-01-16 21:43:29 +01:00
skjnldsv
19ce362896 chore: add file conversion integration tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-16 18:55:44 +01:00
Côme Chilliet
a741c6cfa1
chore(psalm): Update baseline to remove fixed errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 17:34:11 +01:00
skjnldsv
669e6cadd6 chore(federation): cleanup SettingsController and legacy AddServerMiddleware
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 15:39:01 +01:00
skjnldsv
b434750cb2 chore(federation): add trusted server auto accept integration tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 12:54:51 +01:00
Stephan Orbaugh
b64b106c13
Merge pull request #49966 from nextcloud/block-dav-move-parent
fix: block moving files to it's own parent with dav
2025-01-07 10:24:06 +01:00
Joas Schilling
8953f44534
Merge pull request #50035 from nextcloud/fix/http/jsonresponse-data-type
fix(HTTP): Adjust JSONResponse data type
2025-01-07 06:39:14 +01:00
Robin Appelman
757076af29
fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-06 14:45:35 +01:00
provokateurin
3624923af2
fix(HTTP): Adjust JSONResponse data type
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-04 00:58:54 +01:00
Robin Appelman
9193cd664e fix: block moving files to it's own parent with dav
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:30:20 +01:00
Joas Schilling
63f3309993
fix(logger): Prevent infinite recursion with log.condition => matches
When we need to check the log condition for a user matches,
there is a risk that something on the way checks the log level
and would result in an infinite loop.
So we simply check if it's a nested call and use the default
warning level in that case.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-03 10:04:51 +01:00
nextcloud-command
ec26a4449c fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-01-01 02:33:07 +00:00
Robin Appelman
7bc8eb3007 chore: update baseline
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-27 15:18:09 +01:00
Benjamin Gaussorgues
22051a73c1
feat(login): add origin check at login
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-05 09:51:53 +01:00
Maxence Lange
f08d053290 fix(ocm): switching to IdentityProof
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 -01:00
Maxence Lange
4591430c9c feat(ocm): signing ocm requests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 -01:00
Daniel Kesselberg
dd3fa88b36
chore: check enums for since and experimental comments
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-12-02 14:30:18 +01:00
Kate
bcb8b85fc6
Merge pull request #49224 from nextcloud/build/psalm/unstable-namespace 2024-11-29 12:01:07 +01:00
Joas Schilling
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data
fix(controller): Fix false booleans in multipart/form-data
2024-11-28 14:46:16 +01:00
Joas Schilling
2b6da9eaee
ci: Remove obsolete baseline entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-28 13:57:24 +01:00
Louis Chemineau
d6fa2100e1
test(ExternalStorage): Send basic auth during integrations tests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:12:29 +01:00
nextcloud-command
6822cf9731 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2024-11-27 02:34:37 +00:00
Daniel Kesselberg
6b383faf41
Revert "fix(dav): Always respond custom error page on exceptions"
This reverts commit 9992e7d439.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-11-22 11:55:25 +01:00
Maxence Lange
65e24f7def feat(user-prefs): IUserPreferences
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 -01:00
Ferdinand Thiessen
9e327a5890
fix(apps-store): Remove apps from force-enabled state when uninstalled
If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-18 14:09:54 +01:00
provokateurin
c179e78aeb
refactor(user_ldap): Remove Application::registerRoutes() usage
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-14 11:43:46 +01:00
Kate
95766246ea
Merge pull request #49244 from nextcloud/feat/profile-app 2024-11-14 11:07:06 +01:00
skjnldsv
158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +01:00
provokateurin
fc0c61458e
test(integration): Correctly cleanup logs
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-14 08:12:20 +01:00
provokateurin
72571a19dd
build(psalm): Configure unstable namespace
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-12 11:46:13 +01:00
dependabot[bot]
8e3f85111d
chore(deps-dev): Bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.15.0 to 3.16.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.15.0...v3.16.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-09 02:09:33 +00:00
Joas Schilling
86784ad873
ci: Bump behat/behat as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-30 09:04:05 +01:00
Joas Schilling
37966c645e
ci: Align integration test dependencies with 3rdaprty/
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-29 22:54:30 +01:00
Ferdinand Thiessen
6d2c63ecff
fix(settings): Do not use null on string parameter for sharing disclaimer
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:12:32 +02:00
provokateurin
f25a71806b
fix(apps): Fix wrong or missing casts
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 17:08:29 +02:00
Joas Schilling
61e3fa054d
build: Show the actual string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-23 09:39:57 +02:00
provokateurin
f660e4c09f
build: Print RTL limited characters in translation-checker
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-22 13:03:06 +02:00
Kate
070adc1131
Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion 2024-10-22 12:47:45 +02:00
Kate
582af10e0b
Merge pull request #48756 from nextcloud/build/autoloader/remove-noisy-changes 2024-10-22 11:20:10 +02:00
provokateurin
e8426996f5
fix(psalm): Fix some newly detected issues
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00