upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-01 21:10:36 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 8
69670 commits 694 branches 1186 tags 7 GiB
Commit graph

378 commits

Author SHA1 Message Date
Joas Schilling
bacf8c61a8 fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-06-11 14:17:57 +01:00
fenn-cs
5d86c407a7 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-06-11 14:17:57 +01:00
fenn-cs
b0d4661a1b refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-06-11 14:17:57 +01:00
fenn-cs
29f717a999 fix(ShareApiClients): Maintain meaning of '' and null for share api clients 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:26:29 +00:00
fenn-cs
bdeba6590d test(Sharing): Integration test for no expiration set date for share 
- Verify that explicitly sending empty `expireDate` param to server overwrite default

and sets not expiry date, if non is enforced.

- Update tests to avoid converting empty string to date.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-25 11:18:41 +01:00
fenn-cs
13688f39a7 fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-24 15:30:49 +01:00
Ferdinand Thiessen
aaa849e491 fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 16:57:31 +00:00
Benjamin Gaussorgues
1b30da153c feat(share): save date and time for expiration 
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-26 09:10:26 +00:00
Benjamin Gaussorgues
ee6a10f8f5
fix(share): use user timezone to parse share expiration date 
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but

D-1 for the server (UTC).

This fix aims to apply the correct offset

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-01-15 11:55:03 +01:00
Maxence Lange
0fac750bcd ocm services 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-22 17:26:02 -01:00
Maxence Lange
3b93a35108 display displayname on federated shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-07-11 09:25:09 -01:00
Louis Chemineau
6b53e4b13a Mutualize expireDate handling when creating and updating a share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-27 16:26:24 +02:00
rakekniven
86b17e2248 Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
rakekniven
eaaeb32074 fix(l10n): Fixed grammar 
Reported at Transifex.
  
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>


Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH 
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
 2023-03-08 16:46:55 +01:00
Julius Härtl
38ca468502
Merge pull request #36515 from nextcloud/fix/sharees-remove-deck 2023-02-16 21:17:16 +01:00
Vincent Petry
1fed799826
Merge pull request #36452 from nextcloud/perf/share-availability-check 
perf(federation): Only request root share info for checking availability
 2023-02-03 13:34:35 +01:00
jld3103
30858df737
Remove Deck from Sharees API 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-02-03 12:01:37 +01:00
Louis Chemineau
4ab3c16403 Pluggable share provider 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-02-02 15:41:26 +01:00
Julius Härtl
7e3ea019d1
chore: Add return types 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:42:33 +01:00
Julius Härtl
7cc9ba28a7
perf(federation): Only request root share info for checking availability 
Otherwise this would request a full recursive dirctory listing while the result is never being used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:41:34 +01:00
Jan-Philipp Litza
a7abe2c35a Honor permissions of new link share via OCS API 
The API currently overrides the supplied permissions with "read only"
when a file is shared via link. It allows to update the permissions
later, however.

This keeps the default to "read only" but honors the permissions
supplied by API call if any.

Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
 2022-12-06 16:00:20 +01:00
Julius Härtl
8629d8e44f
Check share attributes on preview endpoints 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-25 11:35:31 +02:00
Carl Schwan
0de71a73e5
Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing 
Propagate attributes when resharing
 2022-10-20 17:03:02 +02:00
Carl Schwan
54031e370a Fix various other small psalm issues 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:40:35 +02:00
Carl Schwan
60313683e2 Fix checkpassword undocummented null parameter 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:38:21 +02:00
Carl Schwan
c6b8a3bec3 Fix permission not being int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:37:46 +02:00
Carl Schwan
53e408f76a Fix exception getCode type 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:50 +02:00
Carl Schwan
3a11128e6c Fix type when getting appconfig with int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:05 +02:00
Simon L
d967488ec0
Merge pull request #34544 from nextcloud/fix/more-flexible-date-validation 
More flexible date validation
 2022-10-13 01:10:55 +02:00
Carl Schwan
9eb67ad57d More flexible date validation 
Fix #34542

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 23:02:10 +02:00
Carl Schwan
8e3f21d9ed Small progress with fixing unit tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 14:00:15 +02:00
Carl Schwan
cf39885b53 Propagate attributes when resharing 
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-10 17:06:29 +02:00
Roeland Jago Douma
c6e100ed32
type closure to make psalm a bit happier 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2022-10-09 21:41:18 +02:00
tobiasKaminsky
610bbaed68 includeTags -> include_tags 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-28 13:17:56 +00:00
Tobias Kaminsky
5b3fb7a8ff
Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
 2022-09-21 08:28:03 +02:00
tobiasKaminsky
ebd28ef9e0
Show include tags on single share 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-19 11:36:52 +02:00
tobiasKaminsky
4a4a3874da
Add includeTags to /share/id 2022-09-19 11:11:09 +02:00
Carl Schwan
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing 
Only normalize data in public shares and not crud
 2022-09-15 16:43:01 +02:00
Carl Schwan
7ded5a769b
Only normalize data in public shares and not crud 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-08 14:51:28 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Max
99aa938452 feature: first take on using the viewer to render single file shares 
Signed-off-by: Max <max@nextcloud.com>
 2022-08-25 21:59:19 +00:00
Carl Schwan
7b723813ce
Multiple fixes 
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-31 19:37:59 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-28 16:54:13 +02:00
Vincent Petry
bbb5043c07
Inherit hide download from share attributes 
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:54:13 +02:00
Vincent Petry
54a0d8fe64
Don't reset share attributes when not specified 
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:23 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
9493f86de3
Fix share controller to accept share attributes alone 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission 
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Joas Schilling
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2 
l10n: Delete apostrophe
 2022-06-10 15:54:14 +02:00