upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-27 03:50:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
86041 commits 688 branches 1186 tags 7 GiB
Commit graph

195 commits

Author SHA1 Message Date
provokateurin
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-09 10:59:31 +01:00
Carl Schwan
c091ae4098
perf: Replace getById call with getFirstNodeById 
Avoid looking at all the mounts

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-05 12:55:18 +01:00
Kate
a17f4d4eb1
Merge pull request #57575 from nextcloud/carl/typing-share 2026-01-27 13:36:01 +01:00
Carl Schwan
c8989d853c
refactor(IShare): Add typing for node 
This might also improve a bit the performance.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-01-27 11:19:33 +01:00
Git'Fellow
ce9119a708 refactor(shareByMail): Strict types and code simplification 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2026-01-24 19:02:32 +01:00
Maxence Lange
b28176458d fix(contacts): not contact, not local 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-12-22 12:36:33 -01:00
Carl Schwan
a011cb7780
refactor: Rename some variables in external share's manager 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-12-17 10:14:40 +01:00
Carl Schwan
4d47fdaa85 chore: Run rector with new rules for fetch 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-18 17:45:57 +01:00
Carl Schwan
503a65ddd0 refactor: Run rector 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-18 17:45:54 +01:00
Ferdinand Thiessen
0ba4f5266e
refactor(sharebymail): migrate app to Vue 3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-10-22 17:10:28 +02:00
Daniel Kesselberg
83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2025-10-04 21:54:22 +02:00
provokateurin
665a38573c
fix(IShareProvider): Add missing getChildren method to the interface 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-07-29 10:26:33 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
provokateurin
ae16a28758
perf(Share20): Add interface to query all shares in a folder without filtering by user 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-08 15:29:40 +02:00
Côme Chilliet
c9938e54a6 fix(sharebymail): Fix activity rich object id type 
Fixes "Object for placeholder file is invalid, value 21 for key id is not a string"
Exception spotted in tests logs.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-25 15:43:09 +01:00
Marcel Klehr
b464469bc1 perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals 
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-03-25 09:42:06 +01:00
Joas Schilling
095ab4419e
fix(l10n): Improve english source strings 
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-26 09:54:32 +01:00
nfebe
72b6508d91 fix: Show recipient email addresses in share owner notification email 
Previously, the share owner notification email did not display the recipient email addresses,
making it difficult for the owner to know who the share was sent to.
This fix ensures that the recipient email addresses are included in the notification email.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-01-29 12:42:43 +01:00
Ferdinand Thiessen
305e1bb260
fix: Ensure label is always a string 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-26 20:41:31 +01:00
Git'Fellow
20215fbd09 fix(shares): Remove noisy text from emails 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-12-16 15:16:33 +01:00
Git'Fellow
f86fb0fee2 fix(share): Don't print twice the same information 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-12-10 18:27:31 +01:00
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-05 09:58:11 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Ferdinand Thiessen
db94e10af0
fix: Prevent breaking change in IQueryBuilder 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:44 +02:00
Ferdinand Thiessen
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns 
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:42 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Côme Chilliet
0e282ea21a
fix(tests): Fix sharebymail tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-08 16:53:51 +02:00
Côme Chilliet
59e4e4bfba
fix(sharebymail): Fix share update when node id changed 
This fixes transfering an email share from a user to another one when using
 objectstore as primary storage.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-07 15:36:53 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Anna Larch
1ce46c1fca refactor: move to new activity exception 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-17 12:06:24 +02:00
Stefan Cherniakov
457eaee2b3 fix(files_sharing): Add missing check for null & use bool instead of int for reminder_sent field 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 17:23:31 +02:00
Stefan Cherniakov
d633b9bce6 fix(files_sharing): Make share reminders more stable & fix issues 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 13:37:17 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Ferdinand Thiessen
dd58e5290f
feat: Use new password context in sharing API 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-22 19:16:55 +02:00
skjnldsv
60eaef6696 feat(sharebymail): improve share email format 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-06 09:42:19 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
30f9ef414e fix: psalm, cs, autoloader and lint 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
5ce4bb368f chore(files_sharing): refactor share password mail 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
75ca4944c9 feat(files_sharing): allow mixed values in share attributes and allow storing email arrays 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
c253112cf7 chore(files_sharing): refactor mail handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
d388370c3b feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
443c48aefb feat(files_sharing): add new file request option 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
Andy Scherzinger
afa48a4e0e
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-02 20:00:00 +02:00
Robin Appelman
ccd56672e8
refactor: remove non-shallow getSharesInFolder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-01 16:46:06 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Adam Serbinski
f45eb75e3d ShareByMailProvider: getAccessList: set correct value for 'public' 
PDOStatement::rowCount behavior is undefined for SELECT statements
for some database types, therefore manually set the value for 'public'
based on actual results fetched.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2024-03-21 18:25:31 -04:00
Adam Serbinski
01e32340af ShareByMailProvider: getAccessList: set both array keys 'public' and 'mail' 
To preserve prior behaviour where 'public' was set 'true' if there
are any mail recipients. The 'mail' key will be an array of email
recipients.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2024-03-21 18:25:31 -04:00
Adam Serbinski
34ca6bd46a ShareByMailProvider: getAccessList: recommended style changes 
Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2024-03-21 18:25:31 -04:00
Adam Serbinski
9c528d412c ShareByMailProvider: getAccessList: add token to returned array 
This allows the share URI to be regenerated.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2024-03-21 18:25:31 -04:00
Adam Serbinski
26ae5e6dfb ShareByMailProvider: getAccessList: return full list of recipients 
Previously was returning only boolean true if the Node was shared
by email, or false if not. Now provides an array containing the
list of email share recipients.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2024-03-21 18:25:31 -04:00