Commit graph

597 commits

Author SHA1 Message Date
Christopher Ng
1437abd4dd feat(files): Display meaningful error message on move failure
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-02-05 09:39:28 +01:00
provokateurin
def5e0b9a6
fix(files): Allow opening the same file repeatedly
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-31 08:20:36 +01:00
Ferdinand Thiessen
59ee4af65b
fix(files): Restore page title (folder - view - product)
* Folder: Current folder if not root
* View: Name of current view
* Product: Nextcloud

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 18:58:58 +01:00
skjnldsv
addc56a7e6 fix(files): rename actions submenu back entry
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:22:34 +00:00
skjnldsv
a2d6ad8014 fix(files): close submenu on main actions state change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:22:33 +00:00
Richard Steinmetz
f0dfc9c504
fix(files): sort not working after changing views
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-20 19:30:06 +01:00
Git'Fellow
a69d797afb
Fix backport conflicts
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-25 08:08:40 +01:00
Git'Fellow
9022f6e117
Merge branch 'stable29' into backport/49271/stable29
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-25 08:07:07 +01:00
skjnldsv
602b5efb4a fix(files): ensure valid mtime and fallback to crtime if defined
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-15 13:53:53 +01:00
John Molakvoæ
c01d323dfb
Merge pull request #49791 from nextcloud/backport/49685/stable29
[stable29] fix(files): failsafe when executing actions methods
2024-12-12 18:17:52 +01:00
skjnldsv
60b1271416 fix(files): failsafe when executing actions methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 16:42:20 +01:00
skjnldsv
dadab6ed14 fix(files): throttle favorite with max 5 simultaneous requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-11 19:39:59 +00:00
skjnldsv
da33159f1e fix(files): dav Node type declaration
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-10 14:37:44 +01:00
skjnldsv
744163359f fix(files): properly update paths and folder children on node move
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-10 13:58:07 +01:00
skjnldsv
b51e7b42fd fix(files): cancel renaming on enter if no file name changes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-10 10:55:00 +00:00
Ferdinand Thiessen
0885d2d2e0 fix(files): Make injected actions reactive
Provided values are not reactive by default and by design,
we must need computed to make them reactive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-21 13:23:59 +00:00
Ferdinand Thiessen
4b7014d805 fix(files): Allow downloading multiple nodes not from same base
When downloading files in e.g. the *favorites* or *recent* view,
then the nodes are not always share the same parent folder
and we can not use the current directory as it is probably just a
virtual one.

So we calculate the longest common base and use that as the directory
for the download endpoint.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 20:24:58 +01:00
Richard Steinmetz
43b0df9b65
fix(files): improve delete display name when trashbin is disabled
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-11-19 11:59:01 +01:00
skjnldsv
a2a16936c3 fix(files): check that node is in user root folder for view-in-folder action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 22:39:17 +00:00
skjnldsv
68c4c4b953 fix(files): edit locally buttons
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 18:20:18 +01:00
Ferdinand Thiessen
533c5e2aa4
fix(files): Ensure renaming state is correctly reset
Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-07 16:37:55 +01:00
Louis Chemineau
f3dd25fa64 fix(files): Do not jump to top when fileId is set to currentFolder
Fix https://github.com/nextcloud/server/issues/48545

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-10-29 14:39:50 +00:00
Grigorii K. Shartsev
d453426002 refactor(files): migrate to @nextcloud/sharing
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-28 21:12:54 +01:00
Grigorii K. Shartsev
d9d7d64715 fix(files): handle empty view with error
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-28 21:12:54 +01:00
Grigorii K. Shartsev
65bf473003 chore(files): migrate davUtils to TS
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-28 21:12:54 +01:00
Grigorii K. Shartsev
ae2ba0eddd fix(files): add title for files list table header button
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-28 08:29:35 +00:00
Ferdinand Thiessen
02d78079a8
fix(files): Adjust Typescript issues
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 18:33:04 +02:00
Ferdinand Thiessen
714ef088ad
test(files): Add tests for path handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 18:32:59 +02:00
Ferdinand Thiessen
c224a1c340
fix(files): Ensure children are removed from folder and not duplicated
* Resolves https://github.com/nextcloud/server/issues/47904

We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 13:08:29 +02:00
Ferdinand Thiessen
d58a333d5e
fix(files): Add more visual move / copy notification
* Resolves: https://github.com/nextcloud/server/issues/46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-11 14:22:15 +02:00
Louis Chemineau
0dcd2ca733 fix: Show storage full warning when storage is actually full
< 0 values for "free" do not mean that the storage is full: 6befdd6dd7/lib/public/Files/FileInfo.php (L31-L42)

Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-26 08:58:41 +00:00
Christopher Ng
1507877630 fix(files): Fix having to resolve conflicts twice when dropping files
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-25 14:27:32 -07:00
fenn-cs
35f3a3e7b7 fix(Federation): Show some icon for federated users on shares
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-09-23 10:50:27 +01:00
Louis Chemineau
936f34d3a5
feat: Reset route if neither the Viewer of the Sidebar is open
When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 11:59:34 +02:00
Ferdinand Thiessen
eb897b112e
fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 11:53:15 +02:00
Ferdinand Thiessen
2a5d6bb713 fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 09:15:41 +02:00
skjnldsv
bcb536e04d fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 17:01:53 +00:00
skjnldsv
7a64f8ee19 fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 16:09:58 +00:00
Ferdinand Thiessen
e0a310bc51 fix(files): Typo in import of ShareType
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-04 14:26:19 +00:00
Ferdinand Thiessen
ca3af10b28
refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 16:00:03 +02:00
Elizabeth Danzberger
a4d26db380
fix(files): fix list gap at bottom
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-27 15:20:20 -04:00
Ferdinand Thiessen
0c77417bc4
refactor(files): Migrate favorites view to @nextcloud/files functions and make it cancelable
Also this fixes the view being writeable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 14:59:05 +02:00
Ferdinand Thiessen
8fb9c821ad
fix(files): Reset drop notice on firefox
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 11:58:27 +02:00
Ferdinand Thiessen
b72277de58
fix(files): Remove huge margin on bottom
Instead make it relative to screen size.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 23:23:40 +02:00
nextcloud-command
a14de4c8d3
chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-21 11:18:25 +02:00
skjnldsv
5dc2248bea fix(files): trim names on new node creation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-09 13:11:39 +00:00
Ferdinand Thiessen
081219a535
fix(files): Add missing directory variable to error message
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 17:20:54 +02:00
Ferdinand Thiessen
adacfa8e9b
fix(files): Provide file actions from list entry to make it reactive
This fixes non reactive default action text of the name component.
Also use download action as default action so that only one place
is needed to define how to download a file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 17:20:54 +02:00
Ferdinand Thiessen
f7ee910dc0
fix(files): Correctly create Nodes from WebDAV result in "recent"-view
The recent search works on a different remote URL so the source of the files were wrong,
because the remote url was included twice in the source.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 16:49:09 +02:00
Ferdinand Thiessen
93cded4ccf
fix(files): cancel move-copy action should not be handled as an error
Instead we should just show an information message why the file is not moved / copied.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 14:24:28 +02:00