Commit graph

422 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
c6f870245a fix: Fix theming for disabled accounts
The Theming app injects the stylesheets for the different themes in the
"<header>" element of the page, and those stylesheets are then loaded by
the browser from a "Controller" (a plain "Controller", not an
"OCSController"). The stylesheets, in turn, may also get some images
(like the background) also from the "Controller".

When handling a request to "index.php" it is checked whether the user is
logged in and, if not, a login is tried. A disabled user is explicitly
seen as not logged in, so a login is always tried in that case, but
disabled users are also explicitly prevented to log in, so the login
also fails. Due to that trying to get any of the themed stylesheets or
images with a disabled account (to be able to show the "Account
disabled" error page) fails with an HTTP status 401.

To solve that, and to avoid touching this basic logic as much as
possible, the login exception is now ignored (if the user is disabled)
for some specific requests to the Theming app.

The clouds.jpg file was not available in stable30, so the file and its
license were copied from the commit that introduced them in newer
branches, 19ce362896.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-07-11 12:01:04 +02:00
Daniel Calviño Sánchez
45b06784a7 ci: Fix running files_external S3 tests
PHP >= 8.4 is not supported in Nextcloud 30.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-06-17 06:15:37 +02:00
Ferdinand Thiessen
2f56cc3950 test: reenable localstack tests (bug fixed) but disable MinIO versioned copy test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-12 22:37:22 +02:00
Ferdinand Thiessen
8e54caa052 test: only skip tests failing on localstack for localstack
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-12 22:37:22 +02:00
Ferdinand Thiessen
f8f1de4b0b test: fix s3 external storage tests to run all storages on ci
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-12 22:37:22 +02:00
John Molakvoæ
0d04ff0401 chore(workflows): add auto stable PR title update
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-06-09 14:37:34 +00:00
skjnldsv
38cc75bb7c fix(workflows): releases changelog generator tags handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-05 11:20:09 +00:00
Andy Scherzinger
b79244c6f3
ci: Update comments and correctly skip the "pull 3rdparty" command
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-05-26 12:05:05 +02:00
Joas Schilling
dd87f90aef
ci: Remove credentials on checkout
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-26 09:21:59 +02:00
Andy Scherzinger
041e0b4ce6
ci(actions): Sync workflow updates
based on #53105

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-05-25 15:35:51 +02:00
skjnldsv
9f0c7eb4f9 feat: auto-generate changelog on release
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-05-23 19:19:10 +00:00
Marcel Müller
8eb5b048f1 chore: Add logs for dc and apache container
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-05-01 15:36:47 +00:00
Ferdinand Thiessen
86d2c5cbc8
fix(mime-types): adjust compiled mime types and sign
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 15:29:25 +01:00
Louis Chemineau
2d839d767a
chore(tests): Fix using save/restore state in cypress
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +01:00
Joas Schilling
03b3773c91
ci(autochecks): Run some autochecks also on non-PHP files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-21 13:48:48 +01:00
Robin Appelman
b9ac12466e test: re-add object store primary storage phpunit tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +01:00
skjnldsv
f2d40badfd chore: enable cypress video recording in debug mode
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-03 11:42:22 +01:00
Marcel Müller
93d1f08eec chore(ci): Run kerberos tests on ubuntu-latest
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-01-03 07:56:40 +00:00
Robin Appelman
3ab58abfeb
test: attempt to fix smb sso test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:51:33 +01:00
provokateurin
175035e5bf ci(psalm): Add missing imagick extension
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-29 07:12:59 +00:00
Joas Schilling
69949eb4e0
ci: Update list of installed PHP extensions (as some are not default enabled in new images)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 09:08:54 +02:00
Daniel Kesselberg
64ff9cd2f3 ci: fail psalm when baseline update required
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 17:05:19 +00:00
provokateurin
4800215056
fix(psalm): Enable findUnusedBaselineEntry
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-23 11:17:39 +02:00
provokateurin
863679f499
fix(test): Fix provisioning enabled apps
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-29 09:43:37 +02:00
Robin Appelman
22f76fca59 test: run sharding tests in ci
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +02:00
Joas Schilling
261e9a0f1d
ci: Update integration-sqlite.yml
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2024-08-27 21:43:58 +02:00
Joas Schilling
ddf7e7acc9 ci: Don't run things normally and with coverage flag on the same configuration
Signed-off-by: Joas Schilling <coding@schilljs.com>

[skip ci]
2024-08-27 20:09:25 +02:00
Joas Schilling
07b3d4cc52 ci: Run things we only run on 1 PHP version on the preinstalled 8.1 which installs ~2m faster
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-27 20:09:25 +02:00
Joas Schilling
5a55410083
chore(branchoff): Test against stable30 branches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-14 13:53:22 +02:00
dependabot[bot]
6edca57df4
build(deps): bump the github-actions group with 6 updates
Bumps the github-actions group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [shivammathur/setup-php](https://github.com/shivammathur/setup-php) | `2.31.0` | `2.31.1` |
| [actions/setup-node](https://github.com/actions/setup-node) | `4.0.2` | `4.0.3` |
| [cypress-io/github-action](https://github.com/cypress-io/github-action) | `6.7.1` | `6.7.2` |
| [actions/upload-artifact](https://github.com/actions/upload-artifact) | `4.3.3` | `4.3.4` |
| [codecov/codecov-action](https://github.com/codecov/codecov-action) | `4.1.1` | `4.5.0` |
| [mdecoleman/pr-branch-name](https://github.com/mdecoleman/pr-branch-name) | `2.0.0` | `3.0.0` |


Updates `shivammathur/setup-php` from 2.31.0 to 2.31.1
- [Release notes](https://github.com/shivammathur/setup-php/releases)
- [Commits](2e947f1f69...c541c155ee)

Updates `actions/setup-node` from 4.0.2 to 4.0.3
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](60edb5dd54...1e60f620b9)

Updates `cypress-io/github-action` from 6.7.1 to 6.7.2
- [Release notes](https://github.com/cypress-io/github-action/releases)
- [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md)
- [Commits](8d3918616d...df7484c5ba)

Updates `actions/upload-artifact` from 4.3.3 to 4.3.4
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](65462800fd...0b2256b8c0)

Updates `codecov/codecov-action` from 4.1.1 to 4.5.0
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Commits](https://github.com/codecov/codecov-action/compare/v4.1.1...v4.5.0)

Updates `mdecoleman/pr-branch-name` from 2.0.0 to 3.0.0
- [Release notes](https://github.com/mdecoleman/pr-branch-name/releases)
- [Commits](bab4c71506...55795d86b4)

---
updated-dependencies:
- dependency-name: shivammathur/setup-php
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: cypress-io/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: mdecoleman/pr-branch-name
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-31 22:54:25 +00:00
Joas Schilling
fa3f4e9d2c
ci: Fix summary condition
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-30 14:37:15 +02:00
skjnldsv
531d8076ae chore: bump cypress workers
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-27 10:02:14 +02:00
Joas Schilling
817ca0045a
ci: Run all Oracle versions all the time
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:46 +02:00
Joas Schilling
5c02303ce4
ci(oracle): Test against Oracle 11, 18, 21 and 23
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:09 +02:00
Joas Schilling
fe90e97f73
fix(CI): Fix compile command
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-16 13:35:54 +02:00
Ferdinand Thiessen
465cee2da3
Merge pull request #46535 from nextcloud/fix/noid/use-ubuntu-latest-for-s3
fix(ci): Use ubuntu-latest for object storage test
2024-07-16 12:16:17 +02:00
Marcel Müller
9b02ebde28 fix(ci): Use ubuntu-latest for object storage test
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-07-15 15:58:22 +02:00
Joas Schilling
e40cc779c9
fix(CI): Skip some CI work from forks as they don't work anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-15 13:25:20 +02:00
Joas Schilling
7cad5573f5
fix(CI): Require compilation check when touching version.php
NPM is using version.php as app version and that seems to be part of the dist files now

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-12 15:05:35 +02:00
Daniel Kesselberg
ded1a48034
chore: auto approve the psalm baseline update
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-11 22:50:05 +02:00
Andy Scherzinger
9d105e8b8b
ci: Bump reuse to v4.0.0
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-07-04 22:25:48 +02:00
Ferdinand Thiessen
98c143ec91
ci: also check for uncompiled SCSS styles
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 13:47:43 +02:00
John Molakvoæ
47f837c962
Merge pull request #46111 from nextcloud/dependabot/github_actions/github-actions-6c0d3fe959 2024-07-02 12:34:32 +02:00
Git'Fellow
b77c151f5b
Merge pull request #46197 from nextcloud/setupPhpUpgrade
ci: Use the same `setup-php` version on all tests
2024-06-30 08:39:06 +02:00
Git'Fellow
ad1720b6e2 ci: Use the same setup-php version on all tests 2024-06-30 08:11:14 +02:00
Ferdinand Thiessen
d5d180daf6
ci: Adjust database versions to current LTS / supported versions
* MySQL tests
  * Minimum 8.0 (LTS)
  * Maximum 8.4 (LTS)
  * Drop 8.3 as we now test 8.4 and 8.3 was never LTS
* MariaDB tests
  * still supported version 10.3 (no LTS but for Ubuntu 20.04 support)
  * LTS 10.6
  * LTS 10.11
  * LTS 11.4
  * Drop 10.5 is was never LTS and we test 10.3 and 10.6

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +02:00
dependabot[bot]
f7b0fa20e9
chore(deps): bump the github-actions group with 3 updates
Bumps the github-actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [cypress-io/github-action](https://github.com/cypress-io/github-action) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request).


Updates `actions/checkout` from 4.1.5 to 4.1.7
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4.1.5...692973e3d937129bcbf40652eb9f2f61becf3332)

Updates `cypress-io/github-action` from 6.7.0 to 6.7.1
- [Release notes](https://github.com/cypress-io/github-action/releases)
- [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md)
- [Commits](f88a151c98...8d3918616d)

Updates `peter-evans/create-pull-request` from 6.0.5 to 6.1.0
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](6d6857d369...c5a7806660)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: cypress-io/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-25 14:20:17 +00:00
Richard Steinmetz
42fa007204
Merge pull request #45969 from nextcloud/ci/phpunit-mysql/more-retries
ci(phpunit-mysql): increase mysql health check retries
2024-06-19 14:57:06 +02:00
Richard Steinmetz
ddf1d3e7ac
ci(phpunit-mysql): increase mysql health check retries
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-19 12:36:16 +02:00
Andy Scherzinger
75756e3064
ci: Add REUSE compliance check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-19 12:02:48 +02:00