Commit graph

2211 commits

Author SHA1 Message Date
Anna Larch
06ad7009f4 fix(userstatus): add missing parenthesis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-08-01 16:16:10 +00:00
Richard Steinmetz
25f56e75ef
fix(caldav): stricter default calendar checks
Reject calendars that
- are subscriptions
- are not writable
- are shared with a user
- are deleted
- don't support VEVENTs

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-23 08:50:30 +02:00
SebastianKrupinski
3c8106d511 fix(dav): Thrown forbidden error for authenticated user instead of not found
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-19 17:01:24 +00:00
Sebastian Krupinski
33f39035e6
Merge pull request #46602 from nextcloud/backport/46593/stable29
[stable29] fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server…
2024-07-18 18:05:42 -04:00
SebastianKrupinski
658f225138 fix(caldav): decode values before returning
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-18 14:02:34 +00:00
SebastianKrupinski
9f3d07e339 fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server Error
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-18 08:17:13 +00:00
Andy Scherzinger
440968fe2c
Merge pull request #46012 from nextcloud/backport/45999/stable29
[stable29] fix(caldav): encode calendar URIs with umlauts for activities
2024-07-10 19:58:13 +02:00
SebastianKrupinski
7728bbcf25 fix(caldav): limit vevent size
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-10 14:55:52 +00:00
Richard Steinmetz
d9d4f1e16f fix(caldav): encode calendar URIs with umlauts for activities
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-10 15:18:27 +02:00
SebastianKrupinski
38f6af0bd6 fix(carddav): limit vcard size
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-04 22:18:40 +00:00
Arthur Schiwon
d4b5d63c90
Merge pull request #46226 from nextcloud/backport/46219/stable29
[stable29] fix(DAV): offset not applied
2024-07-04 19:40:32 +02:00
Arthur Schiwon
19192bb037 fix(BuildSocialSearchIndexBackgroundJob): offset not applied
with more than 100 results, this job may never finish

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-01 16:38:33 +00:00
Julius Härtl
583caa8d70 fix: Authorization header can be an empty string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-01 09:44:23 +00:00
Daniel
373c3ae936
Merge pull request #46117 from nextcloud/backport/46002/stable29
[stable29] Use guzzle for addressbook federation
2024-06-29 16:15:44 +02:00
SebastianKrupinski
6fa1acae8e fix(caldav): when message is a reply compare the message sender not the recipient
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-27 09:23:49 +02:00
SebastianKrupinski
0dbd4aa8b9 fix(dav): add missing database index for dav_shares resourceid, type and access
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-06-26 19:04:15 +00:00
Daniel Kesselberg
b0505d62f4 chore: don't pass null to createElement
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-25 19:11:17 +00:00
Daniel Kesselberg
8670df2bc5 refactor(dav): migrate to new http client
The request method is available since 29 and thus we can finally use the modern http client to send the report request for the addressbook sync.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-25 19:11:17 +00:00
Joas Schilling
2bd5a534f0 fix(userstatus): Fix user status automation in real-life scenario
Order of applying:
- Out-of-office
- Availability
- Call
- Meeting
- User status

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 09:33:12 +00:00
Christoph Wurst
bbbc931766 fix(dav): Limit number of UPDATES for sync token created_at
Address book and calendar sync tokens have a created_at column in 26+
and we need to assign a current timestamp to the existing data at
upgrade so the data isn't cleaned up immediately. Updating the full
table is expensive and fails on clustered setups that limit transaction
size. We don't need a timestamp for the oldest rows so we can skip
updating them.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-06-19 16:09:13 +00:00
skjnldsv
697f9032cf fix(dav): also return shared-with-me shares data
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 11:06:10 +00:00
Richard Steinmetz
a794f15b1f fix(caldav): event links in shared calendar notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-11 18:44:14 +00:00
Joas Schilling
b3705418f3 fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-10 11:55:30 +00:00
John Molakvoæ
5d962241ca
Merge pull request #45543 from nextcloud/backport/44664/stable29 2024-06-07 12:17:58 +02:00
Daniel Kesselberg
8330825f3e feat(caldav): order the calendar objects by start date for search
Sorting the events by the start date leads to more predictable results for the search API consumers.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-06 12:29:29 +02:00
Daniel Kesselberg
449af33c29 fix(caldav): event search with limit and timerange
Event recurrences are evaluated at runtime because the database only knows the first and last occurrence.

Given, a user created 8 events with a yearly reoccurrence and two for events tomorrow.
The upcoming event widget asks the CalDAV backend for 7 events within the next 14 days.

If limit 7 is applied to the SQL query, we find the 7 events with a yearly reoccurrence and discard the events after evaluating the reoccurrence rules because they are not due within the next 14 days and end up with an empty result even if there are two events to show.

The workaround for search requests with a limit and time range is asking for more row than requested and retrying if we have not reached the limit.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-06 12:29:29 +02:00
Anna Larch
ec94f5499c fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 11:10:03 +00:00
Anna Larch
9bea6eca98 fix(userstatus): catch unique constrain violation on revert
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-29 10:31:14 +02:00
Hamza Mahjoubi
2abfae81cb fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-05-28 10:09:22 +00:00
Anna
d8a29a459c
Merge pull request #45224 from nextcloud/backport/44752/stable29
[stable29] Expose subscription calendars
2024-05-24 16:42:31 +02:00
Anna Larch
21dd449e47 fix(caldav): loop through all events for busy events
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-14 13:35:27 +00:00
Daniel Kesselberg
9faddcd5d8
feat(caldav): expose calendar subscriptions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-08 10:49:21 +02:00
Côme Chilliet
20e378d5e5
Merge pull request #44564 from nextcloud/automated/noid/stable29-update-psalm-baseline
[stable29] Update psalm-baseline.xml
2024-05-06 19:31:16 +02:00
Côme Chilliet
82e593b83b
chore: Fix small psalm errors related to documented return types
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-05-06 18:21:38 +02:00
Joas Schilling
137d4617cb
Merge pull request #45018 from nextcloud/backport/45001/stable29
[stable29] fix(DAV): Migrate known exceptions to Sabre exceptions when copying
2024-05-06 08:16:18 +02:00
Anna Larch
e32ea9ab37 fix(CalDAV): remove UNKNOWN from room / resource consideration
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-04-26 11:20:08 +00:00
Joas Schilling
368769aa5a fix(DAV): Migrate known exceptions to Sabre exceptions when copying
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 16:32:39 +00:00
Louis Chemineau
a97c2131d2 feat(dav): Support multiple scopes in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-04-22 15:28:29 +00:00
Joas Schilling
69a3038086
Merge pull request #44622 from nextcloud/backport/44534/stable29
[stable29] build(deps): bump nextcloud/coding-standard from 1.1.1 to 1.2.1 in /vendor-bin/cs-fixer
2024-04-04 13:07:22 +02:00
Côme Chilliet
cd53e71d80 chore: Improve phpdoc typing to silence psalm errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
ae7105b990 fix(dav): Fix quota check for chunk upload
Do not ignore OC-Total-Length when Content-Length and
 X-Expected-Entity-Length are missing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 15:45:57 +00:00
Robert C. Schaller
fa6e6131ee fix(dav): wrong comparison method between two events
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.

Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
2024-03-25 13:18:58 +01:00
Christoph Wurst
3dea99f42b
fix(dav): Add retention time to sync token cleanup
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 18:37:21 +01:00
Anna
bdd4ac2c17
Merge pull request #44360 from nextcloud/fix/add-exdate-exrule-to-confidential-object
fix(caldav): add EXDATE and EXRULE to confidential object
2024-03-21 14:34:08 +01:00
Hamza
007b54afed
Merge pull request #44376 from nextcloud/fix/dav/acls-shared-addressbook
fix(dav): ACLs for shared addressbooks
2024-03-21 14:33:43 +01:00
Christoph Wurst
b6e1685683
fix(dav): ACLs for shared addressbooks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:50:35 +01:00
Anna Larch
a96f8f7fee fix(caldav): add EXDATE and EXRULE to confidential object
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 10:01:33 +01:00
Côme Chilliet
c1b451ea86
chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:25 +01:00
Côme Chilliet
fa8efd5df8
fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:12 +01:00