Commit graph

1552 commits

Author SHA1 Message Date
Ferdinand Thiessen
264074c161 fix: OCP\Files\Node\Folder::search was not setting the owner
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 11:06:30 +00:00
Julius Härtl
d76c0d4af6 fix: Do not return partial file info if we have a cache entry
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-29 08:16:30 +02:00
Andy Scherzinger
b1eb1c5a0f
Merge pull request #46679 from nextcloud/backport/44294/stable29
[stable29] fix: Pass the mountpoint target user to storages without owner
2024-07-25 19:40:10 +02:00
Ferdinand Thiessen
824803dd7b fix: FileInfo from View should have the correct name of a mountpoint
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-24 13:26:40 +00:00
Julius Härtl
c60725c813 fix: Pass the mountpoint target user to storages without owner
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 12:51:50 +00:00
Andy Scherzinger
0f332839af
Merge pull request #46035 from nextcloud/backport/46017/stable29
[stable29] fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
2024-07-10 20:32:36 +02:00
Git'Fellow
aa24a4ad5d fix(s3): Don't wait indefinitely for S3 to return
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-09 07:51:43 +00:00
Robin Appelman
bf8a73c539 fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-21 10:29:52 +00:00
Robin Appelman
3e56c3d681 feat: add option to disable scanner transactions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 12:02:53 +00:00
Robin Appelman
d1aac3292a fix: get child ids for folder in a separate query during move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 09:46:42 +00:00
Josh
fcdf453b58 fix(ObjectStore): handle empty S3 hostname
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-06-13 09:37:03 +02:00
Louis Chemineau
b7cd197315 fix(files): Use isRetryable to catch retryable exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-12 08:15:08 +00:00
Git'Fellow
eec6816d49 Try create folder first and check if it exists after
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00
Git'Fellow
75883cb4d9 fix(files): Try to create dir only if it not exists
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00
Ferdinand Thiessen
b3341a17dc
Merge pull request #45158 from nextcloud/backport/45140/stable29
[stable29] fix: fix FileAccess::getByFileId(InStorage)
2024-05-29 10:27:19 +02:00
Git'Fellow
340db5c3d7
Merge pull request #45529 from nextcloud/backport/45014/stable29
[stable29] fix: forbid moving a folder into a subfolder of itself
2024-05-29 10:26:00 +02:00
Josh
413526a688
Merge pull request #45215 from nextcloud/backport/45058/stable29
[stable29] perf(db): Sort data for IN before chunking
2024-05-28 17:04:56 -04:00
Maxence Lange
3f86f4e1ff feat(metadata): migrate to lazy appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-05-27 10:27:49 -04:00
Robin Appelman
4a8eaaf21b fix: forbid moving a folder into a subfolder of itself
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-27 12:33:00 +00:00
Christoph Wurst
9c4d8b3337 perf(db): Sort data for IN before chunking
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-05-25 20:48:55 -04:00
Josh
3fef446b62 fix(Files): Change how scanner diffs for changed metadata
Fixes #43408 

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-05-13 09:07:48 +00:00
Robin Appelman
62e712cb85 fix: fix FileAccess::getByFileId(InStorage)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-02 17:11:34 +00:00
Robin Appelman
cec057799d feat: add option to enable s3 acceleration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-04-26 13:44:59 +00:00
Joas Schilling
0a429e0f80
fix(CI): Suppress psalm UndefinedClass
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-18 09:25:17 +02:00
Joas Schilling
546b0471ed fix(files): Also skip cross storage move with access control
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-17 14:31:50 +00:00
Robin Appelman
6c142a3cd5 fix: use proper jailed patch in watcher
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-04-09 10:41:50 +00:00
Côme Chilliet
4311f60ebb fix: Remove incorrect default null value
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Louis Chemineau
751795999a
feat(files)): Add retry logic to cover deadlock situations when moving many files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-28 09:05:47 +01:00
Ferdinand Thiessen
7880086de8
fix(S3): Adjust typing for 32bit compatibility
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 13:07:53 +01:00
Robin Appelman
1d9354a81e
feat: add interface for lower level filecache acess without having to do direct db queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-25 16:48:41 +01:00
John Molakvoæ
fb97d551a1
Merge pull request #44357 from nextcloud/wrapper-instanceof-resiliant 2024-03-22 20:43:34 +01:00
Ferdinand Thiessen
32dee2f84a
feat(ObjectStore): Make S3 MultipartUpload concurrency configurable
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-21 16:25:49 +01:00
Ferdinand Thiessen
69c5e8ebde
fix(ObjectStore): Use common S3 trait so config and connection trait members are in sync
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-21 16:25:42 +01:00
Robin Appelman
d5fa2ec7c3
fix: log error when default getWrapperStorage would return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-20 14:26:01 +01:00
Robin Appelman
afb589a69b
fix: ensure nested mount points are handled in the correct order
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-18 18:13:31 +01:00
Andrew Summers
45eb4a839d Refactor OC\Server::getLockingProvider
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:11:33 +01:00
Benjamin Gaussorgues
d15e45c2ff
Merge pull request #36252 from nextcloud/modernize-mime-typeloader 2024-03-14 20:51:17 +01:00
Thomas Citharel
ffeb797ecc
refactor(mimeloader): modernize MimeTypeLoader
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-03-14 17:24:36 +01:00
Benjamin Gaussorgues
5158bbf09b
fix: avoid scanning a non existing directory
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-03-14 16:26:52 +01:00
John Molakvoæ
f316edb9ff
Merge pull request #43652 from hopleus/bugfix/fixed-get-filename-in-fileinfo 2024-03-14 15:50:52 +01:00
hopleus
a25c70c9b0
Refactoring getName function
Signed-off-by: hopleus <hopleus@gmail.com>
2024-03-12 17:24:24 +03:00
Arthur Schiwon
b32c0f7da6
Merge pull request #39990 from nextcloud/recursive-share
add some recrusive detection/prevention
2024-03-11 19:30:50 +01:00
Maxence Lange
467c84ec53 feat(files): copy live photos
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-08 13:09:22 -01:00
Robin Appelman
ea8a774a0a fix: add some recrusive detection/prevention
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-08 14:20:14 +01:00
John Molakvoæ
7dd22b0c83
Merge pull request #43982 from nextcloud/fixMemExaust
fix(filecache): Move from array_merge to avoid memory exhaustion on large scans
2024-03-07 22:53:08 +01:00
Joas Schilling
951c330d39
Revert "don't perform an explicit setup when using the file cache" 2024-03-07 14:38:02 +01:00
John Molakvoæ
b7088e7071
Merge pull request #32163 from nextcloud/file-cache-gc-no-full-setup
don't perform an explicit setup when using the file cache
2024-03-07 11:09:19 +01:00
Robin Appelman
efcb16f859
Merge pull request #43086 from nextcloud/s3-internal-multipart-copy-disable
disable the internal s3sdk multi part copy logic
2024-03-07 10:13:00 +01:00
Robin Appelman
4fba4cd14c fix: fix user folder init
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 17:52:24 +01:00