Commit graph

100 commits

Author SHA1 Message Date
Joas Schilling
a0fedf1c7f
Merge pull request #59985 from nextcloud/chore/psalm-v6
chore: update psalm to v6
2026-04-29 07:20:29 +02:00
Ferdinand Thiessen
20acaf307e
chore: add missing Override attribute to core code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 21:29:28 +02:00
Ferdinand Thiessen
2a8aaf9c0a
chore: adjust code style
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 17:24:56 +02:00
Josh
e97cf02574 feat(app): allow removing installed-but-disabled apps; improve help & logging
- Allow removal of apps that are installed but currently disabled
 - Add explicit installed check (getAppPath) with clear message when not installed
- Expand help text to document uninstall behavior and --keep-data
 - Mirror console messages to logs for key events and consolidate exception logging
- miscellaneous code tidying

Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-04-28 13:51:48 +02:00
Maksim Sukharev
43bf6bc26b feat(occ): show current version with occ app:update command
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2026-02-05 12:20:22 +01:00
Arthur Schiwon
e9a1d7fa0d
fix(Apps): fix install command check on existing apps
- AppManager::isInstalled() is misleading, as it checks only whether it is
  enabled. But an app might not be present in some edge cases.
- AppManager::getAppPath() does however only check whether an app dir is
  present, independent of the enabled-state.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-09-29 09:39:14 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
provokateurin
82fb8f8508
refactor: Extend rector to core/
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 00:16:54 +02:00
Côme Chilliet
4b099bd532
chore: Replace calls to OC_App::getAppVersions with app manager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +01:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:20 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +01:00
Christopher Ng
e0b3ab5165 fix: Correct wording when attempting to remove a disabled app
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-12-03 14:38:21 -08:00
Côme Chilliet
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Andy Scherzinger
5c49a54801
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-26 20:05:04 +02:00
Côme Chilliet
61621ee1d0
fix: Revert to OC_App in places where we need all apps even disabled ones
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 15:14:19 +02:00
Côme Chilliet
8c5f32320a
fix: use DI to build main Application class in console.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:15:07 +02:00
Côme Chilliet
644036ab4e
fix: Migrate away from OC_App toward the IAppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:14:58 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Adam Blakey
4744b02c40 style: Fixed style from composer cs:fix
Signed-off-by: Adam Blakey <adam@blakey.family>
2024-03-18 15:46:39 +00:00
Adam Blakey
aa09af8410 Update core/Command/App/ListApps.php
refactor: changed overcomplicated if statement into two shorter lines

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Adam Blakey <adam@blakey.family>
2024-03-18 15:45:17 +00:00
John Molakvoæ
8201a93452
Merge branch 'master' into show-enabled-and-disabled-apps
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-15 15:55:27 +01:00
Git'Fellow
6dfe3c91d5 Add a return message for app updates trough occ
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Handle single and all apps

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Rewrite logic

Fix psalm

Fix psalm

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-23 21:50:10 +01:00
John Molakvoæ
f40c2a03b0
Merge pull request #39183 from shdehnavi/refactor_core_command_app 2024-02-23 19:46:29 +01:00
Josh Richards
b3e5c14a6c
fix(Update): Handle upstream exception scenario cleanly
Fixes #42476

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-12-26 15:40:16 -05:00
Hamid Dehnavi
3658894722 Make adjustments based on the review
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-29 11:37:23 +03:30
Hamid Dehnavi
8075f6976f Make adjustments based on the review
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-29 11:37:23 +03:30
Hamid Dehnavi
81884cf9da Refactor core/Command/App
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-29 11:37:23 +03:30
Faraz Samapoor
cda0f74e0b Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +02:00
Faraz Samapoor
ea844ca5fb Uses PHP8's constructor property promotion.
in core/Command/App, /Background, and /Broadcast classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +02:00
Christoph Wurst
cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +02:00
Côme Chilliet
f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Julius Härtl
1da6c21036
Show version from appinfo on occ app:list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-11 14:45:11 +01:00
Adam Blakey
a676a67b9e Fixed logic issue where checking for wrong option
Signed-off-by: Adam Blakey <adam@blakey.family>
2022-08-15 21:59:16 +02:00
Adam Blakey
e9fb7a2885 added --enabled and --disabled options to occ app:list
Signed-off-by: Adam Blakey <adam@blakey.family>
2022-08-15 18:11:17 +02:00
Carl Schwan
b70c6a128f Update core to PHP 7.4 standard
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +02:00
Côme Chilliet
b865722ac0
Remove deprecated occ app:check-code command
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 15:08:01 +02:00
Joas Schilling
a4111d4846
Allow installing unstable versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +01:00
Vincent Petry
14c60b10d0
Merge pull request #30275 from nextcloud/bugfix/noid/add-version-of-disabled-apps-when-available
Add version of disabled apps when available
2022-01-14 11:59:25 +01:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +01:00
Joas Schilling
a376aa6c61
Add version of disabled apps when available
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-15 09:08:14 +01:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Maxopoly
1f93721097 Add force option to app install command
Signed-off-by: Maxopoly <max@dermax.org>
2021-03-22 23:49:13 +01:00
Christoph Wurst
e618ea83b5
Make the app code checker a NOOP
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +01:00
Christoph Wurst
fd649afb1f
Remove the deprecated update.php
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +01:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Morris Jobke
fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
John Molakvoæ (skjnldsv)
9e962fb69f
Allow to update to nightly
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-07 13:51:39 +02:00
Joas Schilling
ab21d69903
Add return value to all commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 14:54:51 +02:00