upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-26 03:04:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
62829 commits 967 branches 1211 tags 8.7 GiB
Commit graph

1457 commits

Author SHA1 Message Date
Julius Härtl
e906138d8d
Let sharees endpoint properly handle deck shares 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 13:20:23 +01:00
Julius Härtl
aefe826202
Adjust default 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:06:10 +01:00
Julius Härtl
98deb1bd07
Do not register share menu in cases where the files app has not been registered yet 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:53 +01:00
Julius Härtl
8f6c2ec357
Move columns to bigint 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:53 +01:00
Julius Härtl
bb21e87d23
Migrate files_sharing to migrations and move remote_id to a string in share_external 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:52 +01:00
Julius Härtl
f68f67f354
Move remoteId of remote reshares to string 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:03:24 +01:00
Morris Jobke
46f406a8be
Merge pull request #24017 from nextcloud/enh/share_expiration 
Make the expire shares cron job actually expire the shares
 2020-11-19 23:20:47 +01:00
Roeland Jago Douma
220bc1f218
Make the expire shares cron job actually expire the shares 
Right now we just delete the shares from the DB. Which is efficient
sure. But doesn't trigger any real cleanup. So no Admin audit entries or
any other post processing is done.

This makes sure we really trigger this.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-19 10:51:51 +01:00
Roeland Jago Douma
eab4f3dc76
Limit shared cache search if it is just a file 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-19 09:15:02 +01:00
Maxence Lange
28252594a2 circleId too short in some request 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-11-13 08:59:22 -01:00
Morris Jobke
dc479aae2d
Improve CertificateManager to not be user context dependent 
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)

The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 00:13:01 +01:00
Roeland Jago Douma
22f04a7cc3
Fix invalid usages of the new dispatcher 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-10-29 20:15:04 +01:00
Morris Jobke
0390a90d70
Return correct error message on share download without read permission 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-26 16:22:27 +01:00
John Molakvoæ (skjnldsv)
620be7dc22
Also expire share type email 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-10-20 10:20:26 +02:00
Morris Jobke
7525fb3408
Merge pull request #23350 from st3iny/fix/14849/share-api-preview-availability 
Inidicate preview availability in share api responses
 2020-10-13 17:27:27 +02:00
Richard Steinmetz
89f7e2ab64
Indicate preview availability in share api responses 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2020-10-13 14:12:42 +02:00
John Molakvoæ (skjnldsv)
698d4f55f2
Expose CLOUD federation for local users as well 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-10-12 15:17:14 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
John Molakvoæ (skjnldsv)
6adb19b296
Show filename on share link download 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-09-17 19:55:47 +02:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Morris Jobke
c9639f3956
Merge pull request #22898 from nextcloud/fix/16696/add-spaces-and-fix-variable-name 
Fix variable name and add spaces around path in info log line
 2020-09-17 11:55:07 +02:00
Morris Jobke
681e51c0ef
Merge pull request #22902 from nextcloud/fix/16696/proper-target-path-for-share-event 
Create proper target path for shared storage fopen event
 2020-09-17 11:53:28 +02:00
Morris Jobke
5eb808b763
Create proper target path for shared storage fopen event 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-17 09:52:31 +02:00
Morris Jobke
930c97a0ef
Fix variable name and add spaces around path in info log line 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-17 08:58:10 +02:00
Robin Appelman
cfde74442c
optimize View::getPath if we already know the storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-16 13:49:07 +02:00
Robin Appelman
244fd6ae49
disable update checking for shared storages 
update checking is already handled by the share source

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-15 16:42:40 +02:00
Robin Appelman
928cee2ae7
only get the permissions from the share source if it's not already cached 
this prevents having to setup the share source when doing metadata stuff on the share root

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-09 13:48:48 +02:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again) 
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-09-07 14:37:44 +02:00
Julius Härtl
f96853a19c
Do not fail if share for mountpoint is no longer available 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-09-03 11:17:59 +02:00
Robin Appelman
af381a9a93
remove unneeded if 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-28 11:43:23 +02:00
Roeland Jago Douma
7e6f04490e
Merge pull request #22393 from nextcloud/fix/license-headers-20 
Update the license headers for Nextcloud 20
 2020-08-24 22:03:00 +02:00
John Molakvoæ (skjnldsv)
6d576a9100
Fix missing FN from federated contact 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-08-24 15:15:32 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Morris Jobke
fedf9c69d9
Use matching parameter names form interfaces and implementations 
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 18:16:35 +02:00
Roeland Jago Douma
6ed4c8a946
Improve recent file fetching 
Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-08-18 05:56:06 +02:00
John Molakvoæ
565ccb08cd
Merge pull request #22109 from nextcloud/feature/20931/followup-1 2020-08-17 22:13:45 +02:00
Georg Ehrke
5b26487f14
Expose status via Collaborators API 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-08-14 17:04:52 +02:00
Daniel Kesselberg
6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-14 15:10:48 +02:00
Robin Appelman
5f58cefbd7
merge file activity settings into a single 'favorite changed' item 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-13 00:01:34 +02:00
Robin Appelman
a11769e0e3
move share notifcation settings to files group 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-13 00:01:30 +02:00
Joas Schilling
d4a4d5c6ef
When no user is logged in null is used 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-29 09:42:54 +02:00
Morris Jobke
0763a17332
Move federated_share_added into a typed event 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 08:33:17 +02:00
Christoph Wurst
b641f25606
Migrate files sharing to the PSR container 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 15:52:46 +02:00
Morris Jobke
c4b53538af
Better event description for BeforeTemplateRenderedEvent in files and files_sharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-15 20:15:51 +02:00
Julius Härtl
217a69ebf9
Add BeforeTemplateRenderedEvent for files_sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 13:55:26 +02:00
Morris Jobke
2ad95feab6
Merge pull request #21816 from nextcloud/techdebt/noid/federatedfilesharing-to-ibootstrap 
Use IBootstrap for the app federatedfilesharing
 2020-07-14 20:44:05 +02:00
Morris Jobke
7e281a07bb
Use IBootstrap for the app federatedfilesharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-14 16:34:43 +02:00
Gary Kim
a2cedcefee
Add user input for link share labels 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2020-07-14 10:02:17 +08:00
Roeland Jago Douma
1cf3280c8e
Lazy register the navigation 
This makes sure that we do not translate unneeded strings on for example
webdav requests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 10:12:53 +02:00
Roeland Jago Douma
1913b1b91f
Merge pull request #21591 from nextcloud/debt/noid/set-path-for-ocm-permissions 
Pass $path to ocmPermissions2ncPermissions
 2020-07-02 21:10:19 +02:00
Joas Schilling
d7c0b9cced
Also always return in app commands 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-26 15:12:11 +02:00
Daniel Kesselberg
6b1af4ac8c
Pass $path to ocmPermissions2ncPermissions 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-25 23:42:36 +02:00
Joas Schilling
89ed2c37bf
Update share type constant usage 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 16:49:16 +02:00
Joas Schilling
b740d283a9
Don't initialize Application directly 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-17 12:18:15 +02:00
Joas Schilling
56b04c65f7
Always sort shares in a reliable way 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-08 14:47:15 +02:00
Christoph Wurst
09a632242d
Do not only catch Exceptions but any Throwable during rmt share delete 
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-02 09:21:09 +02:00
Daniel Calviño Sánchez
37f231333f Fix reference to wrong class name 
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-05-29 01:41:06 +02:00
Roeland Jago Douma
ef34f72167
Have share permissions on link shares if it is enabled 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-15 08:18:03 +02:00
John Molakvoæ (skjnldsv)
a26ca1e638
Do not filter id matching userId on non-user-share shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv)
ff20da637e Fix federated link sharing permissions 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-04 11:48:11 +00:00
Roeland Jago Douma
d466a7b808 Allow to navigate to others with access from the sidebar 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-29 17:53:35 +00:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Morris Jobke
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare 
Fix resharing of federated shares that were created out of links
 2020-04-27 11:05:34 +02:00
Roeland Jago Douma
4114bce1e5
Merge pull request #17623 from j3l11234/master 
Add support for download share on old android browser
 2020-04-24 16:01:45 +02:00
Robin Appelman
7a4ea4a6b6
make php-cs happy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-23 13:35:30 +02:00
Morris Jobke
f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions 
Fix Sharing recommendation user display
 2020-04-22 14:56:01 +02:00
Roeland Jago Douma
8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls 
Allow some apps to have root URLs in their own routing file
 2020-04-21 16:00:34 +02:00
Julius Härtl
5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-21 14:35:29 +02:00
John Molakvoæ (skjnldsv)
7eceba7dae Fix Sharing recommendation user display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-21 07:48:10 +00:00
Robin Appelman
9735b5d61f
Add method to storage backends to get directory content with metadata 
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-20 15:45:04 +02:00
Joas Schilling
1b93d5f1db
PHP CS fixes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling
685d7b0637
Directly use the class to get the service 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling
e45c87cd2e
Fix creating the share controller 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling
609b8aff12
Also disallow ; in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-14 18:56:06 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
1584c9ae9c
Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup 
Remove all extra whitespace PSR2 does not like
 2020-04-09 20:39:37 +02:00
Christoph Wurst
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords 
Use php keywords in lowercase
 2020-04-09 16:25:14 +02:00
Christoph Wurst
f4c09f299d
Make sure there is exactly one newline after imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:14:31 +02:00
Christoph Wurst
bcd13296de
Make sure every file ends with an empty newline 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:11:50 +02:00
Christoph Wurst
44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst
36b3bc8148
Use php keywords in lowercase 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 14:04:56 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
f878ea9606
Remove user name from public sharing page 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-01 17:14:38 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Christoph Wurst
37786c4d74
Convert share event to an interaction event 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 16:16:45 +01:00
Roeland Jago Douma
e6ec084a58
Auto accept group shares for users added to a group 
In case auto accepting is enabled (the default). Users that are newly
added to a group should not have to accept those shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-25 08:51:27 +01:00
Julius Härtl
87393a760e Remove unused properties in ShareesAPIController 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-20 10:43:56 +01:00
Joas Schilling
6edb93fc4a
Allow the video player on the hide download 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-19 15:14:00 +01:00
Joas Schilling
8db32805be
Fix willReturnOnConsecutiveCalls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-13 11:11:00 +01:00
Joas Schilling
3930ab8e8a
Don't allow anchors and queries in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-12 13:44:48 +01:00
John Molakvoæ
9fda1ee39f
Merge pull request #19777 from nextcloud/fix/viewer-public 
Properly emit Viewer event on files and files_sharing
 2020-03-12 08:47:14 +01:00
Joas Schilling
24d0fb9fcd
Merge pull request #19861 from nextcloud/bugfix/noid/load-remote-shares-also-when-one-is-down 
Don't break when one remote share is down
 2020-03-11 09:36:57 +01:00
John Molakvoæ (skjnldsv)
92a6530c0f Properly emit Viewer event on files and files_sharing 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:28:27 +01:00
John Molakvoæ (skjnldsv)
6c968fe77d Fix import order and formatting 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:27:20 +01:00
Joas Schilling
f4918f208e
Unify the code a bit 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-10 19:36:57 +01:00
Joas Schilling
bbef026aa0
Use contacts name on federated activities 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-10 19:36:56 +01:00
Joas Schilling
886293fdcc
Don't break when one remote share is down 
getFileInfo can also return false

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-09 17:00:31 +01:00
Roeland Jago Douma
7613681627
Don't try to format deleted shares 
Fixes #15455

The issue is that we have a fallback for shares to use the target. So
when the target exists again we happily format it (not that the shares
are still invalid).

This just tries to get the node. If we can't then boom.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-02 09:18:04 +01:00
Joas Schilling
a792a31448
Allow single file downloads so the video player works again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-28 16:25:09 +01:00
Joas Schilling
841f2f3b04
Allow to overwrite share target mountpoints 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-17 09:04:19 +01:00
Roeland Jago Douma
302ea0650e
Merge pull request #19349 from nextcloud/bugfix/noid/prevent-download-on-secure-view 
Prevent archieved download on secure view
 2020-02-08 10:18:24 +01:00
Joas Schilling
35d4ca4d5d
Prevent archieved download on secure view 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-07 12:46:23 +01:00
Roeland Jago Douma
260892eb3b
Disable link shares of disabled users 
Fixes #10869

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-02-07 07:47:38 +01:00
Roeland Jago Douma
8f15e2d57a
Use the target for file notifications 
The node is not yet accessible if you did not accept the share yet.
So trying to get it results in an acception.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-24 12:43:17 +01:00
Julius Härtl
eb4c42d3d1
Make auto accepting the default and provide setting to enforce the share acceptance process 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-16 22:07:51 +01:00
Julius Härtl
fa966ebaf1
Remove global share accepter since auto-accepting is the default 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-16 22:07:51 +01:00
Roeland Jago Douma
960d89ae31
Listen to the right even for auto share accept 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-15 23:10:21 +01:00
Roeland Jago Douma
fc77f530d7
Don't show link shares hash in inherited share list 
This adds no value at all. Just showing the text "(Shared link)" now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-15 09:21:53 +01:00
Christoph Wurst
6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Maxence Lange
554c4a7cf8 moving ->getParent earlier 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-01-08 08:56:14 -01:00
Julius Härtl
445274cf93
Add pending share list to frontend 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 19:35:45 +01:00
Roeland Jago Douma
fbed6a3416
A pending shares overview 
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 08:53:33 +01:00
Roeland Jago Douma
fb6b84b5c9
Accept shares when you open mail 
Fixes #18380

When you open a direct share to yourself. We should autoaccept the
share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-06 16:48:21 +01:00
Roeland Jago Douma
1672ff3bef
Do not use $_GET 
The appframework is more than capable of handling this properly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-05 20:13:11 +01:00
Maxence Lange
441b81a3af confirm resharing rights if viewer is current owner 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-01-02 11:34:20 -01:00
Christoph Wurst
1b46621cd3
Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Roeland Jago Douma
b86990988e
Use the user from the notification 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-18 08:37:03 +01:00
Roeland Jago Douma
e7dc91002f
Allow users to specify to accept (internal) shares by default 
Fixes #18255

A new user setting allows a user to always accept (internal) shares. For
example if they don't like accepting shares manually ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-17 10:49:29 +01:00
Roeland Jago Douma
bb4264c565
config.php setting to always accept internal shares 
Part of #18255

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-16 09:07:25 +01:00
Roeland Jago Douma
c0229768f2
Fetch the share for the recipient 
Fixes #18020

For group shares your invite might be handled but that doesn't mean the
whole share is handled. So we just need to make sure to fetch the share
for the current user.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-09 12:23:38 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
5e14b299bc
Expose capability if the lookup server should be queried by default 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-05 08:38:33 +01:00
Roeland Jago Douma
7a45413559
Always do sharee lookup on lookup server in GS 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-05 08:38:33 +01:00
Maxence Lange
f2c7ca4584
fixing tests + avoid duplicate in getFormattedShares() 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-03 08:13:22 +01:00
Maxence Lange
ccf7d87c11
integration tests 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
add tests on non-owner pov

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
duplicate

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
small fixes

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
removed tags

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-03 08:10:27 +01:00
Maxence Lange
5794f14df9
Inherited Shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
working on users with resharing rights

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
-getLogger()

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
cleaning

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
fix type

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Update SharingRightsException.php
 2019-12-03 08:10:27 +01:00
John Molakvoæ (skjnldsv)
5cb11ca642
Fix tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2019-12-02 13:08:43 +01:00
John Molakvoæ (skjnldsv)
0bf6fcd6cd
Create sharing entry point with constants 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2019-12-02 08:58:50 +01:00
John Molakvoæ (skjnldsv)
f8af027686
Fix files_sharing app LoadSidebar event 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-12-02 08:58:50 +01:00
Roeland Jago Douma
8797ff70eb
Add capabilities 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 14:33:13 +01:00
Roeland Jago Douma
77d136cbdf
Apply share permission mask to all files obtained via shareinfo 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-26 11:07:01 +01:00
Roeland Jago Douma
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs 
Some php-cs fixes
 2019-11-25 14:07:00 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
waleczny
6e3ea09b1c
Get first element of nodes array 
Geting first element of nodes array instead of element with key 0. In some cases key 0 not exists in this array ie. when file is shared from group folder with member of this group who have no permission to read this file.
 2019-11-18 23:33:26 +01:00
Roeland Jago Douma
e16321368f
Fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-18 16:11:03 +01:00
Joas Schilling
d3b62893af
Make sure the super share also has a valid type 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
6d9afca14f
Fix "Invalid parameter number: mixed named and positional parameters" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
0fe4b717dc
Correctly use the displayname of the sharer in the notification 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
e79ab7d0c5
The share manager knows which provider can accept shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
19e1892d50
Use constants for the magic strings 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:45 +01:00
Joas Schilling
43517cfac6
Accept existing shares on update 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
60da25681e
Only restrict loading of group and user shares for now 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
8986910a7d
Add notifications for users that are added to the group 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
520042bbd0
Allow to accept group shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:36:58 +01:00
Joas Schilling
c79a56481b
Notifications for group shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:33:53 +01:00
Joas Schilling
e96c9e0e4a
Add the notifier and the API endpoint for user shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:33:50 +01:00
Joas Schilling
dcdbea54e6
Respect the accepted flag for group and user shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:13:38 +01:00
Roeland Jago Douma
1ac57e76fa
Add notification for shares about to expire 
Introduces a new command that will create notifications for users if
they have shares that will expire the next day.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-01 08:53:18 +01:00
John Molakvoæ (skjnldsv)
2fd057513a Fix current user edit/delete permissions 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-29 13:20:08 +01:00
John Molakvoæ (skjnldsv)
cc4362df4f Unify code to get shares of a file or also including subfiles 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-25 21:41:12 +02:00
John Molakvoæ (skjnldsv)
dbb6b4cbb9 Filter out duplicated shares before processing them 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-25 21:41:12 +02:00
Daniel Calviño Sánchez
8098abee60 Do not return shares with the current user 
Getting the shares of a file no longer returns shares with the current
user for consistency with the results when getting the shares including
subfiles.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:40:50 +02:00
Daniel Calviño Sánchez
1afefc2d9a Extract method to get all shares 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
222e5a9a9f Add missing share types when getting shares of a file 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
24febe1e41 Unify share type sorting when getting shares of a file or with subfiles 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
0599536c82 Remove unneeded calls to "ShareManager::shareProviderExists()" 
"ShareManager::getSharesBy()" already checks if the share provider
exists before returning the shares and, if the provider does not exist,
it returns an empty array. Therefore it is not needed to explicitly
check if the provider exists or not.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
j3l11234
fa4d71c456 Add support for download share on old android browser 
Signed-off-by: j3l11234 <297259024@qq.com>
 2019-10-21 21:29:49 +08:00
Daniel Calviño Sánchez
5c7c308220 Include the share in the Files_Sharing::loadAdditionalScripts event 
This provides a better context for apps using the event, for example to
load one script or another depending on whether the share is a file or a
folder.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-17 18:22:54 +02:00
Roeland Jago Douma
4a2f9fab66
Move over OCSShareAPIMIddleware to pure DI 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-10-16 22:53:09 +02:00
Joas Schilling
4d40eb61b4
List share download activity under sharing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-10-10 08:43:54 +02:00
John Molakvoæ (skjnldsv)
ff895abac0
Fix shares read permissions 
A user with reshare permissions on a file is now able to get any share
of that file (just like the owner).

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 21:40:30 +02:00
John Molakvoæ (skjnldsv)
b1069b29fa
Add checks for whether a user with access to a share can delete it 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 19:25:11 +02:00
John Molakvoæ (skjnldsv)
f02cff1304
Extract check for whether a user with access to a share can edit it 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 19:25:11 +02:00
John Molakvoæ (skjnldsv)
c49469c4d8
Prevent non owners to update others link shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 08:19:07 +02:00
John Molakvoæ (skjnldsv)
c8d50538b8
Use same settings for mail share as link shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 08:19:07 +02:00
Joas Schilling
15d39c48e6
Merge pull request #17021 from nextcloud/bye-spreed-hello-talk 
Bye Spreed namespace, hello Talk!
 2019-09-11 14:59:37 +02:00
Joas Schilling
858b18e34a
Bye Spreed namespace, hello Talk! 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-09-05 15:32:58 +02:00
Joas Schilling
70807a74c7
Correctly check for new default root 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-09-04 09:28:58 +02:00
Julius Härtl
64c63bb00b
Properly initialize the CacheJail for sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-09-03 18:07:59 +02:00
John Molakvoæ (skjnldsv)
b557f52c22
Add expiration event for shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-08-21 08:30:17 +02:00
Joas Schilling
85a80b05ac
Unify the permission checking in one place only 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-07-03 16:34:00 +02:00
Joas Schilling
7aa26b28a8
Correctly check share permissions when updating a re-sub-share 
Before this change the node you shared was checked for permissions.
This works when you reshare the folder that was shared with you.
However when you reshared a subfolder (e.g. as public link),
you could afterwards update the permissions and grant
create+update permissions although the share you receive was read-only.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-06-27 15:27:30 +02:00
tobiasKaminsky
b65a59568e
add "askForPassword" on capabilities for sharing 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-05-13 20:09:00 +02:00
Morris Jobke
2565e16770
Fix public upload by also load the semaphore method 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-05-07 23:48:06 +02:00
Daniel Calviño Sánchez
dfe9e3fb2e Do not allow JavaScript "eval" in the public share auth page with Talk 
Talk no longer uses JavaScript "eval", so the Content Security Policy
can now be configured to prevent its use in the public share
authentication page when the password is protected by Talk.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-04-10 16:46:19 +02:00
Maxence Lange
749fdab3b0 do not returns shared_with === currentUser 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-04-01 11:17:05 -01:00
Maxence Lange
0166990f01 fixing share format 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Maxence Lange
efbadf0cf2 issue during last push 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Maxence Lange
44c1feb938 returns reshares in API 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Morris Jobke
4b49e2eb52
Fix unnecessary boolean cast 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-06 10:12:58 +01:00
Morris Jobke
fde4c54136
Merge pull request #13790 from fretn/master 
Fix for crashing occ files:scan
 2019-03-06 10:12:14 +01:00
Christoph Wurst
e930a0ccbe
Search sharees on lookup server when explicitly requested by user 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-02-26 19:44:49 +01:00
Morris Jobke
ee68e8f47e
Merge pull request #13514 from nextcloud/fix-public-grid-toggle 
Fix grid toggle button on public page
 2019-02-25 21:18:42 +01:00
Christoph Wurst
f3023aaa85
Show sharing recommendations 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-02-25 07:25:21 +01:00
John Molakvoæ (skjnldsv)
ee2c45d60d
Fix grid toggle button on public page 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-02-21 09:17:57 +01:00
Julius Härtl
2ec5e2b588
Fix writable public folder share 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-02-19 10:18:26 +01:00
Roeland Jago Douma
0e72d38747
Catch Request exception in testRemoteUrl 
Else the background job fails hard if the remote has for example an
invalid certificate.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-02-15 23:06:21 +01:00
Jonas Sulzer
3a5d634ccc
add myself as @author 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:01 +01:00
Jonas Sulzer
e2ec22c43d
code styling 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:00 +01:00
Jonas Sulzer
5756d96ab9
restructure code 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:00 +01:00
Jonas Sulzer
30d4024d9d
only show "Add to your Nextcloud" on share link if federation is activated 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:38:31 +01:00