upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 26
62829 commits 651 branches 1179 tags 8.1 GiB
Commit graph

1000 commits

Author SHA1 Message Date
Carl Schwan
6beddbc163 Fix profiler trying to serialize invalid utf8 
The cookie value contains invalid utf8 characters most of the time so
let's just ignore it as it is also not that interesting to analyse.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-06-20 10:57:42 +00:00
Carl Schwan
a9e674bec0 Don't use slow hashing to check the LDAP binding 
Using password_hash is expensive and should be used for hashing
passwords when saving them in the database. Here we just want to see if
the bind was already done with the given password, so use a fast hashing
algorythm.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-05 16:59:26 +00:00
John Molakvoæ
1e5a879d2e
Fix createNamedParameter in LDAP migrations 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-07 11:34:13 +02:00
blizzz
835e28d0b2
Merge pull request #31661 from nextcloud/enh/user_ldap-add-command-to-unmap-groups 
Add ldap:reset-group command to unmap groups from LDAP
 2022-04-05 10:57:33 +02:00
Carl Schwan
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler 
Built-in profiler

This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
 2022-04-04 12:56:37 +02:00
Carl Schwan
7d272c54d0 Add a built-in profiler inside Nextcloud 
The webui is provided by a seperate application named profiler

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-04 10:28:26 +02:00
Côme Chilliet
d7a291039d Fix user_ldap unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:03 +00:00
Côme Chilliet
91d6e88c2f Add missing file 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:03 +00:00
Côme Chilliet
a2c030ffea Add type information to fix psalm error 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:02 +00:00
Côme Chilliet
77bdad84c2 Add ldap:reset-group command to unmap groups from LDAP 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-01 12:18:02 +00:00
Christoph Wurst
9c922ed15a Fix assignment of the LDAP Wizard connection 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-03-31 14:42:39 +02:00
Côme Chilliet
9fc00fdb82 Avoid updating _lastChange when nothing is changed in the configuration 
Had to set at least one var when creating an empty configuration in
 order to save the default values.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-31 08:38:05 +00:00
Côme Chilliet
bd9c4fbc07 Do not update _lastChanged on auto-detected attributes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-31 08:38:05 +00:00
Côme Chilliet
d07208bd2c Use the new octetLength function to filter lines to migrate 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-30 14:43:09 +00:00
Côme Chilliet
6c7ba01dfe Adapt max length limit in AbstactMapping to match database 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-30 14:43:09 +00:00
Arthur Schiwon
52b57eb753 shrink ldap_dn column to 4000 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-03-30 14:43:08 +00:00
Arthur Schiwon
2f49f4a0fe limit ldap_dn columns to 4000 
- enlarging string cols from 255 to more than 4000 fails on default
  Oracle installations for invalid datatype conversion

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-03-30 14:43:08 +00:00
Côme Chilliet
efebbacca4 Add octetLength and charLength to function builder, and tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 20:35:02 +00:00
Côme Chilliet
7dc3eb1e9e Use getLengthExpression to measure field length instead of like 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 20:35:02 +00:00
Arthur Schiwon
4656753df0
do not forget DB table prefix with truncate query 
- as used in LDAP's AbstractMapping::clear() method
- and in Comment's ManagerTest::setUp()
- fixes a DB Exception with Oracle

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-03-18 16:59:46 +01:00
Côme Chilliet
475a859aae
Merge pull request #31421 from nextcloud/fix/user_ldap-fix-ldap-connection-resets 
user_ldap fix ldap connection resets
 2022-03-17 09:13:44 +01:00
Carl Schwan
371fa1c49a
Merge pull request #31542 from nextcloud/psalm-userCounts 
Fix psalm issue about userCounts
 2022-03-14 11:27:43 +01:00
Carl Schwan
1bf5ab35a8 Use "use" to import namespaces 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-03-14 09:35:01 +01:00
Carl Schwan
8d7380a15d Fix psalm issue about userCounts 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-03-11 14:17:29 +01:00
Côme Chilliet
ccab35f23f
Fix similar potential problems with fetchOne loops 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-08 12:10:52 +01:00
Côme Chilliet
65a866556b
Fix duplicated UUID detection when there are empty uuids 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-08 11:57:33 +01:00
Côme Chilliet
df29acb343
Set $limit as int as well in Access::count private method 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-08 10:21:54 +01:00
Arthur Schiwon
16b6504cc6
code style 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-03-03 21:32:54 +01:00
Arthur Schiwon
f3668f2748
be conservative when reading from fresh created column 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-03-03 21:26:18 +01:00
Côme Chilliet
dab5ea958a
Fix unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 16:35:06 +01:00
Côme Chilliet
0c5bd588ed
Fix types in OCA\User_LDAP\Configuration 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 11:53:50 +01:00
Côme Chilliet
e80eb79a1e
Remove redundant is_array check 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 11:41:59 +01:00
Côme Chilliet
fb63484ced
Improve typing in user_ldap to detect problems early 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 11:12:09 +01:00
Côme Chilliet
8349530fb4
Fix executeRead when connection is reset because of a timeout 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 10:24:07 +01:00
Côme Chilliet
44680b5c3b
Make it explicit that a DN can be used for ldap:check-user 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-17 10:00:25 +01:00
Côme Chilliet
a6ad06f940
Improve typing in apps/user_ldap/lib/Command/CheckUser.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-17 09:58:51 +01:00
Côme Chilliet
a4f96c18e9
Remove parenthesis around return in apps/user_ldap/lib/Command/CheckUser.php 
Co-authored-by: Carl Schwan <carl@carlschwan.eu>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-17 09:58:51 +01:00
Côme Chilliet
75ce9a4832
Fix ldap:check-user method for newly created LDAP users 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-17 09:58:28 +01:00
Vincent Petry
cd1bf94181
Merge pull request #31073 from nextcloud/fix/user_ldap-fix-access-typing 
Improve typing in OCA\User_LDAP\Access and reduce psalm errors
 2022-02-10 17:53:58 +01:00
Côme Chilliet
bcfe99cc62
Fix psalm errors in apps/user_ldap/lib/Jobs/CleanUp.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-10 10:15:00 +01:00
Côme Chilliet
9f2db6e65d
Fix ldap:update-uuid 
Generators cannot be iterated with while or returned by an other
 generator, using foreach instead.
And a few other problems.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-10 10:15:00 +01:00
Arthur Schiwon
45d4c0bf66
add occ command to update UUIDs (incomplete) 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:14:59 +01:00
Arthur Schiwon
601ce05dab
allow to re-run migration step when backup DB is already created 
- to heal incomplete states from broken upgrades

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:14:59 +01:00
Arthur Schiwon
71fb44953e
invalidated duplicated UUIDs prior to migration change 
- in a proper setup there are no duplicated UUIDs
- not all setups are proper
- log warning to admin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-10 10:14:58 +01:00
Côme Chilliet
77add404b1
Remove mixed type not available in PHP 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-08 14:32:23 +01:00
Côme Chilliet
5f65d5a58d
Add a comment explaining how Helper::loginName2UserName can work 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-08 14:25:09 +01:00
Côme Chilliet
2a0b2250d2
Improve typing in OCA\User_LDAP\Access and reduce psalm errors 
This should avoid some PHP warning using PHP 8.1
 and help detecting type trouble early in the future.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-08 14:21:16 +01:00
Arthur Schiwon
2bf57cbab8
fix overwriting of SUCCESS and INVALID consts 
- already defined in Symfony\Component\Console\Command\Command

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-02-03 23:12:51 +01:00
Côme Chilliet
843b20c4e8
Remove useless indexes with duplicated names on backup table 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-01-13 17:21:26 +01:00
Côme Chilliet
7e4e919408
Fix user_ldap migration for long DNs support 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-01-13 14:06:59 +01:00