upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 26
62829 commits 651 branches 1179 tags 8.1 GiB
Commit graph

128 commits

Author SHA1 Message Date
Côme Chilliet
df29acb343
Set $limit as int as well in Access::count private method 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-08 10:21:54 +01:00
Côme Chilliet
dab5ea958a
Fix unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 16:35:06 +01:00
Côme Chilliet
fb63484ced
Improve typing in user_ldap to detect problems early 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 11:12:09 +01:00
Côme Chilliet
8349530fb4
Fix executeRead when connection is reset because of a timeout 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 10:24:07 +01:00
Côme Chilliet
44680b5c3b
Make it explicit that a DN can be used for ldap:check-user 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-17 10:00:25 +01:00
Vincent Petry
cd1bf94181
Merge pull request #31073 from nextcloud/fix/user_ldap-fix-access-typing 
Improve typing in OCA\User_LDAP\Access and reduce psalm errors
 2022-02-10 17:53:58 +01:00
Côme Chilliet
9f2db6e65d
Fix ldap:update-uuid 
Generators cannot be iterated with while or returned by an other
 generator, using foreach instead.
And a few other problems.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-10 10:15:00 +01:00
Côme Chilliet
77add404b1
Remove mixed type not available in PHP 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-08 14:32:23 +01:00
Côme Chilliet
2a0b2250d2
Improve typing in OCA\User_LDAP\Access and reduce psalm errors 
This should avoid some PHP warning using PHP 8.1
 and help detecting type trouble early in the future.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-08 14:21:16 +01:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-12 20:03:06 +01:00
Côme Chilliet
f3dcbfe146
Fix PHP 8.1 support for user_ldap application 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-16 09:43:30 +01:00
Côme Chilliet
480056de88
Fix sanitizing regex and add a test case for uppercase in username 
I did not find any test data that would fail with the previous regex,
 but still added data with uppercase to at least test that.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:10:38 +01:00
Côme Chilliet
158e73242e
Avoid use of iconv to get rid of unicode 
Using iconv for translit depends upon server configuration, locale, and
 PHP version. Using htmlentities instead to have a consistent behavior
 independent of configuration.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 10:30:14 +02:00
Côme Chilliet
51398d706a
Use Psr\Log\LoggerInterface in OCA\User_LDAP\Access 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-12 17:19:51 +02:00
Côme Chilliet
437048e9b6
Avoid PHP errors when the LDAP attribute is not found 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-12 12:44:26 +02:00
Arthur Schiwon
6ab30a669b
ensure that user and group IDs in LDAP's tables are also max 64chars 
- limitation by core tables (e.g. sharing), IDs are always 64chars
- when longer group IDs were requested they are hashed (does not affect
  displaynames)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-24 17:29:29 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Arthur Schiwon
2a5473e146
do not try to search after the last page 
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-04-27 12:52:26 +02:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Christoph Wurst
6a3321cefe
Merge pull request #25101 from nextcloud/fix/noid/ldap-known-groups 
LDAP: make actually use of batch read known groups
 2021-01-29 10:57:31 +01:00
Arthur Schiwon
ef0a3a92f4
silence log message 
- this appears too often (in some configurations) when qualifying group
members which do not meet the criteria

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-21 17:25:44 +01:00
Arthur Schiwon
02b703193a
really use known groups 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-12 20:52:52 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net 
Unify links to php.net
 2020-12-22 09:53:31 +01:00
Arthur Schiwon
fd1fd5afa4
user share manager to determine share ownership 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-26 16:05:28 +01:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Arthur Schiwon
5257efc5f2
remove logging message carrying no valuable information 
the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-12 09:10:23 +02:00
Morris Jobke
d72d9ff1f4
Merge pull request #21171 from nextcloud/enh/noid/tidy-up-group-ldap 
tidy up Group_LDAP
 2020-07-06 14:00:27 +02:00
Arthur Schiwon
b8bef4ded0
fix strings being passed where arrays where expected 
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-24 23:34:37 +02:00
Arthur Schiwon
3baa8d22a6
comment was wrong, block is needed nevertheless 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-24 17:51:11 +02:00
Arthur Schiwon
64fe042b0d
tidy up Group_LDAP 
* remove unused method
* resolve code duplication
* remove usage of deprectad Util::writeLog
* phpDoc updates
* signature updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-08 13:40:24 +02:00
Arthur Schiwon
15008a1798
fixes infinitely repeating LDPA search results with PHP <= 7.2 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-05-26 00:37:46 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Arthur Schiwon
4babdc082b
formatting 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-23 21:34:05 +02:00
Arthur Schiwon
32000dd1af
read records from DB for lists at once, not one by one. 
Keep a runtime cache of dn-id-mapping

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:39:54 +02:00
Arthur Schiwon
e8ddb4718c
consolidate groupsMatchFilter in groupsExist 
- less duplication
- profiting of the same cache entry

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:38:07 +02:00
Roeland Jago Douma
d9990b09b8
PHP-CS-Fixer green 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:25:17 +02:00
Arthur Schiwon
84619a5b9c
use serverControls directly with LDAP calls, fixes 19127 
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-14 12:58:28 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Arthur Schiwon
77c63e3b24
fixes auto-detecting UUID attributes 
the continue (and later the early return) avoided proper looping over the
attribute candidates.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-03-19 19:42:46 +01:00
Arthur Schiwon
407b8fddfc
remove noise from detectUuid and cache results 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-02-19 16:42:36 +01:00
Arthur Schiwon
79667b58a9
cache group existence early to save useless requests to LDAP 
we do it for users already

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 11:02:37 +01:00