Commit graph

6416 commits

Author SHA1 Message Date
fenn-cs
710287f6c8 fix(SharingDetailsView): Prevent illegal unselection of read permissions
With the exception of "file drop" on link shares all other shares need the read permissions at least.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-09 11:43:07 +00:00
fenn-cs
4c25c02fd9 refactor(SharingDetailsView): Use NC logger
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-08 20:39:13 +01:00
fenn-cs
9d1431c38a fix(FilesView): Update files view upon share creation/delete
Resolves : https://github.com/nextcloud/server/issues/44961

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-08 20:39:12 +01:00
fenn-cs
d505449e45 refactor(SharingInput): Remove unused addShare
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In https://github.com/nextcloud/server/pull/39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-03 13:44:20 +01:00
fenn-cs
37a55357b9 fix(ExternalSharing): Handle template share from external sources
The new sharing flow requires or implies that users should edit share before creating.
External sources should not created the share IF we would upon sharing details tab on first request.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-03 10:31:46 +00:00
Nextcloud bot
600ea7e460
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-07-03 00:20:25 +00:00
Louis
dbbbefa408
Merge pull request #46141 from nextcloud/backport/46097/stable28
[stable28] fix(files_sharing): Also set the expiration date timezone during validation
2024-07-01 12:03:23 +02:00
Nextcloud bot
934509f111
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-30 00:19:37 +00:00
Nextcloud bot
d379e4e587
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-29 00:19:59 +00:00
Nextcloud bot
faf3017762
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-28 00:20:56 +00:00
Louis Chemineau
d7093ed24b fix(files_sharing): Store the expiration date relative to the server's timezone
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-27 11:39:31 +02:00
Nextcloud bot
700628d233
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-27 00:20:10 +00:00
Nextcloud bot
9c018a3a5c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-24 00:19:46 +00:00
Nextcloud bot
b9b4f1d36a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-16 00:19:31 +00:00
Arthur Schiwon
3187425ca5
Merge pull request #45024 from nextcloud/man/backport/44839/stable28
[stable28] fix(files_sharing): Add one string for every share type + fix(sharingDetails): Show correct share target
2024-06-14 10:25:10 +02:00
Nextcloud bot
5a7e8a7f90
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-14 00:20:02 +00:00
fenn-cs
0bee2a6fca fix(shareManager): Respect empty expireDate in server
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 18:34:51 +02:00
Robin Appelman
0ab1cc5f17 refactor: make share manager buildable
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 18:34:51 +02:00
fenn-cs
67965863a7 fix(sharingDetails): Show correct share target
The share details page should show the target email or user/server to which

the user is creating the share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
2024-06-13 15:07:01 +01:00
Ferdinand Thiessen
e60fdc79c6 fix(files_sharing): Add one string for every share type to not assume any language
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-13 15:07:01 +01:00
fenn-cs
013768a9bc fix(files_sharing): Improve recursion in onNewLinShare
These changes fixes the issue of having the refresh the UI after share creation, as the share is not
immediately removed from the UI list.

Important changes

- The basis of checking wether a password/expire date is no longer based on config values alone
because the config is not expected in a share creation circle. Hence we check the configs and check
if the share object (this.share) has the expected values set. This way, once the required properties
are set, code control does not enter the block meant to handle the setting of required properties
unneccessarily.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 00:18:54 +01:00
fenn-cs
2b62e1794c refactor(ShareDetails): Prevent undefined errors for share.permissions
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-12 23:08:07 +01:00
skjnldsv
f1f2f5ca98 fix(files_sharing): dark avatar support
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:30:16 +02:00
skjnldsv
d991eaed92 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:23:39 +02:00
John Molakvoæ
436663f3c7
Merge pull request #44912 from nextcloud/backport/44838/stable28 2024-06-11 09:44:08 +02:00
Joas Schilling
4d748b9f5a fix(sharing): Don't change the type of the controller argument
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:10:29 +01:00
fenn-cs
3c507773b7 fix(shareApiController): avoid duplicated expiryDate operations
`expireDate` can be set once and used anywhere needed, the current implementation,

duplicates this behavior which leads to `parseDate` receiving an a date object it

parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
fenn-cs
30900ae751 refactor(shareApiController): use contrusctor property promotion & DI logger
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
Ferdinand Thiessen
684c067511 fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
John Molakvoæ
bf904e7faf
Merge pull request #44010 from nextcloud/backport/43252/stable28 2024-06-07 12:14:11 +02:00
Louis Chemineau
6fb0ac6116 fix(files_sharing): usage of NcTextField in SelectShareFolderDialogue
The NcTextField needs a value property to be set.

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2024-06-06 10:20:37 +00:00
Nextcloud bot
a62a1faf3b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-05 09:56:25 +00:00
Ferdinand Thiessen
dc1ca39f0f fix(deps): Update @nextcloud/event-bus to version 3.3.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 15:38:45 -07:00
Git'Fellow
1a50eb42e8 Fix backport
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-29 10:55:28 +02:00
Christoph Wurst
64469efa29 fix(sharing): Avoid (dead)locking during orphan deletion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[skip ci]
2024-05-29 10:55:28 +02:00
Nextcloud bot
2967c21465
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-08 00:21:13 +00:00
Nextcloud bot
bae9e2e6e1
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-07 00:20:24 +00:00
Nextcloud bot
d1a0b1946c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-03 00:20:05 +00:00
Côme Chilliet
369247338b
Merge pull request #44500 from nextcloud/backport/44484/stable28
[stable28] fix(share): Send correct share attributes upon share creation
2024-04-29 15:25:21 +02:00
Nextcloud bot
4be7b83426
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-27 00:20:28 +00:00
fenn-cs
bbb28fd483 fix(share): Send correct share attributes upon share creation
- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : https://github.com/nextcloud/server/issues/44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-04-26 20:59:57 +01:00
Nextcloud bot
4006d9961e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-26 00:21:20 +00:00
Nextcloud bot
93c8d1df3b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-25 00:21:04 +00:00
Nextcloud bot
fc8bbf6154
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-24 00:20:37 +00:00
Nextcloud bot
7da3f87817
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-23 00:21:02 +00:00
Nextcloud bot
a7b52f82f9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-22 00:21:18 +00:00
Nextcloud bot
1cb891c8fd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-21 00:20:48 +00:00
Nextcloud bot
8acbcf5edb
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-20 00:20:22 +00:00
Nextcloud bot
7fca7ff774
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-19 00:20:45 +00:00
Nextcloud bot
243a98adb6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-18 00:20:50 +00:00