Commit graph

155 commits

Author SHA1 Message Date
Julius Härtl
f3419c5f57
feat(settings): Add setup check for apcu cache expunge
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-27 10:45:32 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Ferdinand Thiessen
0563757ea4 fix(SetupCheck): Properly check public access to data directory
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.

For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.

¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +02:00
Git'Fellow
4488714148
Merge pull request #46353 from nextcloud/skipOPcacheCLI
fix(setupchecks): Skip checking for OPcache settings if running checks from CLI
2024-08-01 20:02:25 +02:00
Joas Schilling
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Benjamin Gaussorgues
202e5b1e95
feat(security): restrict admin actions to IP ranges
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Anna Larch
2201bce7d3 fix(caldav): lower scheduling table size warning
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-17 11:20:49 +02:00
Git'Fellow
fa84f52c3f
fix: typo
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:11:35 +02:00
Git'Fellow
372c9d2ee6
fix: check both CLI and value
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:09:29 +02:00
Git'Fellow
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 10:43:20 +02:00
Ferdinand Thiessen
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +02:00
Daniel
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled
fix(setupchecks): skip check when disk_free_space is disabled
2024-06-29 15:59:17 +02:00
Daniel Kesselberg
fd9fd1b6fb
fix(setupchecks): skip check when disk_free_space is disabled
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-28 13:06:49 +02:00
Ferdinand Thiessen
6601adcd6d
refactor(SetupCheck): Make mariadb and mysql version variables
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:22:42 +02:00
Ferdinand Thiessen
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +02:00
MichaIng
ea994fe8fb
fix(settings): make trailing slash for caldav/carddav redirects optional
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.

Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.

This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).

While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.

This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.

Signed-off-by: MichaIng <micha@dietpi.com>
2024-06-24 17:52:22 +02:00
Robin Appelman
e74f71b32e feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-18 14:46:19 +02:00
Andy Scherzinger
ec5b60af28
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +02:00
Anna Larch
ad78f7e48e fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-31 13:14:01 +02:00
Côme Chilliet
c31d6b1fdc
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-13 12:06:21 +02:00
Daniel
99f89bb3de
Merge pull request #45242 from nextcloud/check-memcache-memcached
fix(setupCheck): Only warn when memcache present w/o memcached
2024-05-13 11:53:27 +02:00
Ferdinand Thiessen
ef320200b9
fix: Move hint about firewall issues to common helper string
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-13 09:27:19 +02:00
Julius Härtl
a5fc9b1563
Merge pull request #45272 from nextcloud/check-db-missing-indices
feat(SetupChecks): Refactor DatabaseHasMissingIndices
2024-05-13 07:55:39 +02:00
Josh Richards
5b5178abe7 fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-12 18:09:36 -04:00
Josh Richards
229e5444c9 feat(SetupChecks): Refactor DatabaseHasMissingIndices
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-11 10:29:42 -04:00
Josh Richards
29157149c8 fix: oops vendor string embedded in version
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
2e94ec8832 fix: only compare major version of pgsql
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
3ce8c6d0db fix: refactor postgresql check to match mariadb/mysql
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
f486be8da1 fix: only compare minor mariadb version differences
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
2abd67cc02 fix(setupChecks): update db version checks
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
c0e395cc0d fix(setupCheck): Only warn when memcache present w/o memcached
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-09 11:45:16 -04:00
Côme Chilliet
37262c860a
fix(setupchecks): Fix opcache buffer check
This was broken by last codestyle update, maybe even before because of
 operator precedence. Now using vars to make it readable and correct at
 the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +02:00
Richard Steinmetz
9ef70f0c4e feat: drop support for php 8.0
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-04-08 11:28:54 +02:00
Anna
f63c0cf921
Merge pull request #44306 from nextcloud/settings/show-indextoreplace-warning
fix(settings): show warning for indexToReplace as part of missing indices
2024-04-05 13:14:43 +02:00
Josh
66fad4ae93 fix(SetupChecks): Add hint about dns/firewall if mjs check can't run
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 18:10:22 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Ferdinand Thiessen
14addf3fdb
fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +01:00
Johannes Merkel
33a0aa6994
fix(settings): show warning for indexToReplace as part of missing indices
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-03-19 11:44:00 +01:00
Côme Chilliet
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +01:00
Côme Chilliet
9f819f311f feat: Migrate HSTS check to Security headers SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
d7193ef65e fix: Migrate security headers check tests and fix the SetupCheck implementation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
310377e496 fix: Fix Security headers setup check behavior
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
1fffdf4763 fix: Fix ocm-provider setup check failure detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
a47a1e6249 feat: Migrate header check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Maxence Lange
519e434573 fix(updatenotification): spread the use of new appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 -01:00
Ferdinand Thiessen
58f57fd13f
fix(settings): Adjust order of parameters for runRequest
Fixing invalid request to host `HEAD`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 11:21:51 +01:00
Côme Chilliet
1ea88a73f6 feat(settings): Migrate .well-known URL setup check to new API
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +01:00
John Molakvoæ
a6a962d5a2
fix(settings): adjust source maps setup check wording and log level
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-06 15:11:32 +01:00
John Molakvoæ (skjnldsv)
f0494e2b5a
feat(settings): add JavaScript Source Maps support .js.map setup check
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-06 11:16:10 +01:00
Côme Chilliet
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +01:00