upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-11 14:54:02 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
58334 commits 694 branches 1182 tags 8.3 GiB
Commit graph

180 commits

Author SHA1 Message Date
Carl Schwan
00a9b0c1db Fix permissions when copying from ObjectStorage 
Make sure that when a user copy a file from a directory they don't have
all permissions to a directory where they have more permissions, the
permissions are correctly set to the one from the parent taget folder.

This was caused by the ObjectStoreStorage::copyFromStorage using
the jailed storage and cache entry instead of the unjailed one like other
storages (the local one).
Steps to reproduce

+ Use object storage
+ Create a groupfolder with one group having full permission and another one
  who can just read files.
+ With an user who is in the second group, copy a file from the groupfolder to
  the home folder of this user.
+ The file in the home folder of the user will be read only and can't be deleted
  even though it is in their home folder and they are the owner. In oc_filecache,
  the permissions stored for this file are 1 (READ)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-10-28 12:55:53 +00:00
Robin Appelman
99ba96524e
more reliable return value for Watcher::checkUpdate 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-26 14:45:08 +02:00
Robin Appelman
916a838873
[21] generate a better optimized query for path prefix search filters 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-12 15:55:57 +02:00
Robin Appelman
a9fbd0b41b
dont apply jail search filter is on the root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-29 14:22:38 +02:00
John Molakvoæ
218a96ebf9
Revert "[stable21] better cleanup of filecache when deleting an external storage" 2021-07-27 15:51:10 +02:00
Robin Appelman
feb640cd64
better cleanup of filecache when deleting an external storage 
this way it can delete the cache entries even with per-user credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-13 08:54:30 +02:00
Robin Appelman
a21eb8d6d2 properly use limit and offset for search in Jail wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-05-31 12:28:12 +00:00
Morris Jobke
cf8be87e47 Log when a storage is marked as unavailable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-03-25 16:10:28 +00:00
Morris Jobke
ffb7c51ca6
Merge pull request #26257 from nextcloud/backport/26198/stable21 
[stable21] Handle limit offset and sorting in files search
 2021-03-24 17:32:36 +01:00
John Molakvoæ (skjnldsv)
e9fafce71b Catch invalid cache source storage path 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-03-24 11:03:30 +00:00
Robin Appelman
2500d296c5 only require user to be set in a query that handles tags 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-23 13:41:11 +00:00
Morris Jobke
95ebe5e819
Merge pull request #26146 from nextcloud/backport/26013/stable21 
[stable21] Return the fileid from `copyFromCache` and use it instead of doing an extra query
 2021-03-17 20:03:58 +01:00
Morris Jobke
4b3684fbc4
Merge pull request #25943 from nextcloud/backport/25659/stable21 
[stable21] catch notfound and forbidden exception in smb::getmetadata
 2021-03-17 13:50:39 +01:00
Robin Appelman
44d4957548 verify that cache entry is valid 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 16:17:59 +00:00
Robin Appelman
f6f92e8bc6 also implement for FailedCache and NullCache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 16:17:58 +00:00
Robin Appelman
bb180a95bb add ICopyFromCache trait to expose existing implementation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-16 16:17:56 +00:00
Robin Appelman
c727879073 adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-15 17:51:34 +00:00
Robin Appelman
ec0985ba68 fix search in nested jails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-15 17:51:33 +00:00
Robin Appelman
eb56b1d0bd fix cachjail searching for root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-15 17:51:32 +00:00
Robin Appelman
046638abeb do cachejail search filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-15 17:51:32 +00:00
Robin Appelman
67d62a820c catch notfound and forbidden exception in smb::getmetadata 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-05 07:51:47 +00:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Robin Appelman
205386b24e
ignore files that have no read permissions during scanning 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-06 17:27:31 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
4973f9b952
Merge pull request #24715 from nextcloud/bug/noid/limit-get-incomplete-to-1 
Limit getIncomplete query to one row
 2020-12-21 09:15:10 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Daniel Kesselberg
e0e76bb784
Limit getIncomplete query to one row 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-12-15 21:42:26 +01:00
Robin Appelman
aef1cdba03
code style and dispatchTyped 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-12-02 16:15:02 +01:00
Robin Appelman
88f35d52d2
rename cache event to follow new naming standards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:39:46 +01:00
Robin Appelman
23fb497ff5
extend cache events 
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:22:03 +01:00
Joas Schilling
cffad62771
Empty string is returned as null, but empty string in file cache is the root and exists 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:35:43 +01:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 12:28:17 +01:00
Joas Schilling
c07720de77
Use query builder instead of OC_DB in OC\Files\* 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 09:05:15 +01:00
Joas Schilling
4b125d4402
Use Query builder function 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 12:13:22 +01:00
Joas Schilling
3c027bd0cf
Fix order of GREATEST for Oracle 
As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 12:13:22 +01:00
Christoph Wurst
0da89c0fa1
The file cache entry is array accessible 
… so let's make this part of our API. We use it as array already.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-13 10:47:00 +02:00
Roeland Jago Douma
b0c04a3e0c
Merge pull request #22867 from nextcloud/shared-storage-init-less 
Shared storage optimizations
 2020-09-17 08:55:35 +02:00
Morris Jobke
99c9423766
Remove @suppress SqlInjectionChecker 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 15:53:56 +02:00
Robin Appelman
cfde74442c
optimize View::getPath if we already know the storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-16 13:49:07 +02:00
Robin Appelman
244fd6ae49
disable update checking for shared storages 
update checking is already handled by the share source

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-15 16:42:40 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Robin Appelman
5af7d921a9
Make Cache::removeChildren non recursive 
Currently the "add new files during scanning" call stack is smaller than
the "remove deleted files during scanning" call stack. This can lead to
the scanner adding folders in the folder tree that are to deep to be
removed.

This changes the `removeChildren` logic to be non recursive so there is
no limit to the depth of the folder tree during removal

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-20 15:37:02 +02:00
Morris Jobke
fedf9c69d9
Use matching parameter names form interfaces and implementations 
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 18:16:35 +02:00
Robin Appelman
8c3b22859c
dont update mimetype when moving to trash 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-30 16:11:45 +02:00
Robin Appelman
c8cf2e8a5b
fix renameFromStorage messing with folder mimetype 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 20:31:35 +02:00
Robin Appelman
e9b5514186
prevent the root storage from accidentally scanning user folders 
while this scan *should* never be triggered, it's good to have some failsafe to ensure
that the users home contents don't end up getting scanned in the root storage

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-06-11 15:41:33 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Robin Appelman
9735b5d61f
Add method to storage backends to get directory content with metadata 
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-20 15:45:04 +02:00
Christoph Wurst
734c62bee0
Format code according to PSR2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:56:50 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00