upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-17 18:00:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
79918 commits 691 branches 1186 tags 6.6 GiB
Commit graph

1750 commits

Author SHA1 Message Date
John Molakvoæ
3f528a2726 fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2025-04-15 08:58:17 +00:00
skjnldsv
aec6eeb5b8 fix(files_sharing): rate limit share creation 10 times per 10 minutes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-15 08:58:17 +00:00
skjnldsv
f81ef274dd fix(files_sharing): fix share creation error handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-09 15:22:32 +00:00
Marcel Klehr
0273b4d0ba perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals 
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-03-28 14:46:30 +01:00
Côme Chilliet
8b41055297
fix(files_sharing): Use session id as part of cache key to avoid concurrency issues 
If several people are watching and seeking the same video file we do not
 want the cache key to be the same or it would flood activity again.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-27 12:19:02 +01:00
Côme Chilliet
d9b2178ee1
fix(files_sharing): Set higher priority for listeners that may abort the request 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-27 12:18:56 +01:00
Côme Chilliet
0c293b3569
fix: Avoid triggering several activities for Range request on the same file 
Avoids flooding activities when someone browse a video in the web player.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-27 12:18:51 +01:00
Côme Chilliet
97dbbe4768
fix: Fix download activity for folders 
Remove duplicate activity publishing from share controller download,
 listen to BeforeZipCreatedEvent to publish activity for folders, and
 cache folders activity to avoid sending activity for each file in the
 folder.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-27 12:18:46 +01:00
Côme Chilliet
6ff8d1e43b
fix(sharing): Publish activity for download by public link 
Even if dav endpoint is now used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-27 12:18:23 +01:00
Luka Trovic
833ec55728 fix(files_sharing): skip expiration notify for invalid share record 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2025-03-21 07:15:49 +01:00
Ferdinand Thiessen
324582729a
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:54:06 +01:00
Ferdinand Thiessen
aa7300b53d
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:39:33 +01:00
Ferdinand Thiessen
77ba2a6d75 fix(files_sharing): Also list deleted team shares 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-20 15:02:48 +00:00
Andy Scherzinger
f0a229c92f
Merge pull request #50880 from nextcloud/backport/50873/stable31 
[stable31] fix(files_sharing): block downloading if needed
 2025-02-19 20:45:17 +01:00
Ferdinand Thiessen
28fd638017 fix(files_sharing): block downloading if needed 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-18 13:31:31 +00:00
Git'Fellow
b2b37ba604 fix(SharedStorage): Check if storage ID is set on cache 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-02-14 15:01:39 +00:00
Robin Appelman
5eac86afec fix: don't use cached root info from shared cache if the watcher has detected an update 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-11 20:35:46 +01:00
nfebe
ba2a1ec72f refactor: Remove some deprecated containers and exceptions 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-02-06 12:55:10 +00:00
Ferdinand Thiessen
8fc1b6f1cd fix(sharing): Ensure download restrictions are not dropped 
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-04 15:06:11 +00:00
Andy Scherzinger
c99c135520
Merge pull request #50508 from nextcloud/backport/50436/stable31 
[stable31] fix: Harden files scanner for invalid null access
 2025-01-28 23:52:39 +01:00
Ferdinand Thiessen
26c93519f2 fix: Harden files scanner for invalid null access 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 19:49:03 +00:00
Ferdinand Thiessen
2926fe270a fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 17:26:28 +00:00
Ferdinand Thiessen
57949b2e22 fix: Ensure label is always a string 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-26 20:00:33 +00:00
Anna
d9a7124592
Merge pull request #49898 from nextcloud/fix/noid/no-emails-for-user-shares 
fix(sharing): send share emails for internal users too
 2025-01-16 18:50:30 +01:00
Christopher Ng
0eb39d7b9c feat(sharing): Respect admin custom tokens setting 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Christopher Ng
4d78de497f feat(sharing): Add custom_tokens capability 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Christopher Ng
beffb26266 feat(sharing): Fetch a unique generated token 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:49:19 -08:00
Christopher Ng
f92875cf6a feat(sharing): Allow updating share token 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:49:19 -08:00
provokateurin
90c608bdc7
fix(files_sharing): Fix sharee search result types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:21:21 +01:00
provokateurin
9f59204148
fix(files_sharing): Gracefully handle fetching non-existent share 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:21:20 +01:00
provokateurin
4dfa02c29d
fix(files_sharing): Handle null userId 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:19:54 +01:00
Anna Larch
236e084fbb fix(sharing): send share emails for internal users too 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2025-01-13 14:13:02 +01:00
skjnldsv
5c359e424f feat(federatedfilesharing): auto-accept shares from trusted servers 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-01-09 12:54:51 +01:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-06 14:30:40 +01:00
skjnldsv
bc0ad5efbf fix(federatedfilesharing): get share by token fallback 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-28 09:27:30 +01:00
skjnldsv
8089de5fcf fix(activity): make emails for link share uploads true by default 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 12:34:52 +01:00
Maxence Lange
4591430c9c feat(ocm): signing ocm requests 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-04 09:30:55 -01:00
Stephan Orbaugh
e87ed9b5fb
Merge pull request #49569 from nextcloud/shared-watcher-perf 
perf: improve performance of SharedStorage::getWatcher
 2024-12-03 09:57:56 +01:00
Robin Appelman
bc53a8ab87
perf: improve performance of SharedStorage::getWatcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-11-29 18:10:30 +01:00
Benjamin Gaussorgues
5581f0c7bf
chore: remove legacy action to test remote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-29 11:14:37 +01:00
Benjamin Gaussorgues
ae1c3b372e
chore: stricter access to testremote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-28 11:22:15 +01:00
Côme Chilliet
ae7f9cb3c1
Merge pull request #43025 from nextcloud/bugfix/error-on-reshare-after-transfer-ownership 
fix: update re-share if shared-by user has been revoked
 2024-11-25 18:20:29 +01:00
provokateurin
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
b658ab7a86
fix(files_sharing): Remove duplicate link/email edit share logic 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Côme Chilliet
f44a192613
fix(files_sharing): Fix error messages from password policy 
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-11-19 09:40:26 +01:00
Luka Trovic
2ca51919db fix(sharing): add command to fix broken shares after ownership transferring 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2024-11-18 21:24:23 +01:00
skjnldsv
4d9d617c84 feat(files_sharing): use share node or label as page title 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 14:20:58 +01:00
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-05 09:58:11 +01:00
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00