upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-17 01:41:05 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 32
79918 commits 693 branches 1185 tags 6.5 GiB
Commit graph

427 commits

Author SHA1 Message Date
Daniel Kesselberg
5e1cf1359d fix: remove caching in fetchListOfGroups 
When using nested groups without a memberof overlay, then fetchListOfGroups is called from getGroupsByMember without applying the group filter.

In some setups, the "unfiltered" result is then written back to the group mapping table. That might cause random "An administrator removed you from group" activities.

I was unable to replicate it locally, but we got the feedback that the random activities stopped with the patch applied.

Ref: https://github.com/nextcloud/server/issues/42195

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2025-02-27 15:35:22 +00:00
Côme Chilliet
12d1d1d389
fix(user_ldap): Remove now unused class FilesystemHelper 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-13 17:12:19 +01:00
Côme Chilliet
e75dd1fc92
fix(user_ldap): Strong type User class and fix most type issues 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-13 17:12:19 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Côme Chilliet
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config 
Add rector config
 2024-09-23 15:10:30 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 10:40:38 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Carl Schwan
986a3d45f8
feat(user_ldap): Introduce user id assigned typed events for LDAP usage 
Based on work from https://github.com/nextcloud/server/pull/32019

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2024-09-10 14:06:11 +02:00
Côme Chilliet
c3029c70d5
fix(user_ldap): Fix user_ldap tests by mocking new method exists in manager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-27 12:14:34 +02:00
Côme Chilliet
fffba1c6af
fix(ldap): Fix user_ldap attribute casing to fix tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-27 10:06:45 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Akhil
b1230cd53d Use cache in LDAP backend's checkPassword 
Signed-off-by: Akhil <akhil@e.email>
 2024-08-16 17:55:47 +05:30
Arthur Schiwon
0447aa4e62
fix(LDAP): remove unneeded dependencies 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-08-01 20:13:11 +02:00
Ferdinand Thiessen
14778811b4
refactor: Use IAppConfig for setting cron type 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-06-28 18:00:39 +02:00
Andy Scherzinger
2d62b0a936
Merge pull request #45573 from nextcloud/chore/noid/spdx-batch9 
Add SPDX header - batch 9
 2024-05-30 19:24:53 +02:00
Andy Scherzinger
8d8891c5bc
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-30 15:49:33 +02:00
Andrew Summers
d62eb333a7 Refactor OC\Server::getAvatarManager in user_ldap app 
Refactor `OC\Server::getAvatarManager` in user_ldap app (missed one)

Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
 2024-05-30 14:16:24 +02:00
Jake Nabasny
f863290572
feat(ldap): sync additional properties to profile and SAB 
Synced from LDAP to profile:
- Date of birth

Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth

Original code by Jake Nabasny (GitHub: @slapcat)

Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-05-30 12:01:13 +02:00
Côme Chilliet
2c0718b912
fix(user_ldap): Fix LDAP tests with new typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 11:24:38 +02:00
Côme Chilliet
d4229f9f59 fix(user_ldap): Fix tests using wrong types 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
c0ce272e9c chore: Migrate away from OC::$server->getLogger 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-13 17:32:30 +01:00
Côme Chilliet
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs 2024-02-08 18:27:44 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server" 
This reverts commit d9d60238c7, reversing
changes made to ba3fdb0cdc.
 2024-02-08 15:31:19 +01:00
Côme Chilliet
166773879b fix!: Migrate jobs away from deprecated interfaces 
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-08 10:28:29 +01:00
Arthur Schiwon
ee096f8629
fix(LDAP): ensure stored groups are formatted as simple list 
With array_unique it is possible that the keys are not in sequential order
but have gaps. json_encode then would store them as associative array,
which later on json_decode would result in a stdClass by default. This is
unexpected and would also contradict the return type hint.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-12-20 17:05:58 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Arthur Schiwon
cce8d0a7a5
fix(LDAP): solve race condition reading groups of disappeared LDAP user 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-10-11 15:35:10 +02:00
Arthur Schiwon
c1480aade4
refactor(LDAP): pass IConfig via constructor to Group_LDAP 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-10-10 11:18:57 +02:00
Arthur Schiwon
039da6bd22
refactor(tests): simplify code, reduce duplication 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-10-09 21:58:32 +02:00
Arthur Schiwon
9e2d9d5df9
test(Group LDAP): add test for getting groups of OfflineUser 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-10-09 21:08:28 +02:00
Aaron Dewes
aefa366495
Merge branch 'master' into fix/ldap-filter-generation 2023-09-20 15:38:52 +02:00
Julius Härtl
97dd09c434
Merge pull request #39128 from nextcloud/fix/35319/ldap-missing-avatar 2023-09-11 19:43:18 +02:00
Aaron Dewes
d79def553f Fix tests 
Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com>
 2023-08-13 15:43:04 +02:00
Côme Chilliet
2c19aac9e1
Move UpdateGroups methods to a service 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-08-10 10:57:33 +02:00
Joas Schilling
ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 23:13:37 +02:00
Arthur Schiwon
92a082d823
fix(ldap): avatar is not being fetched 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-05 17:13:43 +02:00
Côme Chilliet
b2f01b72fe
Merge pull request #34443 from nextcloud/feat/add-enabled-user-backend 
Add IProvideEnabledStateBackend interface
 2023-07-03 10:19:32 +02:00
Faraz Samapoor
b0938b9083 Refactors "strpos" calls in /apps/user_ldap to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 15:26:55 +03:30
Côme Chilliet
367b4fe9f2
Fix User_Proxy tests as well 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-25 15:55:04 +02:00
Côme Chilliet
add59d2309
Use DI for DeletedUsersIndex and fix tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-25 12:18:28 +02:00
Côme Chilliet
802363f0f6
Adapt Sync job tests to the constructor change 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:08:57 +02:00
Côme Chilliet
f6ff717b56
Merge pull request #34772 from nextcloud/fix/clean-ldap-access-factory-usage 
Make sure to use AccessFactory to create Access instances and use DI
 2022-12-20 16:48:07 +01:00
Côme Chilliet
6b7ffcd6a8
Fixed backup host logic 
Now forcing backup host applies to both main and background.
And background will fallback to backup if not responding.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-19 14:15:48 +01:00
Côme Chilliet
75e369d306
Merge pull request #35231 from nextcloud/fix/user_ldap-cache-fetched-list-of-groups 
Cache the fetched list of groups
 2022-12-19 12:34:05 +01:00
Côme Chilliet
723c1b8adc
Fix user_ldap tests now that list of groups gets cached 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-19 11:59:45 +01:00
Côme Chilliet
72c7fad1c4
Fix job tests in updatenotification and user_ldap applications 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 11:32:49 +01:00