Commit graph

214 commits

Author SHA1 Message Date
Ferdinand Thiessen
ba280a1968
fix(unified-search): do not overlap search with button
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 13:23:35 +02:00
Ferdinand Thiessen
7dc45631cf fix(core): adjust fronend code for changes in webauthn library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-01 19:10:11 +02:00
nfebe
2a631f4676 fix(login): Improve CSRF error message for better user understanding
This commit changes the CSRF error message displayed in the login form to
provide more specific information to the user. Instead of the generic less helpful error.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-03-25 14:49:04 +00:00
Ferdinand Thiessen
0b75350f24 fix(login): only show error state on login box if user interacted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-19 17:10:10 +01:00
nfebe
77c88e1ae7 fix(unified-search): filteredProviders now inherits all provider props
The main providers come from both the backend and client side plugins such as `in-folder` search.
The main providers may carry callbacks functions and other information that should be passed to the `filteredProviders`.
This is important because the current code does not make a distinction between `filteredProviders` and `providers`
rightly so, becuase they are the same thing!

Without the mentioned distinction above, sooner or later, we try to access a property on the `filteredProviders` which we
did not transfer with the manual property copy.

----

This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder
search filter.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 19:19:02 +01:00
nfebe
74200f28cb fix: Use searchFrom property for client side plugins
The client-side plugin `in-folder` uses the `files` provider, this makes it

overlap with the main files provider itself.

This change follows eecda06f1a after it was discovered

that some apps/providers like `dav` use providers from another app like `contacts`

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 12:10:34 +00:00
SebastianKrupinski
c1f9114e72 fix: unified search provider id
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 11:40:53 +00:00
nfebe
6e2e35f641 fix(unified-search): Prevent multiple file picker triggers in in-folder search
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 21:32:29 +01:00
nfebe
f2678b122e fix(unified-search): Use appId for searching
Each provider may search from a particular app so we should use that for searching.

Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous
approach is that it forces the provider id to be a valid search provider (an app that supports search)
limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers)
inside the places filter.

For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the
files provider itself already has id as `files`.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 21:32:29 +01:00
Ferdinand Thiessen
67e7c706f4 fix(unifiedsearch): Simplify and correct thumbnail styles
Ensure that the if a preview is available the maximum sizes are
respected (clickable area).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-27 17:42:19 +00:00
Maksim Sukharev
c464aeb228 fix(UnifiedSearch): request data only when opening modal
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-18 09:52:50 +01:00
Ferdinand Thiessen
24851d930d
chore: Resolve ESLint warnings
- Add default value to non-required Vue props
- Reformat function to async function if needed
- Add some documentation
- Allow `any` in places where it makes sense (tests)
- Order vue component sections as required

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 22:18:29 +01:00
nfebe
ed59ccea46 feat: Adapt providers disabled property to match user applied filters
Some filters are only available for certain providers, the UI should give the user
a hint to what providers such filters are available in.

Currently, if a filter (date or person) is not support by an a provider, the provider is
blurred out in the places dropdown.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-13 11:21:23 +01:00
Richard Steinmetz
f91446023d
feat(contacts-menu): implement custom javascript hook action
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-09 14:41:41 +01:00
Ferdinand Thiessen
0945169e57 fix(recommended-apps): Typo "screen sharing" vs "screensharing"
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 15:14:15 +01:00
Ferdinand Thiessen
52769a47ed fix(core): Do not use v-html for translation output
The content that can be renderered does *not* include HTML (see
`recommended` object).
But `v-html` was used, this is potentially dangerous, even though we
sanitize the translation values, so no urgent harm but better safe than
sorry.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:35:23 +00:00
Ferdinand Thiessen
f6e6ba4851 refactor(styles): Adjust code style in SCSS sources to match our stylelint config
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:42:13 +01:00
Faisal Alghamdi
cccdaa10eb Fix(core): fix app menu alignment in RTL mode.
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
2024-11-09 11:25:37 +01:00
Louis Chemineau
c0e5635ade fix: Vue app names
This improves the debugging experience in the vue dev tool.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-10-09 19:49:07 +02:00
Ferdinand Thiessen
04b25ba59d
feat: Implement Vue UI for public page menu
This adds a Vue implementation of the public page menu,
that is the menu that can be added using `PublicTemplateResponse::setHeaderActions`.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +02:00
fenn-cs
18d0f39109 fix(UnifiedSearch): Restore normal dialog size
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-08-30 10:08:58 +01:00
Ferdinand Thiessen
aea0e8df6a fix: Adjust more places for logical position
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Ferdinand Thiessen
7b048e0501 fix: Adjust some minor styles issues
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Mostafa Ahangarha
c5baf3d7ef Fix: float and clear
Fix other background-positions
Minor fix in link button icon position
Update header left and right to start and end

Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
Mostafa Ahangarha
723780d184 feat: Add bidi support in core directory
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
fenn-cs
cf59575120 fix(UnifiedSearch): Focus search input on open
Resolves : https://github.com/nextcloud/server/issues/47056

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-08-19 13:49:34 +01:00
Ferdinand Thiessen
21c30e5259
fix(AppMenu): Prevent menu entries from jumping on hover
Only grow and shrink app menu entry if needed

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 12:22:15 +02:00
Ferdinand Thiessen
ed16793089
fix: Make focussed app menu entry wider to see full name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 18:24:35 +02:00
Ferdinand Thiessen
7cef884297
fix: Make app menu overflow entries vertically aligned
The `name` property expects a `text` and just adds basically a "heading" for the text,
so lets instead just utilize the default slot.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 22:32:04 +02:00
Ferdinand Thiessen
91f78936c9 fix: Ensure app overflow menu is rendered centered
1. Fix app menu overflow button to be centered
2. Ensure the overflow calculation always just removed one element (incl. refactor to use `@vueuse`)
3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 21:29:00 +02:00
Sanskar Soni
55bb6ee87e feat(core): add selection for recommended apps
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
2024-08-06 17:30:15 +02:00
Ferdinand Thiessen
b2d053589a
fix(user_status): Adjust AccountMenu entry for user status
fixup: Adjust to design comments

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:52 +02:00
Ferdinand Thiessen
674805c994
fix(core): Migrate UserMenu / AccountMenu to NcListItem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:48 +02:00
skjnldsv
3ca6eb5098 fix(core): app menu notification should be in the top right
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 08:19:17 +00:00
skjnldsv
b92e0c7c6b fix(core): do not show unread notification on app menu hover
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-31 15:30:05 +00:00
skjnldsv
937bb4a539 fix(core): app menu label position and animation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-31 15:26:07 +00:00
Ferdinand Thiessen
4bcb0734cd
refactor: Fix some linting issues in frontend code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 22:45:13 +02:00
Ferdinand Thiessen
d82565d67d
refactor(core): Split app menu into components
This allows to split one large block of code into three components with each one usecase.
Allowing for better readability and maintainablility.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:24 +02:00
Ferdinand Thiessen
691f570237
chore: Enable ESLint for apps and fix all errors
Nevertheless this causes a huge amount of new warnings.
Previously the shell script for directories to lint was wrong it was generating all app names to lint,
but was missing the `apps/` prefix. Causing only `core` to be linted.

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
Ferdinand Thiessen
0ff17b857b
fix(UnifiedSearch): Implement design comments and focus input on open
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Marco Ambrosini
6ee965f0d9
feat: Add in-app search
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
81ad28f910
chore(deps): Update debounce to 2.1.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:10 +02:00
Marcel Müller
f6e6d7a834 fix(login): Prevent submitting the login form multiple times
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00
Marcel Müller
95148ffe92 fix(login): Disable login button when already logging in
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00
Ferdinand Thiessen
9d2c3c1164
fix: Adjust dashboard and header menu to use new background colors
fix(UnifiedSearch): Adjust to new background color

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-21 20:36:21 +02:00
Simon L.
3180779404 feat(login-mask): remove Login with from label
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-05-21 09:22:43 +00:00
Christopher Ng
0bd384637a chore(core): Change "username" to "account name"
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-05-17 10:15:46 -07:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-13 17:41:36 +02:00
fenn-cs
a51ab473da fix(unifiedSearch): Prevent broken avatars for federated users
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-29 01:12:30 +02:00
Ferdinand Thiessen
3880e4c8d7
fix: Use @simplewebauthn for frontend logic
This simplifies the code a lot and fixes errors with the exisiting custom code,
where slightly different base64 values were emitted which are not valid according to the standard.

ref: https://github.com/web-auth/webauthn-framework/issues/510

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 11:51:03 +02:00